Skip to contentSkip to conversation

regulator: dt-bindings: Add MAX20024 sd4

PATCH In review Rob Herring (Arm) 4 participants 4 messages Sep 22 – Sep 23

Subsystems (2)
lore
Share & tools
lore

Rob Herring (Arm)

author maintainer
#0 lore raw

PATCH 1/1 regulator: dt-bindings: Add MAX20024 sd4

Allow the MAX20024 extra sd4 regulator and its in-sd4 supply in the MAX77620 regulator schema. The other DCDC and LDO names remain unchanged.

Assisted-by LLM
---
 .../bindings/regulator/maxim,max77620-regulator.yaml | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
Documentation/devicetree/bindings/regulator/maxim,max77620-regulator.yaml +6 -6
index 7118c34961ba..0f2901cab8af 100644
@@ -10,17 +10,17 @@ maintainers:
   - Svyatoslav Ryhel <[email protected]>
 
 description:
-  Device has multiple DCDC(sd[0-3]) and LDOs(ldo[0-8]). The input supply
-  of these regulators are defined under parent device node. Details of
-  regulator properties are defined as child node under sub-node "regulators"
-  which is child node of device node.
+  Device has multiple DCDC (sd[0-3], plus sd4 on MAX20024) and LDOs
+  (ldo[0-8]). The input supply of these regulators are defined under parent
+  device node. Details of regulator properties are defined as child node under
+  sub-node "regulators" which is child node of device node.
 
 patternProperties:
-  "^in-(sd[0-3]|ldo(0-1|2|3-5|4-6|7-8))-supply$":
+  "^in-(sd[0-4]|ldo(0-1|2|3-5|4-6|7-8))-supply$":
     $ref: /schemas/types.yaml#/definitions/phandle
     description: Input supply for DCDC or LDO
 
-  "^(sd[0-3]|ldo[0-8])$":
+  "^(sd[0-4]|ldo[0-8])$":
     type: object
     $ref: /schemas/regulator/regulator.yaml#
     unevaluatedProperties: false
Signature · 1 line
2.53.0
#1 lore raw
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] docs: missing MAX77663 in sd4 regulator documentation --

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] docs: missing MAX77663 in sd4 regulator documentation
--

commit 6ef52d57b8dafa6b7fbd7ddad9b91b83cd6fe092
Author: Rob Herring (Arm) <[email protected]>

regulator: dt-bindings: Add MAX20024 sd4

Allow the MAX20024 extra sd4 regulator and its in-sd4 supply in the MAX77620 regulator schema.

Documentation/devicetree/bindings/regulator/maxim,max77620-regulator.yaml maintainers: · line 13

Quoted 13 lines
Documentation/devicetree/bindings/regulator/maxim,max77620-regulator.yaml +1 -4
index 7118c34961ba0..0f2901cab8afe 100644
@@ -10,17 +10,17 @@ maintainers:
   - Svyatoslav Ryhel <[email protected]>
 
 description:
-  Device has multiple DCDC(sd[0-3]) and LDOs(ldo[0-8]). The input supply
-  of these regulators are defined under parent device node. Details of
-  regulator properties are defined as child node under sub-node "regulators"
-  which is child node of device node.
+  Device has multiple DCDC (sd[0-3], plus sd4 on MAX20024) and LDOs

[Severity: Low]
Does this description omit MAX77663?

The driver code (drivers/regulator/max77620-regulator.c) defines sd4 for max77663_regs_info, and maxim,max77663 is a supported compatible string that utilizes this regulator schema via mfd/maxim,max77620.yaml. Omitting it from the updated description string creates an inaccuracy regarding which hardware variants support the sd4 regulator.

Quoted 3 lines
Documentation/devicetree/bindings/regulator/maxim,max77620-regulator.yaml +3 -0
+  (ldo[0-8]). The input supply of these regulators are defined under parent
+  device node. Details of regulator properties are defined as child node under
+  sub-node "regulators" which is child node of device node.
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
Reviewed-by on v1 1/1
#2 lore raw
In reply to Rob Herring (Arm)

ср, 23 вер. 2026 р. о 00:21 Rob Herring (Arm) <[email protected]> пише:

Quoted 40 lines

Allow the MAX20024 extra sd4 regulator and its in-sd4 supply in the MAX77620 regulator schema. The other DCDC and LDO names remain unchanged.

Assisted-by LLM
---
 .../bindings/regulator/maxim,max77620-regulator.yaml | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
Documentation/devicetree/bindings/regulator/maxim,max77620-regulator.yaml +6 -7
index 7118c34961ba..0f2901cab8af 100644
@@ -10,17 +10,17 @@ maintainers:
   - Svyatoslav Ryhel <[email protected]>
 
 description:
-  Device has multiple DCDC(sd[0-3]) and LDOs(ldo[0-8]). The input supply
-  of these regulators are defined under parent device node. Details of
-  regulator properties are defined as child node under sub-node "regulators"
-  which is child node of device node.
+  Device has multiple DCDC (sd[0-3], plus sd4 on MAX20024) and LDOs
+  (ldo[0-8]). The input supply of these regulators are defined under parent
+  device node. Details of regulator properties are defined as child node under
+  sub-node "regulators" which is child node of device node.
 
 patternProperties:
-  "^in-(sd[0-3]|ldo(0-1|2|3-5|4-6|7-8))-supply$":
+  "^in-(sd[0-4]|ldo(0-1|2|3-5|4-6|7-8))-supply$":
     $ref: /schemas/types.yaml#/definitions/phandle
     description: Input supply for DCDC or LDO
 
-  "^(sd[0-3]|ldo[0-8])$":
+  "^(sd[0-4]|ldo[0-8])$":
     type: object
     $ref: /schemas/regulator/regulator.yaml#
     unevaluatedProperties: false
--
Quoted 2 lines

2.53.0

Thank you!

maintainer
#3 lore raw
In reply to Rob Herring (Arm)
Quoted 1 line · Rob Herring (Arm)

regulator: dt-bindings: Add MAX20024 sd4

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-7.4

Thanks!

[1/1] regulator: dt-bindings: Add MAX20024 sd4

      https://git.kernel.org/broonie/regulator/c/3944065c67f5

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark