RDMA/selftests: Fix the kernel config fragment
Subsystems (2)
PATCH 1/1 RDMA/selftests: Fix the kernel config fragment
The config fragment lists bare option names with no values:
CONFIG_TUN
CONFIG_VETH
CONFIG_DUMMY
CONFIG_NET_NS
CONFIG_RDMA_RXE
which is not valid Kconfig syntax. When the fragment is merged, for example by "make kselftest-merge" or by CI systems, the lines are rejected:
.config:5514:warning: unexpected data: CONFIG_TUN .config:5515:warning: unexpected data: CONFIG_VETH .config:5516:warning: unexpected data: CONFIG_DUMMY
and none of the options gets enabled, so the rxe tests skip or fail for lack of the modules they load.
Give each option a value. The scripts load and unload tun, veth, dummy and rdma_rxe with modprobe, so build those as modules. RDMA_RXE also depends on INFINIBAND, and rxe_rping_between_netns.sh runs rping, which needs the RDMA CM userspace interface provided by INFINIBAND_USER_ACCESS, so add both.
Found by KernelCI kselftest builds.
--- tools/testing/selftests/rdma/config | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-)
tools/testing/selftests/rdma/config +7 -5
@@ -1,5 +1,7 @@ -CONFIG_TUN -CONFIG_VETH -CONFIG_DUMMY -CONFIG_NET_NS -CONFIG_RDMA_RXE +CONFIG_TUN=m +CONFIG_VETH=m +CONFIG_DUMMY=m +CONFIG_NET_NS=y +CONFIG_INFINIBAND=m +CONFIG_INFINIBAND_USER_ACCESS=m +CONFIG_RDMA_RXE=m
Signature · 1 line
2.53.0
[email protected]
AI reviewSashiko has reviewed this patch and found no issues. It looks great!
Quoted 17 lines
The config fragment lists bare option names with no values:
CONFIG_TUN
CONFIG_VETH
CONFIG_DUMMY
CONFIG_NET_NS
CONFIG_RDMA_RXEwhich is not valid
Kconfigsyntax. When the fragment is merged, for example by "make kselftest-merge" or by CI systems, the lines are rejected:.config:5514:warning: unexpected data:
CONFIG_TUN.config:5515:warning: unexpected data:CONFIG_VETH.config:5516:warning: unexpected data:CONFIG_DUMMY
[ ... ]
Quoted 4 lines
Fixes e01027cab38a ("RDMA/rxe: Add testcase for net namespace rxe")Fixes ecdcc8a455b7 ("RDMA/selftests: Add rxe_netns_names test")Assisted-by LLMSigned-off-by Sasha Levin <[email protected]>
Sashiko has reviewed this patch and found no issues. It looks great!
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
Quoted 25 lines · Sasha Levin
The config fragment lists bare option names with no values:
CONFIG_TUN
CONFIG_VETH
CONFIG_DUMMY
CONFIG_NET_NS
CONFIG_RDMA_RXEwhich is not valid
Kconfigsyntax. When the fragment is merged, for example by "make kselftest-merge" or by CI systems, the lines are rejected:.config:5514:warning: unexpected data:
CONFIG_TUN.config:5515:warning: unexpected data:CONFIG_VETH.config:5516:warning: unexpected data:CONFIG_DUMMYand none of the options gets enabled, so the rxe tests skip or fail for lack of the modules they load.
Give each option a value. The scripts load and unload tun, veth, dummy and
rdma_rxewith modprobe, so build those as modules.RDMA_RXEalso depends on INFINIBAND, andrxe_rping_between_netns.shruns rping, which needs the RDMA CM userspace interface provided byINFINIBAND_USER_ACCESS, so add both.
Quoted 6 lines
Found by KernelCI kselftest builds.
Fixes e01027cab38a ("RDMA/rxe: Add testcase for net namespace rxe")Fixes ecdcc8a455b7 ("RDMA/selftests: Add rxe_netns_names test")Assisted-by LLMSigned-off-by Sasha Levin <[email protected]>
The fix looks correct. The existing entries in tools/testing/selftests/rdma/config are
not valid config fragment assignments and are rejected by kselftest-merge.
Using m for the modules loaded by the RXE netns tests is appropriate,
while NET_NS=y provides the required network namespace support.
Adding INFINIBAND and INFINIBAND_USER_ACCESS also matches
the RXE/rping runtime dependencies.
Thanks a lot.
Zhu Yanjun
Quoted 21 lines
--- tools/testing/selftests/rdma/config | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-)tools/testing/selftests/rdma/config +7
-5@@ -1,5 +1,7 @@ -CONFIG_TUN -CONFIG_VETH -CONFIG_DUMMY -CONFIG_NET_NS -CONFIG_RDMA_RXE +CONFIG_TUN=m +CONFIG_VETH=m +CONFIG_DUMMY=m +CONFIG_NET_NS=y +CONFIG_INFINIBAND=m +CONFIG_INFINIBAND_USER_ACCESS=m +CONFIG_RDMA_RXE=m
Signature · 2 lines
Best Regards, Yanjun.Zhu
Quoted 27 lines · Sasha Levin
The config fragment lists bare option names with no values:
CONFIG_TUN
CONFIG_VETH
CONFIG_DUMMY
CONFIG_NET_NS
CONFIG_RDMA_RXEwhich is not valid
Kconfigsyntax. When the fragment is merged, for example by "make kselftest-merge" or by CI systems, the lines are rejected:.config:5514:warning: unexpected data:
CONFIG_TUN.config:5515:warning: unexpected data:CONFIG_VETH.config:5516:warning: unexpected data:CONFIG_DUMMYand none of the options gets enabled, so the rxe tests skip or fail for lack of the modules they load.
Give each option a value. The scripts load and unload tun, veth, dummy and
rdma_rxewith modprobe, so build those as modules.RDMA_RXEalso depends on INFINIBAND, andrxe_rping_between_netns.shruns rping, which needs the RDMA CM userspace interface provided byINFINIBAND_USER_ACCESS, so add both.Found by KernelCI kselftest builds.
Quoted 8 lines
Fixes e01027cab38a ("RDMA/rxe: Add testcase for net namespace rxe")Fixes ecdcc8a455b7 ("RDMA/selftests: Add rxe_netns_names test")Assisted-by LLMSigned-off-by Sasha Levin <[email protected]>Reviewed-by Zhu Yanjun <[email protected]>--- tools/testing/selftests/rdma/config | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-)
Applied to for-next, thanks
Jason