mm/damon/tests/core-kunit: add test for unconditionally skipping the last region
Subsystems (2)
PATCH v3 1/1 mm/damon/tests/core-kunit: add test for unconditionally skipping the last region
Commit b3723b596b54 ("mm/damon/core: fix unconditionally skip last region") fixed a minor bug.
Add a KUnit test case to cover this behavior and prevent regressions in the future.
---
Changes from v2:
- v2: https://lore.kernel.org/damon/[email protected]
- Change the commit message, mention the fix rather than the original bug.
Changes from v1 RESEND:
- v1 RESEND: https://lore.kernel.org/damon/[email protected]
- Drop braces for single line, as suggested [1] in coding-style.
- Set min_region_sz initial value to power-of-2 value, '1'.
- [1] https://docs.kernel.org/process/coding-style.html#placing-braces-and-spaces
Changes from v1:
- v1: https://lore.kernel.org/damon/[email protected]
- Resend since the dependent patch is merged into mm-new, that would help us getting AI review help.
--- mm/damon/tests/core-kunit.h | 42 +++++++++++++++++++++++++++++++++++++ 1 file changed, 42 insertions(+)
mm/damon/tests/core-kunit.h +42 -0
@@ -1632,6 +1632,47 @@ static void damon_test_rand(struct kunit *test) } } +static void damon_test_last_region_quota_reset (struct kunit *test) +{ +struct damos s = {0 }; +struct damon_target *t; +struct damon_region *r1, *r2; +unsigned long min_region_sz =1 ; +bool skipped; + + t =damon_new_target (); +if (!t) +kunit_skip (test,"target alloc fail" ); + + r1 =damon_new_region (0 ,100 ); +if (!r1) { +damon_free_target (t); +kunit_skip (test,"region 1 alloc fail" ); + } +damon_add_region (r1, t); + + r2 =damon_new_region (100 ,200 ); +if (!r2) { +damon_free_target (t); +kunit_skip (test,"region 2 alloc fail" ); + } +damon_add_region (r2, t); + + s.quota.charge_target_from = t; + s.quota.charge_addr_from = r1->ar.end; + + skipped =damos_skip_charged_region (t, r2, &s, min_region_sz); + +/* 'r2' is not processed, it should not skip */ +KUNIT_EXPECT_EQ (test, skipped, false); + +/* 'r2' is last region, it should reset charge_{target,addr}_from */ +KUNIT_EXPECT_PTR_EQ (test, s.quota.charge_target_from,NULL ); +KUNIT_EXPECT_EQ (test, s.quota.charge_addr_from,0 ); + +damon_free_target (t); +} +static struct kunit_case damon_test_cases[] = {KUNIT_CASE (damon_test_target),KUNIT_CASE (damon_test_regions),
@@ -1664,6 +1705,7 @@ static struct kunit_case damon_test_cases[] = {KUNIT_CASE (damon_test_is_last_region),KUNIT_CASE (damon_test_walk_control_obsolete),KUNIT_CASE (damon_test_rand), + KUNIT_CASE(damon_test_last_region_quota_reset), {}, };
Signature · 1 line
2.55.0
[email protected]
AI reviewSashiko has reviewed this patch and found no issues. It looks great!
Quoted 7 lines
Commit
b3723b596b54("mm/damon/core: fix unconditionally skip last region") fixed a minor bug.Add a KUnit test case to cover this behavior and prevent regressions in the future.
Signed-off-by Liew Rui Yan <[email protected]>
Sashiko has reviewed this patch and found no issues. It looks great!
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
Quoted 5 lines · On Mon, 28 Sep 2026 01:51:43 +0800 Liew Rui Yan <[email protected]>…
Commit
b3723b596b54("mm/damon/core: fix unconditionally skip last region") fixed a minor bug.Add a KUnit test case to cover this behavior and prevent regressions in the future.
Thank you for adding this test, Liew. Looks good to me.
Quoted 2 lines
Signed-off-by Liew Rui Yan <[email protected]>
This patch is applied to damon/next [1] tree. If this patch is not added to mm.git in short term (~1 week?), I will ask mm.git maintainer (Andrew Morton) to pick this. So, no action from your side is needed for now. If it seems I also forgot doing that or you cannot wait for my action, please feel free to ping me or Andrew.
[1] https://origin.kernel.org/doc/html/latest/mm/damon/maintainer-profile.html#scm-trees
Thanks,
SJ
[...]