bpf: Fix uninitialized known_memory read in check_mem_reg()
PATCH 1/1 bpf: Fix uninitialized known_memory read in check_mem_reg()
check_mem_reg() takes an optional bool *known_memory output parameter. When the register is NULL, the function returns early via mark_arg_precision() without setting *known_memory, leaving it uninitialized.
The caller in check_func_arg() declares 'bool known_memory' without initialization and reads it after check_mem_reg() returns:
bool known_memory;
err = check_mem_reg(..., &known_memory);
if (err < 0) {
if (known_memory)
...
}If mark_arg_precision() returns a negative value and the register was NULL, reading known_memory is undefined behavior. In practice only the diagnostic message selection is affected.
Fix by setting *known_memory = false before returning in the NULL register path, matching the intent that a NULL register does not imply the memory region is known.
--- kernel/bpf/verifier.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
kernel/bpf/verifier.c +4 -1
@@ -7652,8 +7652,11 @@ static int check_mem_reg(struct bpf_verifier_env *env, struct bpf_reg_state *reg {int size, err =0 ; -if (bpf_register_is_null (reg)) +if (bpf_register_is_null (reg)) { +if (known_memory) + *known_memory = false;return mark_arg_precision (env, argno); + }if (known_memory) *known_memory = true;
--
2.55.0