perlcross: Upgrade and drop redudant patch
cover perlcross: Upgrade and drop redudant patch
Jaipaul Cheernam (2):
perlcross: Upgrade 1.6.4 -> 1.6.5
perlcross: drop redundant LDFLAGS-when-linking-libperl patch
...ile-check-the-file-if-patched-or-not.patch | 2 +-
.../files/0001-patches-for-perl-5.44.0.patch | 110 ------------------
...oss-add-LDFLAGS-when-linking-libperl.patch | 24 ----
...Add-configure-checks-for-perl-5.44.0.patch | 47 --------
...Fix-checkfield-for-C23-compatibility.patch | 35 ------
.../perl-cross/files/determinism.patch | 4 +-
...{perlcross_1.6.4.bb => perlcross_1.6.5.bb} | 6 +-
7 files changed, 4 insertions(+), 224 deletions(-)
delete mode 100644 meta/recipes-devtools/perl-cross/files/0001-patches-for-perl-5.44.0.patch
delete mode 100644 meta/recipes-devtools/perl-cross/files/0001-perl-cross-add-LDFLAGS-when-linking-libperl.patch
delete mode 100644 meta/recipes-devtools/perl-cross/files/0002-Add-configure-checks-for-perl-5.44.0.patch
delete mode 100644 meta/recipes-devtools/perl-cross/files/0003-Fix-checkfield-for-C23-compatibility.patch
rename meta/recipes-devtools/perl-cross/{perlcross_1.6.4.bb => perlcross_1.6.5.bb} (75%)PATCH 1/2 perlcross: Upgrade 1.6.4 -> 1.6.5
CompareLog: https://github.com/arsv/perl-cross/compare/1.6.4...1.6.5
- Drop below patches which are part of release now (more details in compareLog) 0001-patches-for-perl-5.44.0.patch 0002-Add-configure-checks-for-perl-5.44.0.patch 0003-Fix-checkfield-for-C23-compatibility.patch
---
...ile-check-the-file-if-patched-or-not.patch | 2 +-
.../files/0001-patches-for-perl-5.44.0.patch | 110 ------------------
...oss-add-LDFLAGS-when-linking-libperl.patch | 2 +-
...Add-configure-checks-for-perl-5.44.0.patch | 47 --------
...Fix-checkfield-for-C23-compatibility.patch | 35 ------
.../perl-cross/files/determinism.patch | 4 +-
...{perlcross_1.6.4.bb => perlcross_1.6.5.bb} | 5 +-
7 files changed, 5 insertions(+), 200 deletions(-)
delete mode 100644 meta/recipes-devtools/perl-cross/files/0001-patches-for-perl-5.44.0.patch
delete mode 100644 meta/recipes-devtools/perl-cross/files/0002-Add-configure-checks-for-perl-5.44.0.patch
delete mode 100644 meta/recipes-devtools/perl-cross/files/0003-Fix-checkfield-for-C23-compatibility.patch
rename meta/recipes-devtools/perl-cross/{perlcross_1.6.4.bb => perlcross_1.6.5.bb} (80%)meta/recipes-devtools/perl-cross/files/0001-Makefile-check-the-file-if-patched-or-not.patch +1 -1
@@ -1,4 +1,4 @@ -From d0292a4f91ca22f8919a0f13d8961f98743bdbf1 Mon Sep 17 00:00:00 2001 +From 685f925eafa58630b1539eb97386653eadb95f23 Mon Sep 17 00:00:00 2001 From: Mingli Yu <[email protected]> Date: Fri, 2 Jul 2021 09:08:21 +0000 Subject: [PATCH] Makefile: check the file if patched or not
meta/recipes-devtools/perl-cross/files/0001-patches-for-perl-5.44.0.patch deleted +0 -110
110 lines not on this page · raw message
meta/recipes-devtools/perl-cross/files/0001-perl-cross-add-LDFLAGS-when-linking-libperl.patch +1 -1
@@ -1,4 +1,4 @@ -From c4ebb6d11d690185f66a3f0a591f193fd6611122 Mon Sep 17 00:00:00 2001 +From 10140792a3d9100ca38ddda5f47c0faeb26af1d4 Mon Sep 17 00:00:00 2001 From: Alexander Kanavin <[email protected]> Date: Tue, 27 Nov 2018 15:37:40 +0100 Subject: [PATCH] perl-cross: add LDFLAGS when linking libperl
meta/recipes-devtools/perl-cross/files/0002-Add-configure-checks-for-perl-5.44.0.patch deleted +0 -47
47 lines not on this page · raw message
meta/recipes-devtools/perl-cross/files/0003-Fix-checkfield-for-C23-compatibility.patch deleted +0 -35
@@ -1,35 +0,0 @@ -From 7faa8a36afb579f07101a48065e4a19729034807 Mon Sep 17 00:00:00 2001 -From: Jaipaul Cheernam <[email protected]> -Date: Wed, 22 Jul 2026 09:21:26 +0000 -Subject: [PATCH] configure_type_ext: Fix checkfield for C23/GCC 16 - -In C23, 'void foo()' means no parameters, so calling foo(value.field) -fails with GCC 16 when -Werror is used. This breaks detection of -struct fields like tm_gmtoff and tm_zone. - -Use (void)value.field instead, which works for any field type. - -Upstream-Status: Submitted [https://github.com/arsv/perl-cross/pull/178] -Signed-off-by: Jaipaul Cheernam <[email protected]> ---- - cnf/configure_type_ext.sh | 6 ++---- - 1 file changed, 2 insertions(+), 4 deletions(-) - -diff --git a/cnf/configure_type_ext.sh b/cnf/configure_type_ext.sh -index 0136c90..9ecd3fb 100644 ---- a/cnf/configure_type_ext.sh -+++ b/cnf/configure_type_ext.sh -@@ -7,11 +7,9 @@ checkfield() { - - try_start - try_includes $4 -- try_add 'void foo();' -- try_add 'void bar()' -- try_add "{" -+ try_add 'void bar(void) {' - try_add " $2 value;" -- try_add " foo(value.$3);" -+ try_add " (void)value.$3;" - try_add "}" - try_compile -
meta/recipes-devtools/perl-cross/files/determinism.patch +2 -2
@@ -1,4 +1,4 @@ -From 8fd84d6d760b21bad2c499b572951cc3f2235953 Mon Sep 17 00:00:00 2001 +From 454646b5ecd14e7bc1b54521f78b1af69549c108 Mon Sep 17 00:00:00 2001 From: Richard Purdie <[email protected]> Date: Wed, 5 Feb 2020 23:54:02 +0000 Subject: [PATCH] Fixes to make the perl build reproducible:
@@ -39,7 +39,7 @@ index 2f451c6..86bc865 100755 base=${0%/*}; test -z "$base" && base=. diff --git a/cnf/configure_mods.sh b/cnf/configure_mods.sh -index d4ef5a7..8e88b48 100644 +index da463d2..4299c1b 100644 --- a/cnf/configure_mods.sh +++ b/cnf/configure_mods.sh @@ -108,7 +108,7 @@ extonlyif() {
meta/recipes-devtools/perl-cross/perlcross_1.6.5.bb renamed from meta/recipes-devtools/perl-cross/perlcross_1.6.4.bb +1 -4
@@ -15,13 +15,10 @@ SRC_URI = "${GITHUB_BASE_URI}/download/${PV}/perl-cross-${PV}.tar.gz;name=perl-c file://0001-perl-cross-add-LDFLAGS-when-linking-libperl.patch \ file://determinism.patch \ file://0001-Makefile-check-the-file-if-patched-or-not.patch \ - file://0001-patches-for-perl-5.44.0.patch \ - file://0002-Add-configure-checks-for-perl-5.44.0.patch \ - file://0003-Fix-checkfield-for-C23-compatibility.patch \ " GITHUB_BASE_URI = "https://github.com/arsv/perl-cross/releases/" -SRC_URI[perl-cross.sha256sum] = "b6202173b0a8a43fb312867d85a8cd33527f3f234b1b6e591cdaa9895c9920c7" +SRC_URI[perl-cross.sha256sum] = "81130cd4b8c6d9eb2a1959f37d44391a46ad6a6794fc41fed5441f74e85e3dd0" S = "${UNPACKDIR}/perl-cross-${PV}"
Re: [OE-core] [PATCH 1/2] perlcross: Upgrade 1.6.4 -> 1.6.5
Quoted 8 lines · Jaipaul Cheernam via lists.openembedded.org
CompareLog: https://github.com/arsv/perl-cross/compare/1.6.4...1.6.5
- Drop below patches which are part of release now (more details in compareLog) 0001-patches-for-perl-5.44.0.patch 0002-Add-configure-checks-for-perl-5.44.0.patch 0003-Fix-checkfield-for-C23-compatibility.patch
Signed-off-by Jaipaul Cheernam <[email protected]>
Quoted 13 lines
---
...ile-check-the-file-if-patched-or-not.patch | 2 +-
.../files/0001-patches-for-perl-5.44.0.patch | 110 ------------------
...oss-add-LDFLAGS-when-linking-libperl.patch | 2 +-
...Add-configure-checks-for-perl-5.44.0.patch | 47 --------
...Fix-checkfield-for-C23-compatibility.patch | 35 ------
.../perl-cross/files/determinism.patch | 4 +-
...{perlcross_1.6.4.bb => perlcross_1.6.5.bb} | 5 +-
7 files changed, 5 insertions(+), 200 deletions(-)
delete mode 100644 meta/recipes-devtools/perl-cross/files/0001-patches-for-perl-5.44.0.patch
delete mode 100644 meta/recipes-devtools/perl-cross/files/0002-Add-configure-checks-for-perl-5.44.0.patch
delete mode 100644 meta/recipes-devtools/perl-cross/files/0003-Fix-checkfield-for-C23-compatibility.patch
rename meta/recipes-devtools/perl-cross/{perlcross_1.6.4.bb => perlcross_1.6.5.bb} (80%)Hello Jaipaul,
Do you think we should backport this to blacksail? Changelogs mention perl 5.44 compatiblity that we do have on blacksail.
Any ideas?
Thanks!
Signature · 2 lines
Yoann Congal Smile ECS
Re: [OE-core] [PATCH 1/2] perlcross: Upgrade 1.6.4 -> 1.6.5
Quoted 8 lines · Yoann Congal
Hello Jaipaul,
Do you think we should backport this to blacksail? Changelogs mention perl 5.44 compatiblity that we do have on blacksail.
Any ideas?
Thanks!
Hi Yoann,
Yes, its a good idea .
We can backport this to blacksail, as this upgrade only contains fixes that are local patches in recipe.
Let me know if I need to send a patch for this.
Regards,
Jaipaul
Re: [OE-core] [PATCH 1/2] perlcross: Upgrade 1.6.4 -> 1.6.5
Quoted 11 lines · Jaipaul Cheernam
Quoted 8 lines · Yoann Congal
Hello Jaipaul,
Do you think we should backport this to blacksail? Changelogs mention perl 5.44 compatiblity that we do have on blacksail.
Any ideas?
Thanks!
Quoted 8 lines
Hi Yoann,
Yes, its a good idea .
We can backport this to blacksail, as this upgrade only contains fixes that are local patches in recipe.
Let me know if I need to send a patch for this.
No need, I cherry-picked the commit from master.
Thanks!
Quoted 4 lines
Regards,
Jaipaul
Signature · 2 lines
Yoann Congal Smile ECS
PATCH 2/2 perlcross: drop redundant LDFLAGS-when-linking-libperl patch
In reply to Jaipaul Cheernam- Upstream PR #122 was reverted and replaced by appending ldflags to lddlflags at configure time.
perl recipe already passes -Alddlflags=' ${LDFLAGS}',
- Verified LDFLAGS still reach the libperl.so link (perl do_compile log, qemux86-64) after removing the patch.
--- ...oss-add-LDFLAGS-when-linking-libperl.patch | 24 ------------------- .../perl-cross/perlcross_1.6.5.bb | 1 - 2 files changed, 25 deletions(-) delete mode 100644 meta/recipes-devtools/perl-cross/files/0001-perl-cross-add-LDFLAGS-when-linking-libperl.patch
meta/recipes-devtools/perl-cross/files/0001-perl-cross-add-LDFLAGS-when-linking-libperl.patch deleted +0 -24
@@ -1,24 +0,0 @@ -From 10140792a3d9100ca38ddda5f47c0faeb26af1d4 Mon Sep 17 00:00:00 2001 -From: Alexander Kanavin <[email protected]> -Date: Tue, 27 Nov 2018 15:37:40 +0100 -Subject: [PATCH] perl-cross: add LDFLAGS when linking libperl - -Upstream-Status: Submitted [https://github.com/arsv/perl-cross/pull/122] -Signed-off-by: Alexander Kanavin <[email protected]> ---- - Makefile | 2 +- - 1 file changed, 1 insertion(+), 1 deletion(-) - -diff --git a/Makefile b/Makefile -index 4b80079..c6d6042 100644 ---- a/Makefile -+++ b/Makefile -@@ -191,7 +191,7 @@ endif - - ifeq ($(useshrplib),true) - $(LIBPERL): -- $(CC) $(LDDLFLAGS) -o $@ $(filter %$o,$^) $(LIBS) -+ $(CC) $(LDFLAGS) $(LDDLFLAGS) -o $@ $(filter %$o,$^) $(LIBS) - else - $(LIBPERL): - $(AR) cru $@ $(filter %$o,$^)
meta/recipes-devtools/perl-cross/perlcross_1.6.5.bb +0 -1
@@ -12,7 +12,6 @@ inherit allarch github-releases SRC_URI = "${GITHUB_BASE_URI}/download/${PV}/perl-cross-${PV}.tar.gz;name=perl-cross \ file://README.md \ - file://0001-perl-cross-add-LDFLAGS-when-linking-libperl.patch \ file://determinism.patch \ file://0001-Makefile-check-the-file-if-patched-or-not.patch \ "