Skip to contentSkip to conversation

Bluetooth: btusb: Preserve event and ACL packet ordering

PATCH Applied Kiran K 3 participants 3 messages Sep 29 Bluetooth drivers

lore
Share & tools
lore

Kiran K

author
#0 lore raw

PATCH 1/1 Bluetooth: btusb: Preserve event and ACL packet ordering

When force_poll_sync is enabled, commit 800fe5ec302e ("Bluetooth:
btusb: Add support for queuing during polling interval") defers ACL delivery to the RX worker. The event path currently wakes that worker before delivering the event, so queued ACL data can reach HCI first.

Deliver the event before waking the worker. This preserves the intended event-first ordering and the event callback's return value.

Fixes 800fe5ec302e ("Bluetooth: btusb: Add support for queuing during polling interval")
---
 drivers/bluetooth/btusb_main.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/bluetooth/btusb_main.c +4 -1
index 1ede12515bcc..cccdfb0461fe 100644
@@ -1311,13 +1311,16 @@ static inline void btusb_free_frags(struct btusb_data *data)
 static int btusb_recv_event(struct hci_dev *hdev, struct sk_buff *skb)
 {
 	struct btusb_data *data = hci_get_drvdata(hdev);
+	int err;
+
+	err = data->recv_event(hdev, skb);
 
 	if (data->intr_interval) {
 		/* Trigger dequeue immediately if an event is received */
 		schedule_delayed_work(&data->rx_work, 0);
 	}
 
-	return data->recv_event(hdev, skb);
+	return err;
 }
 
 static int btusb_recv_intr(struct btusb_data *data, void *buffer, int count)
Signature · 1 line
2.54.0
#1 lore raw

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/series/1175800/

---Test result---

Test Summary:

CheckPatch                    PASS      0.69 seconds
VerifyFixes                   PASS      0.11 seconds
VerifySignedoff               PASS      0.12 seconds
GitLint                       PASS      0.29 seconds
SubjectPrefix                 PASS      0.10 seconds
BuildKernel                   PASS      29.29 seconds
CheckAllWarning               PASS      33.41 seconds
CheckSparse                   PASS      36.09 seconds
BuildKernel32                 PASS      29.29 seconds
CheckKernelLLVM               PASS      37.93 seconds
TestRunnerSetup               PASS      788.66 seconds
IncrementalBuild              PASS      34.38 seconds

https://github.com/bluez/bluetooth-next/pull/838

---
Regards,
Linux Bluetooth

#2 lore raw
In reply to Kiran K
This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <[email protected]>:

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <[email protected]>:

Quoted 9 lines · On Tue, 29 Sep 2026 12:15:56 +0530 you wrote:

When force_poll_sync is enabled, commit 800fe5ec302e ("Bluetooth:
btusb: Add support for queuing during polling interval") defers ACL delivery to the RX worker. The event path currently wakes that worker before delivering the event, so queued ACL data can reach HCI first.

Deliver the event before waking the worker. This preserves the intended event-first ordering and the event callback's return value.

[...]

Here is the summary with links:
- [v1] Bluetooth: btusb: Preserve event and ACL packet ordering

    https://git.kernel.org/bluetooth/bluetooth-next/c/08c3c483047d

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html