FAILED: patch "[PATCH] i2c: qcom-geni: Fix hardcoded clock index in SE_GENI_CLK_SEL" failed to apply to 6.6-stable tree
Subsystems (4)
[email protected]
maintainerThe patch below does not apply to the 6.6-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
To reproduce the conflict and resubmit, you may use the following commands:
git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.6.y
git checkout FETCH_HEAD
git cherry-pick -x cb97bf3d4f91453b881acaf8e9f0cc47bb40b604
# <resolve conflicts, build, test, etc.>
git commit -s
git send-email --to '<[email protected]>' --in-reply-to '2026092908-grasp-skylight-e539@gregkh' --subject-prefix 'PATCH 6.6.y' 'HEAD^..'
Possible dependencies:
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From cb97bf3d4f91453b881acaf8e9f0cc47bb40b604 Mon Sep 17 00:00:00 2001
From: Viken Dadhaniya <[email protected]>
Date: Mon, 21 Sep 2026 17:17:01 +0530
Subject: [PATCH] i2c: qcom-geni: Fix hardcoded clock index in SE_GENI_CLK_SEL
qcom_geni_i2c_conf() writes a hardcoded 0 to SE_GENI_CLK_SEL, which selects an index from the hardware clock performance table. This always picks the first table entry regardless of the actual source clock configuration. On platforms where the matching entry is not at index 0, the wrong source clock divider is active and the I2C bus runs at an incorrect frequency.
Use geni_se_clk_freq_match() in geni_i2c_clk_map_idx() to find the performance table index for the source clock (32 MHz or 19.2 MHz). Store the resolved index in a new clk_idx field in geni_i2c_dev and write it to SE_GENI_CLK_SEL instead of the hardcoded 0.
drivers/i2c/busses/i2c-qcom-geni.c +33 -5
@@ -82,6 +82,9 @@ enum geni_i2c_err_code {#define XFER_TIMEOUT HZ#define RST_TIMEOUT HZ +#define GENI_SE_CLK_32MHZ (32 * HZ_PER_MHZ) +#define GENI_SE_CLK_19P2MHZ 19200000UL +struct geni_i2c_desc {bool no_dma_support;unsigned int tx_fifo_depth;
@@ -127,6 +130,7 @@ struct geni_i2c_dev {spinlock_t lock;u32 clk_freq_out;const struct geni_i2c_clk_fld *clk_fld; +u32 clk_idx;void *dma_buf;size_t xfer_len;dma_addr_t dma_addr;
@@ -197,19 +201,44 @@ static const struct geni_i2c_clk_fld geni_i2c_clk_map_32mhz[] = {static int geni_i2c_clk_map_idx (struct geni_i2c_dev *gi2c) {const struct geni_i2c_clk_fld *itr; +unsigned long res_freq; -if (clk_get_rate (gi2c->se.clk) ==32 *HZ_PER_MHZ ) +/* +* Frequency counter tables are calibrated for a specific source +* clock frequency and are not valid for any multiple of it +* (e.g. 64 MHz, 128 MHz). +* Use exact=true and verify res_freq matches req_freq literally +* to reject harmonics: a 64 MHz clock that divides evenly to +* 32 MHz would pass exact matching but produce double the intended +* I2C frequency with these counter values. +*/ +if (!geni_se_clk_freq_match (&gi2c->se,GENI_SE_CLK_32MHZ , + &gi2c->clk_idx, &res_freq, true) && + res_freq ==GENI_SE_CLK_32MHZ ) { itr = geni_i2c_clk_map_32mhz; -else + }else if (!geni_se_clk_freq_match (&gi2c->se,GENI_SE_CLK_19P2MHZ , + &gi2c->clk_idx, &res_freq, true) && + res_freq ==GENI_SE_CLK_19P2MHZ ) { itr = geni_i2c_clk_map_19p2mhz; + }else { +dev_err (gi2c->se.dev, +"Unsupported SE source clock: must be exactly 32 MHz or 19.2 MHz\n" ); +return -EINVAL ; + }while (itr->clk_freq_out !=0 ) {if (itr->clk_freq_out == gi2c->clk_freq_out) { gi2c->clk_fld = itr; +dev_dbg (gi2c->se.dev, +"I2C clk selected: freq: %u Hz, clk_idx: %u\n" , + gi2c->clk_freq_out, gi2c->clk_idx);return 0 ; } itr++; } + +dev_err (gi2c->se.dev,"Unsupported I2C output frequency %u Hz\n" , gi2c->clk_freq_out); +return -EINVAL ; }
@@ -219,7 +248,7 @@ static int qcom_geni_i2c_conf(struct geni_se *se, unsigned long freq)const struct geni_i2c_clk_fld *itr = gi2c->clk_fld;u32 val; -writel_relaxed (0 , gi2c->se.base +SE_GENI_CLK_SEL ); +writel_relaxed (gi2c->clk_idx, gi2c->se.base +SE_GENI_CLK_SEL ); val = (itr->clk_div <<CLK_DIV_SHFT ) |SER_CLK_EN ;writel_relaxed (val, gi2c->se.base +GENI_SER_M_CLK_CFG );
@@ -1111,8 +1140,7 @@ static int geni_i2c_resources_init(struct geni_se *se) ret =geni_i2c_clk_map_idx (gi2c);if (ret) -return dev_err_probe (gi2c->se.dev, ret,"Invalid clk frequency %d Hz\n" , - gi2c->clk_freq_out); +return ret;return geni_icc_set_bw_ab (&gi2c->se,GENI_DEFAULT_BW ,GENI_DEFAULT_BW ,Bps_to_icc (gi2c->clk_freq_out));
Sasha Levin
maintainerPATCH 1/1 i2c: qcom-geni: Fix hardcoded clock index in SE_GENI_CLK_SEL
From: Viken Dadhaniya <[email protected]>
[ Upstream commit cb97bf3d4f91453b881acaf8e9f0cc47bb40b604 ]
qcom_geni_i2c_conf() writes a hardcoded 0 to SE_GENI_CLK_SEL, which selects an index from the hardware clock performance table. This always picks the first table entry regardless of the actual source clock configuration. On platforms where the matching entry is not at index 0, the wrong source clock divider is active and the I2C bus runs at an incorrect frequency.
Use geni_se_clk_freq_match() in geni_i2c_clk_map_idx() to find the performance table index for the source clock (32 MHz or 19.2 MHz). Store the resolved index in a new clk_idx field in geni_i2c_dev and write it to SE_GENI_CLK_SEL instead of the hardcoded 0.
--- drivers/i2c/busses/i2c-qcom-geni.c | 33 +++++++++++++++++++++++++----- 1 file changed, 28 insertions(+), 5 deletions(-)
drivers/i2c/busses/i2c-qcom-geni.c +28 -5
@@ -77,6 +77,8 @@ enum geni_i2c_err_code {#define XFER_TIMEOUT HZ#define RST_TIMEOUT HZ +#define GENI_SE_CLK_19P2MHZ 19200000UL +struct geni_i2c_dev {struct geni_se se;u32 tx_wm;
@@ -91,6 +93,7 @@ struct geni_i2c_dev {struct clk *core_clk;u32 clk_freq_out;const struct geni_i2c_clk_fld *clk_fld; +u32 clk_idx;int suspended;void *dma_buf;size_t xfer_len;
@@ -157,13 +160,36 @@ static int geni_i2c_clk_map_idx(struct geni_i2c_dev *gi2c) {int i;const struct geni_i2c_clk_fld *itr = geni_i2c_clk_map; +unsigned long res_freq; + +/* +* Frequency counters are calibrated for a 19.2 MHz source clock +* and are not valid for any multiple of it (e.g. 38.4 MHz). +* Use exact=true and verify res_freq matches req_freq literally +* to reject harmonics that would produce an incorrect I2C frequency. +* ACPI systems have firmware-managed clocks and retain the default index. +*/ +if (!has_acpi_companion (gi2c->se.dev) && + (geni_se_clk_freq_match (&gi2c->se,GENI_SE_CLK_19P2MHZ , + &gi2c->clk_idx, &res_freq, true) || + res_freq !=GENI_SE_CLK_19P2MHZ )) { +dev_err (gi2c->se.dev, +"Unsupported SE source clock: must be exactly 19.2 MHz\n" ); +return -EINVAL ; + }for (i =0 ; i <ARRAY_SIZE (geni_i2c_clk_map); i++, itr++) {if (itr->clk_freq_out == gi2c->clk_freq_out) { gi2c->clk_fld = itr; +dev_dbg (gi2c->se.dev, +"I2C clk selected: freq: %u Hz, clk_idx: %u\n" , + gi2c->clk_freq_out, gi2c->clk_idx);return 0 ; } } + +dev_err (gi2c->se.dev,"Unsupported I2C output frequency %u Hz\n" , gi2c->clk_freq_out); +return -EINVAL ; }
@@ -172,7 +198,7 @@ static void qcom_geni_i2c_conf(struct geni_i2c_dev *gi2c)const struct geni_i2c_clk_fld *itr = gi2c->clk_fld;u32 val; -writel_relaxed (0 , gi2c->se.base +SE_GENI_CLK_SEL ); +writel_relaxed (gi2c->clk_idx, gi2c->se.base +SE_GENI_CLK_SEL ); val = (itr->clk_div <<CLK_DIV_SHFT ) |SER_CLK_EN ;writel_relaxed (val, gi2c->se.base +GENI_SER_M_CLK_CFG );
@@ -810,11 +836,8 @@ static int geni_i2c_probe(struct platform_device *pdev)return gi2c->irq; ret =geni_i2c_clk_map_idx (gi2c); -if (ret) { -dev_err (dev,"Invalid clk frequency %d Hz: %d\n" , - gi2c->clk_freq_out, ret); +if (ret)return ret; - } gi2c->adap.algo = &geni_i2c_algo;init_completion (&gi2c->done);
Signature · 1 line
2.53.0