staging: rtl8723bs: remove CamelCase variable pbDriverStopped
PATCH 1/1 staging: rtl8723bs: remove CamelCase variable pbDriverStopped
Rename the pointer variable pbDriverStopped to driver_stopped to eliminate the use of CamelCase and Hungarian notation prefixes. This aligns the driver's HAL code with standard Linux kernel coding style guidelines and resolves checkpatch.pl audit warnings.
--- drivers/staging/rtl8723bs/hal/odm.c | 2 +- drivers/staging/rtl8723bs/hal/odm.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8723bs/hal/odm.c +1 -1
@@ -773,7 +773,7 @@ void ODM_CmnInfoHook(struct dm_odm_t *pDM_Odm, enum odm_cmninfo_e CmnInfo, voidbreak ;case ODM_CMNINFO_DRV_STOP : - pDM_Odm->pbDriverStopped = pValue; + pDM_Odm->driver_stopped = pValue;break ;case ODM_CMNINFO_PNP_IN :
drivers/staging/rtl8723bs/hal/odm.h +1 -1
@@ -848,7 +848,7 @@ struct dm_odm_t { /* DM_Out_Source_Dynamic_Mechanism_Structure *//* common */ -bool *pbDriverStopped; +bool *driver_stopped;bool *pbDriverIsGoingToPnpSetPowerSleep;bool *pinit_adpt_in_progress;
Signature · 1 line
2.55.0
Greg KH
maintainerQuoted 16 lines · Luca Hernandez
Rename the pointer variable pbDriverStopped to
driver_stoppedto eliminate the use of CamelCase and Hungarian notation prefixes. This aligns the driver's HAL code with standard Linux kernel coding style guidelines and resolves checkpatch.pl audit warnings.Signed-off-by Luca Hernandez <[email protected]>--- drivers/staging/rtl8723bs/hal/odm.c | 2 +- drivers/staging/rtl8723bs/hal/odm.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)drivers/staging/rtl8723bs/hal/odm.c +0
-0
drivers/staging/rtl8723bs/hal/odm.c void ODM_CmnInfoHook(struct dm_odm_t *pDM_Odm, enum odm_cmninfo_e CmnInfo, void · line 776
Quoted 5 lines
drivers/staging/rtl8723bs/hal/odm.c +1
-1@@ -773,7 +773,7 @@ void ODM_CmnInfoHook(struct dm_odm_t *pDM_Odm, enum odm_cmninfo_e CmnInfo, voidbreak ;case ODM_CMNINFO_DRV_STOP : - pDM_Odm->pbDriverStopped = pValue; + pDM_Odm->driver_stopped = pValue;
So this is only set but never done anything with at all? Why is this needed? Why not just remove this field entirely?
thanks,
greg k-h