ALSA: usb-audio: add sample-rate quirk for Yamaha 01V96i
PATCH v2 1/1 ALSA: usb-audio: add sample-rate quirk for Yamaha 01V96i
The Yamaha 01V96i exposes its audio streaming interfaces as vendor-specific USB class 0xff and ships no class-specific endpoint descriptor. parse_uac_endpoint_attributes() therefore returns no attributes for the device, and without UAC_EP_CS_ATTR_SAMPLE_RATE the driver never issues the SET_CUR sampling-frequency request the hardware needs to start its USB audio stream. The playback and capture PCMs are reported as RUNNING and their pointers advance, but the mixer passes no audio in either direction.
The vendor (Yamaha Steinberg) driver on Windows sends this request at startup; the generic driver does not. Add the 01V96i to snd_usb_audioformat_attributes_quirk() to force the attribute on, so the stream is initialised the same way.
Confirmed against a usbmon capture of the Windows vendor driver: SET_CUR CS_SAMPLING_FREQ_CONTROL to endpoints 0x07 and 0x86 is the only non-standard control transfer it issues that completes successfully.
Verified on a mainline 7.2.9 kernel with a loopback test: playing a 440 Hz tone on USB channels 1/2 and recording USB channels 9/10 returns the tone unchanged at 44100, 48000, 88200 and 96000 Hz.
---
Changes in v2:
- Describe the change and its verification.
sound/usb/quirks.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+)
sound/usb/quirks.c +15 -0
@@ -2332,6 +2332,21 @@ void snd_usb_audioformat_attributes_quirk(struct snd_usb_audio *chip, int stream) {switch (chip->usb_id) { +case USB_ID (0x0499 ,0x5500 ):/* Yamaha 01V96i */ +/* +* The 01V96i declares its audio streaming interfaces as +* vendor-specific (class 0xff) and provides no class-specific +* endpoint descriptor. parse_uac_endpoint_attributes() therefore +* returns no attributes, and the driver never issues the SET_CUR +* sampling-frequency request the hardware needs to engage its USB +* stream: playback and capture PCMs report RUNNING, but the desk +* passes no audio. +* +* Force the attribute on so the stream is initialised the same way +* the Windows driver does it. +*/ + fp->attributes |=UAC_EP_CS_ATTR_SAMPLE_RATE ; +break ;case USB_ID (0x0a92 ,0x0053 ):/* AudioTrak Optoplay */ /* Optoplay sets the sample rate attribute although * it seems not supporting it in fact.
Signature · 1 line
2.53.0
Takashi Iwai
AppliedQuoted 19 lines · Justin Bacle
The Yamaha 01V96i exposes its audio streaming interfaces as vendor-specific USB class
0xffand ships no class-specific endpoint descriptor.parse_uac_endpoint_attributes()therefore returns no attributes for the device, and withoutUAC_EP_CS_ATTR_SAMPLE_RATEthe driver never issues theSET_CURsampling-frequency request the hardware needs to start its USB audio stream. The playback and capture PCMs are reported as RUNNING and their pointers advance, but the mixer passes no audio in either direction.The vendor (Yamaha Steinberg) driver on Windows sends this request at startup; the generic driver does not. Add the 01V96i to
snd_usb_audioformat_attributes_quirk()to force the attribute on, so the stream is initialised the same way.Confirmed against a usbmon capture of the Windows vendor driver:
SET_CURCS_SAMPLING_FREQ_CONTROLto endpoints0x07and0x86is the only non-standard control transfer it issues that completes successfully.
Quoted 6 lines
Verified on a mainline 7.2.9 kernel with a loopback test: playing a 440 Hz tone on USB channels 1/2 and recording USB channels 9/10 returns the tone unchanged at 44100, 48000, 88200 and 96000 Hz.
Tested-by Justin Bacle <[email protected]>Signed-off-by Justin Bacle <[email protected]>
Applied to for-next branch now. Thanks.
Takashi