Skip to contentSkip to conversation

package/libabseil-cpp: require wchar

PATCH Superseded Michael Nosthoff via buildroot 1 participant 3 messages Oct 5

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/libabseil-cpp: require wchar

absl::StrFormat() unconditionally includes <cwchar>. So a toolchain with wchar support is required.

Fixes:
https://autobuild.buildroot.org/results/948/948463b01ce52456179b06ae17d4ace9a823f92b//

---
 package/libabseil-cpp/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/libabseil-cpp/Config.in +1 -0
index feb4963042..739e6d279e 100644
@@ -13,6 +13,7 @@ config BR2_PACKAGE_LIBABSEIL_CPP_ARCH_SUPPORTS
 	default y if BR2_sh
 	default y if BR2_sparc || BR2_sparc64
 	default y if BR2_x86_64
+	depends on BR2_USE_WCHAR
 	depends on BR2_TOOLCHAIN_HAS_UCONTEXT
 	# absl/base/internal/direct_mmap.h only implements DirectMmap()
 	# with mmap2 for the o32 ABI on MIPS, and its 64-bit fallback
Signature · 6 lines
2.43.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

Hi Michael,

Quoted 16 lines · Michael Nosthoff via buildroot

absl::StrFormat() unconditionally includes <cwchar>. So a toolchain with wchar support is required.

Fixes:
https://autobuild.buildroot.org/results/948/948463b01ce52456179b06ae17d4ace9a823f92b//

---
 package/libabseil-cpp/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/libabseil-cpp/Config.in +0 -0
index feb4963042..739e6d279e 100644

package/libabseil-cpp/Config.in config BR2_PACKAGE_LIBABSEIL_CPP_ARCH_SUPPORTS · line 16

Quoted 4 lines
package/libabseil-cpp/Config.in +1 -0
@@ -13,6 +13,7 @@ config BR2_PACKAGE_LIBABSEIL_CPP_ARCH_SUPPORTS
 	default y if BR2_sh
 	default y if BR2_sparc || BR2_sparc64
 	default y if BR2_x86_64
+	depends on BR2_USE_WCHAR

New dependencies must propagate to all reverse dependencies, recursively.

Also, dependencies comment below needs update.

baruch

Quoted 3 lines
package/libabseil-cpp/Config.in +0 -0
 	depends on BR2_TOOLCHAIN_HAS_UCONTEXT
 	# absl/base/internal/direct_mmap.h only implements DirectMmap()
 	# with mmap2 for the o32 ABI on MIPS, and its 64-bit fallback
Signature · 7 lines
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - [email protected] - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw

Hi Baruch,

Quoted 14 lines · Baruch Siach

Hi Michael,

Quoted 11 lines · Michael Nosthoff via buildroot

absl::StrFormat() unconditionally includes <cwchar>. So a toolchain with wchar support is required.

Fixes:
https://autobuild.buildroot.org/results/948/948463b01ce52456179b06ae17d4ace9a823f92b//

---
 package/libabseil-cpp/Config.in | 1 +
 1 file changed, 1 insertion(+)
Quoted 12 lines

package/libabseil-cpp/Config.in config BR2_PACKAGE_LIBABSEIL_CPP_ARCH_SUPPORTS · line 16

Quoted 9 lines
package/libabseil-cpp/Config.in +1 -0
index feb4963042..739e6d279e 100644
@@ -13,6 +13,7 @@ config BR2_PACKAGE_LIBABSEIL_CPP_ARCH_SUPPORTS
 	default y if BR2_sh
 	default y if BR2_sparc || BR2_sparc64
 	default y if BR2_x86_64
+	depends on BR2_USE_WCHAR

New dependencies must propagate to all reverse dependencies, recursively.

The added depends is on the ARCH_SUPPORTS which should already be propagated. Maybe that's not the right place?

Quoted 3 lines

Also, dependencies comment below needs update.

thats's right.

Michael

Quoted 10 lines

baruch

Quoted 3 lines
package/libabseil-cpp/Config.in +0 -0
 	depends on BR2_TOOLCHAIN_HAS_UCONTEXT
 	# absl/base/internal/direct_mmap.h only implements DirectMmap()
 	# with mmap2 for the o32 ABI on MIPS, and its 64-bit fallback
Signature · 3 lines
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - [email protected] - tel: +972.52.368.4656, http://www.tkos.co.il -

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot