Skip to contentSkip to conversation

scripts-checkstackpl-support-llvm-objdump-disassembly-for-x86.patch removed from -mm tree

merged mm-nonmm-stable Andrew Morton 1 participant 1 message Oct 7

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled
Subject: scripts/checkstack.pl: support llvm-objdump disassembly for x86
has been removed from the -mm tree. Its filename was
scripts-checkstackpl-support-llvm-objdump-disassembly-for-x86.patch

This patch was dropped because it was merged into the mm-nonmm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: Nick Desaulniers <[email protected]>
Subject: scripts/checkstack.pl: support llvm-objdump disassembly for x86
Date: Wed, 02 Sep 2026 14:01:53 -0700

When running make LLVM=1 checkstack, OBJDUMP is set to llvm-objdump. llvm-objdump outputs disassembly with instruction size suffixes (such as subq/addq/subl/addl), tabs/whitespace differences, spaces after commas, and trailing comments (e.g. # imm = 0x...).

Because scripts/checkstack.pl used rigid regular expressions specifically tuned to GNU objdump format (e.g. requiring exactly four spaces, no suffix, and no space after comma), checkstack.pl failed to match any stack adjustment instructions and yielded no output when using llvm-objdump on x86.

Update the regular expressions for x86 to match optional suffixes, variable whitespace, and trailing comments.

---

 scripts/checkstack.pl |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
scripts/checkstack.pl renamed from scripts/checkstack.pl~scripts-checkstackpl-support-llvm-objdump-disassembly-for-x86 +4 -2
@@ -66,8 +66,10 @@ my (@stack, $re, $dre, $sub, $x, $xs, $f
 		#c0105234:       81 ec ac 05 00 00       sub    $0x5ac,%esp
 		# or
 		#    2f60:    48 81 ec e8 05 00 00       sub    $0x5e8,%rsp
-		$re = qr/^.*[as][du][db]    \$(0x$x{1,8}),\%(e|r)sp$/o;
-		$dre = qr/^.*[as][du][db]    (%.*),\%(e|r)sp$/o;
+		# or
+		#       0: 48 81 ec e8 05 00 00          subq   $0x5e8, %rsp
+		$re = qr/^.*[as][du][db][ql]?\s+\$(0x$x{1,8}),\s*\%(e|r)sp/o;
+		$dre = qr/^.*[as][du][db][ql]?\s+(%.*),\s*\%(e|r)sp/o;
 	} elsif ($arch eq 'm68k') {
 		#    2b6c:       4e56 fb70       linkw %fp,#-1168
 		#  1df770:       defc ffe4       addaw #-28,%sp

_

Patches currently in -mm which might be from [email protected] are