Skip to contentSkip to conversation

staging: rtl8723bs: use u8 instead of unsigned char in NDIS typedefs

PATCH In review Muhammad Mahdi Amirpour 2 participants 2 messages Oct 7 – Oct 13 Staging

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 staging: rtl8723bs: use u8 instead of unsigned char in NDIS typedefs

Replace the plain C type 'unsigned char' with the kernel's fixed-width type 'u8' in the NDIS_802_11_RATES and NDIS_802_11_RATES_EX typedefs.

The kernel coding style prefers fixed-width types over plain C types. This addresses one of the outstanding TODO items in the rtl8723bs
driver: "convert any remaining unusual variable types".

No functional change.

---
 drivers/staging/rtl8723bs/include/wlan_bssdef.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8723bs/include/wlan_bssdef.h +2 -2
index f4c1456f1..df541e956 100644
@@ -15,8 +15,8 @@
 #define NDIS_802_11_LENGTH_RATES        8
 #define NDIS_802_11_LENGTH_RATES_EX     16
 
-typedef unsigned char   NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];        /*  Set of 8 data rates */
-typedef unsigned char   NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];  /*  Set of 16 data rates */
+typedef u8 NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];        /*  Set of 8 data rates */
+typedef u8 NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];  /*  Set of 16 data rates */
 
 struct ndis_802_11_ssid {
 	u32 ssid_length;
Signature · 1 line
2.55.0
maintainer
#1 lore raw
Quoted 32 lines · Muhammad Mahdi Amirpour

Replace the plain C type 'unsigned char' with the kernel's fixed-width type 'u8' in the NDIS_802_11_RATES and NDIS_802_11_RATES_EX typedefs.

The kernel coding style prefers fixed-width types over plain C types. This addresses one of the outstanding TODO items in the rtl8723bs
driver: "convert any remaining unusual variable types".

No functional change.

---
 drivers/staging/rtl8723bs/include/wlan_bssdef.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8723bs/include/wlan_bssdef.h +2 -2
index f4c1456f1..df541e956 100644
@@ -15,8 +15,8 @@
 #define NDIS_802_11_LENGTH_RATES        8
 #define NDIS_802_11_LENGTH_RATES_EX     16
 
-typedef unsigned char   NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];        /*  Set of 8 data rates */
-typedef unsigned char   NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];  /*  Set of 16 data rates */
+typedef u8 NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];        /*  Set of 8 data rates */
+typedef u8 NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];  /*  Set of 16 data rates */
 
 struct ndis_802_11_ssid {
 	u32 ssid_length;
Signature · 1 line
2.55.0

Does not apply to the the staging-next branch at all :(