mm-page_counter-avoid-integer-overflow-in-effective_protection.patch removed from -mm tree
The quilt patch titled
Subject: mm/page_counter: avoid integer overflow in effective_protection()
has been removed from the -mm tree. Its filename was
mm-page_counter-avoid-integer-overflow-in-effective_protection.patch
This patch was dropped because it was merged into the mm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
------------------------------------------------------
From: Ridong Chen <[email protected]>
Subject: mm/page_counter: avoid integer overflow in effective_protection()
Date: Mon, 7 Sep 2026 10:54:44 +0800
Patch series "mm/mglru: fix ineffective memory protection for non-kswapd reclaim", v4.
For MGLRU, memory.min/low is not honored during non-kswapd global reclaim (global direct reclaim and root-level memory.reclaim), because these paths shrink memcgs using stale protection (emin/elow).
Patch 2 is the actual fix. Patch 1 is a prerequisite: an integer overflow in effective_protection(), spotted by the sashiko review tool, which patch 2's new caller would also be exposed to.
This patch (of 2):
effective_protection() scales a parent's protection by a ratio of page counts, e.g. for recursive protection:
(parent_effective - siblings_protected) * (usage - protected)
/ (parent_usage - siblings_protected)
The multiply is done at unsigned long width before dividing. On systems with >= 16TB RAM the product can exceed 2^64 and wrap, giving a bogus protection value and silently breaking memory.min/low enforcement.
Use mul_u64_u64_div_u64() to multiply in a 128-bit intermediate. Because usage and parent_usage are not read atomically (a child is charged before its parent), usage - protected can briefly exceed the divisor, making the quotient overflow 64 bits and trap (#DE on x86). Cap it so the ratio stays <= 1.
Reported by the sashiko review tool [1].
---
mm/page_counter.c | 21 +++++++++++++++------ 1 file changed, 15 insertions(+), 6 deletions(-)
mm/page_counter.c renamed from mm/page_counter.c~mm-page_counter-avoid-integer-overflow-in-effective_protection +15 -6
@@ -8,6 +8,7 @@#include <linux/page_counter.h> #include <linux/atomic.h> #include <linux/kernel.h> +#include <linux/math64.h> #include <linux/string.h> #include <linux/sched.h> #include <linux/bug.h>
@@ -376,7 +377,8 @@ static unsigned long effective_protectio* otherwise get a smaller chunk than what they claimed. */ if (siblings_protected > parent_effective) -return protected * parent_effective / siblings_protected; +return mul_u64_u64_div_u64 (protected, parent_effective, + siblings_protected);/* * Ok, utilized protection of all children is within what the
@@ -417,13 +419,20 @@ static unsigned long effective_protectioif (parent_effective > siblings_protected && parent_usage > siblings_protected && usage > protected) { -unsigned long unclaimed; +unsigned long parent_unclaimed, parent_unprotected, unprotected; - unclaimed = parent_effective - siblings_protected; - unclaimed *= usage - protected; - unclaimed /= parent_usage - siblings_protected; + parent_unclaimed = parent_effective - siblings_protected; + parent_unprotected = parent_usage - siblings_protected; - ep += unclaimed; +/* +* The usages aren't read atomically, so a child can transiently +* appear to use more than its parent, making the ratio exceed 1 +* and the quotient overflow 64 bits (#DE on x86). Cap it. +*/ + unprotected =min (usage - protected, parent_unprotected); + + ep +=mul_u64_u64_div_u64 (parent_unclaimed, unprotected, + parent_unprotected); }return ep;
_
Patches currently in -mm which might be from [email protected] are
mm-vmscan-put-rotation-missed-folios-at-the-lru-tail.patch