Skip to contentSkip to conversation

add V4L2_CID_USER_ALVIUM_BASE and request space for up to 128 controls

PATCH In review Martin Hecht 2 participants 2 messages Oct 9 – Oct 11 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 add V4L2_CID_USER_ALVIUM_BASE and request space for up to 128 controls

That patch requests a continoous block of controls to enable various features of the Alvium camera family. There are many features like triggers, ROI for auto functions like AWB, auto gain and so on.

---
 include/uapi/linux/v4l2-controls.h | 6 ++++++
 1 file changed, 6 insertions(+)
include/uapi/linux/v4l2-controls.h +6 -0
index d17e41d51d2e..5ed91c053617 100644
@@ -255,6 +255,12 @@ enum v4l2_colorfx {
  */
 #define V4L2_CID_USER_IT6625_BASE		(V4L2_CID_USER_BASE + 0x1250)
 
+/*
+ * The base for Alvium CSI2 driver controls.
+ * We reserve 128 controls for this driver.
+ */
+#define V4L2_CID_USER_ALVIUM_BASE		(V4L2_CID_USER_BASE + 0x1260)
+
 /* MPEG-class control IDs */
 /* The MPEG controls are applicable to all codec controls
  * and the 'MPEG' part of the define is historical */
Signature · 1 line
2.43.0
#1 lore raw

Hi Martin,

Quoted 5 lines · Martin Hecht

That patch requests a continoous block of controls to enable various features of the Alvium camera family. There are many features like triggers, ROI for auto functions like AWB, auto gain and so on.

Thanks for the patch.

Could you also include some patches for actual control definitions in the same patchset?

Quoted 21 lines
---
 include/uapi/linux/v4l2-controls.h | 6 ++++++
 1 file changed, 6 insertions(+)
include/uapi/linux/v4l2-controls.h +6 -0
index d17e41d51d2e..5ed91c053617 100644
@@ -255,6 +255,12 @@ enum v4l2_colorfx {
  */
 #define V4L2_CID_USER_IT6625_BASE		(V4L2_CID_USER_BASE + 0x1250)
 
+/*
+ * The base for Alvium CSI2 driver controls.
+ * We reserve 128 controls for this driver.
+ */
+#define V4L2_CID_USER_ALVIUM_BASE		(V4L2_CID_USER_BASE + 0x1260)
+
 /* MPEG-class control IDs */
 /* The MPEG controls are applicable to all codec controls
  * and the 'MPEG' part of the define is historical */
Signature · 3 lines
Kind regards,

Sakari Ailus