Skip to contentSkip to conversation

Bluetooth: MGMT: Allow connection rate request as peripheral

PATCH Applied Luiz Augusto von Dentz 3 participants 3 messages Oct 12 – Oct 13

Subsystems (2)
lore
Share & tools
lore

Luiz Augusto von Dentz

author maintainer
#0 lore raw

PATCH 1/1 Bluetooth: MGMT: Allow connection rate request as peripheral

From: Luiz Augusto von Dentz <[email protected]>

Load Connection Subrate only issues the LE Connection Rate Request when connected as central, but either role can initiate the Connection Rate Update procedure, e.g. a HID device, which is the peripheral, does it once the HID host requests a HID SCI mode with the HID Control Point.

Issue it regardless of the role.

Fixes 19129d7037be ("Bluetooth: Add MGMT Load Connection Subrate command")
Assisted-by OpenCode:claude-opus-5.5
---
 net/bluetooth/mgmt.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
net/bluetooth/mgmt.c +4 -3
index 9f65863e7457..3b9c82bd2f02 100644
@@ -8347,8 +8347,10 @@ static int load_conn_subrate(struct sock *sk, struct hci_dev *hdev, void *data,
 		hci_param->cont_num = cont_num;
 		hci_param->rate_supv_timeout = supv_timeout;
 
-		/* If the device is connected as central check if the
-		 * connection rate parameters need to be updated.
+		/* If the device is connected check if the connection rate
+		 * parameters need to be updated, either role can initiate the
+		 * Connection Rate Update procedure, e.g. a HID device acting
+		 * as peripheral once the HID host requests a HID SCI mode.
 		 */
 		if (!i && param_count == 1) {
 			struct hci_conn *conn;
@@ -8357,7 +8359,6 @@ static int load_conn_subrate(struct sock *sk, struct hci_dev *hdev, void *data,
 						       &hci_param->addr,
 						       addr_type);
 			if (conn && conn->state == BT_CONNECTED &&
-			    conn->role == HCI_ROLE_MASTER &&
 			    (conn->le_rate_interval < min ||
 			     conn->le_rate_interval > max ||
 			     conn->le_subrate < subrate_min ||
Signature · 1 line
2.56.0
#1 lore raw

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/series/1184009/

---Test result---

Test Summary:

CheckPatch                    PASS      0.68 seconds
VerifyFixes                   PASS      0.07 seconds
VerifySignedoff               PASS      0.35 seconds
GitLint                       PASS      0.22 seconds
SubjectPrefix                 PASS      0.08 seconds
BuildKernel                   PASS      30.97 seconds
CheckAllWarning               PASS      35.09 seconds
CheckSparse                   PASS      36.93 seconds
BuildKernel32                 PASS      30.21 seconds
CheckKernelLLVM               PASS      34.55 seconds
TestRunnerSetup               PASS      816.63 seconds
TestRunner_mgmt-tester        PASS      61.31 seconds
TestRunner_mesh-tester        PASS      5.45 seconds
IncrementalBuild              PASS      29.04 seconds

https://github.com/bluez/bluetooth-next/pull/905

---
Regards,
Linux Bluetooth

#2 lore raw
In reply to Luiz Augusto von Dentz
This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <[email protected]>:

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <[email protected]>:

Quoted 8 lines · On Mon, 12 Oct 2026 11:28:03 -0400 you wrote:

From: Luiz Augusto von Dentz <[email protected]>

Load Connection Subrate only issues the LE Connection Rate Request when connected as central, but either role can initiate the Connection Rate Update procedure, e.g. a HID device, which is the peripheral, does it once the HID host requests a HID SCI mode with the HID Control Point.

[...]

Here is the summary with links:
- [v1] Bluetooth: MGMT: Allow connection rate request as peripheral

    https://git.kernel.org/bluetooth/bluetooth-next/c/fe921b758083

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html