Skip to contentSkip to conversation

ACPI: sysfs: Expose BDAT data region

PATCH Superseded Jamie Nguyen 2 participants 8 messages Oct 12 – Nov 9 ACPI

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

v2 cover ACPI: sysfs: Expose BDAT data region

The BIOS Data ACPI Table (BDAT) points to a firmware data structure that carries memory training results and other boot-time data. Patch 2 exposes that data as /sys/firmware/acpi/tables/data/BDAT, like the existing BERT and CCEL data files.

Patch 1 fixes a leak in the existing data file code, where data_attr is not freed if sysfs_create_bin_file() fails. It moves the file creation and the cleanup into acpi_table_data_init(), and patch 2 builds on that.

Changes in v2:
- New patch 1, fixing the data_attr leak for BERT and CCEL as well.
- Patch 2: the BDAT callback only checks the table and sets the address and size of the data, and returns -ENOMEM if mapping the header fails.

v1: https://lore.kernel.org/r/[email protected]

Tested on an arm64 server (64K pages):

- The file matches a /dev/mem dump of the data region taken in the same boot, byte for byte, and decodes with valid CRCs.
- With lockdown=integrity, /dev/mem is refused and the file still reads.
- Malformed BDAT tables loaded via initrd table upgrade (test-only change adding BDAT to table_sigs[]) are rejected without creating a file: no "BDATHEAD" signature, size below the header, non-memory address space, zero address, and a table shorter than struct acpi_table_bdat.
- With a test-only change that makes sysfs_create_bin_file() fail with -EEXIST for one BDAT table, kmemleak reports its data_attr as leaked without patch 1, and the data_attr is freed with patch 1 applied.

Jamie Nguyen (2):
ACPI: sysfs: Fix data_attr leak when creating a data file fails
ACPI: sysfs: Expose BDAT data region

 Documentation/ABI/testing/sysfs-firmware-acpi | 12 ++++
 drivers/acpi/sysfs.c                          | 69 ++++++++++++++++---
 2 files changed, 71 insertions(+), 10 deletions(-)

base-commit: af32da41b0327b9c6a37856ba82b6760d6c8d10e

Signature · 1 line
2.43.0
#1 lore raw

PATCH v2 1/2 ACPI: sysfs: Fix data_attr leak when creating a data file fails

acpi_table_data_init() allocates the data_attr for a table's data file and passes it to the table's init callback. The BERT and CCEL callbacks free data_attr when the table is invalid, but return the result of sysfs_create_bin_file() directly, so data_attr is leaked if creating the file fails.

Create the file and free data_attr on failure in acpi_table_data_init() instead, so that the callbacks only check the table and set the address and size of the data.

Fixes 7dae6326ed76 ("ACPI / sysfs: Extend ACPI sysfs to provide access to boot error region")
Assisted-by LLM
---
 drivers/acpi/sysfs.c | 24 ++++++++++++++----------
 1 file changed, 14 insertions(+), 10 deletions(-)
drivers/acpi/sysfs.c +14 -10
index dd4a99f09efea65..ae3b3ee0552d198 100644
@@ -448,14 +448,13 @@ static int acpi_bert_data_init(void *th, struct acpi_data_attr *data_attr)
 	struct acpi_table_bert *bert = th;
 
 	if (bert->header.length < sizeof(struct acpi_table_bert) ||
-	    bert->region_length < sizeof(struct acpi_bert_region)) {
-		kfree(data_attr);
+	    bert->region_length < sizeof(struct acpi_bert_region))
 		return -EINVAL;
-	}
+
 	data_attr->addr = bert->address;
 	data_attr->attr.size = bert->region_length;
 
-	return sysfs_create_bin_file(tables_data_kobj, &data_attr->attr);
+	return 0;
 }
 
 static int acpi_ccel_data_init(void *th, struct acpi_data_attr *data_attr)
@@ -463,14 +462,13 @@ static int acpi_ccel_data_init(void *th, struct acpi_data_attr *data_attr)
 	struct acpi_table_ccel *ccel = th;
 
 	if (ccel->header.length < sizeof(struct acpi_table_ccel) ||
-	    !ccel->log_area_start_address || !ccel->log_area_minimum_length) {
-		kfree(data_attr);
+	    !ccel->log_area_start_address || !ccel->log_area_minimum_length)
 		return -EINVAL;
-	}
+
 	data_attr->addr = ccel->log_area_start_address;
 	data_attr->attr.size = ccel->log_area_minimum_length;
 
-	return sysfs_create_bin_file(tables_data_kobj, &data_attr->attr);
+	return 0;
 }
 
 static struct acpi_data_obj {
@@ -486,7 +484,7 @@ static struct acpi_data_obj {
 static int acpi_table_data_init(struct acpi_table_header *th, struct acpi_table_attr *table_attr)
 {
 	struct acpi_data_attr *data_attr;
-	int i;
+	int i, ret;
 
 	for (i = 0; i < NUM_ACPI_DATA_OBJS; i++) {
 		if (ACPI_COMPARE_NAMESEG(th->signature, acpi_data_objs[i].name)) {
@@ -498,7 +496,13 @@ static int acpi_table_data_init(struct acpi_table_header *th, struct acpi_table_
 			data_attr->attr.attr.mode = 0400;
 			strscpy(data_attr->filename, table_attr->filename);
 			data_attr->attr.attr.name = data_attr->filename;
-			return acpi_data_objs[i].fn(th, data_attr);
+			ret = acpi_data_objs[i].fn(th, data_attr);
+			if (!ret)
+				ret = sysfs_create_bin_file(tables_data_kobj,
+							    &data_attr->attr);
+			if (ret)
+				kfree(data_attr);
+			return ret;
 		}
 	}
 	return 0;
Signature · 1 line
2.43.0
#2 lore raw

PATCH v2 2/2 ACPI: sysfs: Expose BDAT data region

In reply to Jamie Nguyen

The BIOS Data ACPI Table (BDAT) points to a firmware data structure that carries memory training results and other boot-time data. The table is only a pointer: /sys/firmware/acpi/tables/BDAT holds the ACPI header and a Generic Address Structure, and the data itself lives in reserved memory.

Expose the data as /sys/firmware/acpi/tables/data/BDAT, as is already done for BERT and CCEL. Unlike those tables, BDAT carries no length, so check the "BDATHEAD" signature at the start of the data structure and take the size from its BiosDataStructSize field. Reject sizes smaller than that header, and document the new file in Documentation/ABI.

The BDAT specification is published by the UEFI Forum [1].

---
 Documentation/ABI/testing/sysfs-firmware-acpi | 12 +++++
 drivers/acpi/sysfs.c                          | 45 +++++++++++++++++++
 2 files changed, 57 insertions(+)
Documentation/ABI/testing/sysfs-firmware-acpi +12 -0
index fa33dda331f2440..5fb50a72d468f5c 100644
@@ -275,3 +275,15 @@ Description:
 
 		remote_region_id: ID associated with access by agents
 		non-local to this range of addresses.
+
+What:		/sys/firmware/acpi/tables/data/BDAT
+Date:		October 2026
+Contact:	Jamie Nguyen <[email protected]>
+Description:
+		The BIOS data structure referenced by the ACPI BDAT (BIOS Data
+		ACPI Table). It starts with a "BDATHEAD" header and holds data
+		published by firmware, such as memory training results. The
+		file size is the structure size given in that header.
+
+		The format is defined by the BDAT Interface Specification,
+		published by the UEFI Forum. The file is readable by root only.
drivers/acpi/sysfs.c +45 -0

57 lines not on this page · raw message

Signature · 1 line
2.43.0
#3 lore raw

The Sashiko review of this patch [1] notes that acpi_data_show() maps the whole data region on every read(), and that the unmaps are deferred by RCU, so repeated reads could pile up mappings and exhaust vmalloc space.

That code isn't changed by this series. acpi_data_show() has mapped the whole region on every read since BERT support was added in 7dae6326ed76 ("ACPI / sysfs: Extend ACPI sysfs to provide access to boot error region"), and BERT and CCEL use the same path.

I measured it with v2 on an arm64 server, with 4K and 64K pages and the 90754-byte BDAT region:

- Looping full-file reads, with 1 to 64 readers, kept at most about 4500 deferred mappings (426 MiB) in flight. The count stayed flat and went back to baseline within 2 s of stopping.
- The worst case, tight loops of 1-byte reads, peaked at about 34k mappings and 4.6 GiB of address space, and also drained within 2 s.

At those rates, exhausting the 126 TiB of vmalloc space would need the deferred unmaps to stop completing for more than half an hour.

If it's worth tightening anyway, acpi_data_show() could map only the range being read, which caps each mapping at two pages for all three tables. I can send that as a separate patch.

[1] https://sashiko.dev/#/patchset/20261012230632.3574987-1-jamien%40nvidia.com

Jamie

#4 lore raw
Quoted 20 lines · Jamie Nguyen

The Sashiko review of this patch [1] notes that acpi_data_show() maps the whole data region on every read(), and that the unmaps are deferred by RCU, so repeated reads could pile up mappings and exhaust vmalloc space.

That code isn't changed by this series. acpi_data_show() has mapped the whole region on every read since BERT support was added in 7dae6326ed76 ("ACPI / sysfs: Extend ACPI sysfs to provide access to boot error region"), and BERT and CCEL use the same path.

I measured it with v2 on an arm64 server, with 4K and 64K pages and the 90754-byte BDAT region:

- Looping full-file reads, with 1 to 64 readers, kept at most about 4500 deferred mappings (426 MiB) in flight. The count stayed flat and went back to baseline within 2 s of stopping.
- The worst case, tight loops of 1-byte reads, peaked at about 34k mappings and 4.6 GiB of address space, and also drained within 2 s.

Quoted 6 lines

At those rates, exhausting the 126 TiB of vmalloc space would need the deferred unmaps to stop completing for more than half an hour.

If it's worth tightening anyway, acpi_data_show() could map only the range being read, which caps each mapping at two pages for all three tables. I can send that as a separate patch.

Yes, please!

Quoted 1 line

[1] https://sashiko.dev/#/patchset/20261012230632.3574987-1-jamien%40nvidia.com

#5 lore raw
Quoted 5 lines · Rafael J. Wysocki
Quoted 3 lines

If it's worth tightening anyway, acpi_data_show() could map only the range being read, which caps each mapping at two pages for all three tables. I can send that as a separate patch.

Yes, please!

Posted here:
https://lore.kernel.org/r/[email protected]

Jamie

#7 lore raw
Quoted 10 lines · Jamie Nguyen

Hello,

Gentle ping on this series. It still applies cleanly to v7.4-rc1, on top of the two Sashiko finding fixes [1][2]. Please let me know if anything else is needed, such as a resend dropping the "Assisted-by:" tag.

[1]: https://lore.kernel.org/r/[email protected]
[2]: https://lore.kernel.org/r/[email protected]

It would be good to resent this to allow Sashiko to review it again because the fixes above are part of the mainline now.