posix-cpu-timers: Fix pid refcount leak in do_cpu_nanosleep() signal path
Subsystems (2)
PATCH 1/1 posix-cpu-timers: Fix pid refcount leak in do_cpu_nanosleep() signal path
do_cpu_nanosleep() sleeps on a temporary k_itimer whose reference on the target's struct pid is taken by posix_cpu_timer_create() and dropped by posix_cpu_timer_del(). When a signal ends the sleep, the timer is disarmed with posix_cpu_timer_set(), but posix_cpu_timer_del() is only called for a result of 0 or TIMER_RETRY. If the target thread or process has exited in the meantime, timer_lock_sighand() finds no task, posix_cpu_timer_set() returns -ESRCH and the pid reference is leaked.
An unprivileged user can trigger this: sleep on the CPU clock of a thread, let that thread exit, then signal the sleeper. Each round leaks one struct pid. Repeating it exhausts unreclaimable slab memory within minutes:
Out of memory: Killed process 150 (poc) total-vm:789292kB, anon-rss:484kB
Kernel panic - not syncing: System is deadlocked on memory
Fix this by also calling posix_cpu_timer_del() on -ESRCH. With the target gone, the deletion is safe. It finds no task either and only drops the pid reference.
--- kernel/time/posix-cpu-timers.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
kernel/time/posix-cpu-timers.c +2 -2
@@ -1600,8 +1600,8 @@ static int do_cpu_nanosleep(const clockid_t which_clock, int flags,*/ expires =cpu_timer_getexpires (&timer.it.cpu); error =posix_cpu_timer_set (&timer,0 , &zero_it, &it); -if (!error) { -/* Timer is now unarmed, deletion can not fail. */ +if (error !=TIMER_RETRY ) { +/* Unarmed or target gone (-ESRCH), deletion can not fail. */ posix_cpu_timer_del (&timer); }else {while (error ==TIMER_RETRY ) {
Signature · 1 line
2.55.0
The following commit has been merged into the timers/urgent branch of tip:
The following commit has been merged into the timers/urgent branch of tip:
Commit-ID: 8ccd731b63a0183ca2b0e18f3ca15864b3f37eda Gitweb: https://git.kernel.org/tip/8ccd731b63a0183ca2b0e18f3ca15864b3f37eda Author: Cen Zhang (Microsoft) <[email protected]> AuthorDate: Mon, 12 Oct 2026 19:51:49 -04:00 Committer: Thomas Gleixner <[email protected]> CommitterDate: Fri, 23 Oct 2026 21:35:02 +02:00
posix-cpu-timers: Fix pid refcount leak in do_cpu_nanosleep() signal path
do_cpu_nanosleep() sleeps on a temporary k_itimer whose reference on the target's struct pid is taken by posix_cpu_timer_create() and dropped by posix_cpu_timer_del(). When a signal ends the sleep, the timer is disarmed with posix_cpu_timer_set(), but posix_cpu_timer_del() is only called for a result of 0 or TIMER_RETRY. If the target thread or process has exited in the meantime, timer_lock_sighand() finds no task, posix_cpu_timer_set() returns -ESRCH and the pid reference is leaked.
An unprivileged user can trigger this: sleep on the CPU clock of a thread, let that thread exit, then signal the sleeper. Each round leaks one struct pid. Repeating it exhausts unreclaimable slab memory within minutes:
Out of memory: Killed process 150 (poc) total-vm:789292kB, anon-rss:484kB
Kernel panic - not syncing: System is deadlocked on memory
Fix this by also calling posix_cpu_timer_del() on -ESRCH. With the target gone, the deletion is safe. It finds no task either and only drops the pid reference.
--- kernel/time/posix-cpu-timers.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
kernel/time/posix-cpu-timers.c +2 -2
@@ -1600,8 +1600,8 @@ static int do_cpu_nanosleep(const clockid_t which_clock, int flags,*/ expires =cpu_timer_getexpires (&timer.it.cpu); error =posix_cpu_timer_set (&timer,0 , &zero_it, &it); -if (!error) { -/* Timer is now unarmed, deletion can not fail. */ +if (error !=TIMER_RETRY ) { +/* Unarmed or target gone (-ESRCH), deletion can not fail. */ posix_cpu_timer_del (&timer); }else {while (error ==TIMER_RETRY ) {