ALSA: hda/realtek: Fix speaker and mic mute LEDs on IdeaPad Pro 5 14IAH10
PATCH v2 1/1 ALSA: hda/realtek: Fix speaker and mic mute LEDs on IdeaPad Pro 5 14IAH10
The speaker and microphone mute LEDs on the IdeaPad Pro 5 14IAH10 do not follow the ALSA mute state. This machine has an ALC287 codec with SSID 17aa:3914, but shares PCI SSID 17aa:3843 with the Yoga Book 9i and currently gets its fixup.
Add a codec SSID quirk that runs the IdeaPad ACPI LED fixup. Chain the existing bass speaker amp fixup so the audio setup is retained.
Tested on the IdeaPad Pro 5 14IAH10: muting and unmuting the headphone sink toggled the physical speaker mute LED. Muting both microphone controls changed the ALSA mic LED state from 0 to 1.
---
Changes in v2:
- Add a comment about the conflicting PCI SSID.
- Rebase onto sound.git for-next.
sound/hda/codecs/realtek/alc269.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)
sound/hda/codecs/realtek/alc269.c +12 -0
@@ -4386,6 +4386,7 @@ enum {ALC295_FIXUP_HP_OMEN ,ALC285_FIXUP_HP_SPECTRE_X360 ,ALC287_FIXUP_IDEAPAD_BASS_SPK_AMP , +ALC287_FIXUP_IDEAPAD_BASS_SPK_AMP_LED ,ALC623_FIXUP_LENOVO_THINKSTATION_P340 ,ALC255_FIXUP_ACER_HEADPHONE_AND_MIC , ALC236_FIXUP_HP_LIMIT_INT_MIC_BOOST,
@@ -6611,6 +6612,12 @@ static const struct hda_fixup alc269_fixups[] = { .chained = true, .chain_id = ALC285_FIXUP_THINKPAD_HEADSET_JACK, }, + [ALC287_FIXUP_IDEAPAD_BASS_SPK_AMP_LED] = { + .type = HDA_FIXUP_FUNC, + .v.func = alc_fixup_ideapad_acpi, + .chained = true, + .chain_id = ALC287_FIXUP_IDEAPAD_BASS_SPK_AMP, + }, [ALC287_FIXUP_LENOVO_YOGA_PRO7] = { .type = HDA_FIXUP_FUNC, .v.func = alc_fixup_yoga_pro7_audio,
@@ -8427,6 +8434,11 @@ static const struct hda_quirk alc269_fixup_tbl[] = {SND_PCI_QUIRK (0x17aa ,0x3834 ,"Lenovo IdeaPad Slim 9i 14ITL5" ,ALC287_FIXUP_YOGA7_14ITL_SPEAKERS ),SND_PCI_QUIRK (0x17aa ,0x383d ,"Legion Y9000X 2019" ,ALC285_FIXUP_LEGION_Y9000X_SPEAKERS ),SND_PCI_QUIRK (0x17aa ,0x3842 ,"ThinkBook X G2 IAH" ,ALC287_FIXUP_MG_RTKC_CSAMP_CS35L41_I2C_4_THINKPAD ), +/* IdeaPad Pro 5 14IAH10 shares PCI SSID 17aa:3843 with Yoga Book 9i; +* use codec SSID to distinguish them +*/ +HDA_CODEC_QUIRK (0x17aa ,0x3914 ,"Lenovo IdeaPad Pro 5 14IAH10" , +ALC287_FIXUP_IDEAPAD_BASS_SPK_AMP_LED ),SND_PCI_QUIRK (0x17aa ,0x3843 ,"Lenovo Yoga 9i / Yoga Book 9i" ,ALC287_FIXUP_LENOVO_YOGA_BOOK_9I ),/* Yoga Pro 7 14IMH9 shares PCI SSID 17aa:3847 with Legion 7 16ACHG6; * use codec SSID to distinguish them
Signature · 1 line
2.56.0
Takashi Iwai
AppliedQuoted 6 lines · Aayush Kumar
The speaker and microphone mute LEDs on the IdeaPad Pro 5 14IAH10 do not follow the ALSA mute state. This machine has an ALC287 codec with SSID 17aa:3914, but shares PCI SSID 17aa:3843 with the Yoga Book 9i and currently gets its fixup.
Quoted 8 lines
Add a codec SSID quirk that runs the IdeaPad ACPI LED fixup. Chain the existing bass speaker amp fixup so the audio setup is retained.
Tested on the IdeaPad Pro 5 14IAH10: muting and unmuting the headphone sink toggled the physical speaker mute LED. Muting both microphone controls changed the ALSA mic LED state from 0 to 1.
Signed-off-by Aayush Kumar <[email protected]>
Applied to for-next branch now. Thanks.
Takashi