Skip to contentSkip to conversation

KVM: selftests: Provide empty installation rules on unsupported ARCHs

PATCH Applied Sasha Levin 2 participants 4 messages Oct 14 – Nov 13

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 KVM: selftests: Provide empty installation rules on unsupported ARCHs

Unsupported architectures provide all and clean, but installation and runlist generation fail with missing targets. Supply empty install, emit_tests and run_tests targets alongside the existing empty rules. This represents an unsupported suite without creating dummy artifacts.

Fixes 43fbd8cd389f ("KVM: selftests: Provide empty 'all' and 'clean' targets for unsupported ARCHs")
---
 tools/testing/selftests/kvm/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
tools/testing/selftests/kvm/Makefile +2 -2
index f2b223072b626..17475d3c0786c 100644
@@ -11,6 +11,6 @@ endif
 include Makefile.kvm
 else
 # Empty targets for unsupported architectures
-all:
-clean:
+all clean run_tests install emit_tests:
+.PHONY: all clean run_tests install emit_tests
 endif

base-commit: 4eb2586bd40db27d77cc5b724ca9386ed0c71d53

Signature · 1 line
2.53.0
#1 lore raw

Ping, this still applies on 7.4-rc1. On architectures the KVM selftests don't support, like 32-bit arm in KernelCI, installing the selftests still stops at the kvm suite with "No rule to make target 'install'".

Signature · 2 lines
Thanks,
Sasha
#2 lore raw
Quoted 4 lines · Sasha Levin

Ping, this still applies on 7.4-rc1. On architectures the KVM selftests don't support, like 32-bit arm in KernelCI, installing the selftests still stops at the kvm suite with "No rule to make target 'install'".

This is on my to-grab list, I'll make sure it gets into 7.4.

reviewer Applied
#3 lore raw
In reply to Sasha Levin
Quoted 4 lines · Sasha Levin

Unsupported architectures provide all and clean, but installation and runlist generation fail with missing targets. Supply empty install, emit_tests and run_tests targets alongside the existing empty rules. This represents an unsupported suite without creating dummy artifacts.

Applied to kvm-x86 fixes, thanks!

[1/1] KVM: selftests: Provide empty installation rules on unsupported ARCHs

      https://github.com/kvm-x86/linux/commit/7a2ff8e1f281

--
https://github.com/kvm-x86/linux/tree/next