staging: gdm724x: make DEVICE_STRING array const
PATCH 1/1 staging: gdm724x: make DEVICE_STRING array const
From: Palak Raval <[email protected]>
The DEVICE_STRING array contains pointers to string literals and is never modified.
Declare it as 'const char * const' to improve const correctness and prevent accidental modification. Also fix minor formatting issues reported by checkpatch.
No functional changes intended.
--- drivers/staging/gdm724x/gdm_tty.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/staging/gdm724x/gdm_tty.c +3 -2
@@ -31,7 +31,7 @@ static struct gdm *gdm_table[TTY_MAX_COUNT][GDM_TTY_MINOR];static DEFINE_MUTEX (gdm_table_lock);static const char *DRIVER_STRING [TTY_MAX_COUNT ] = {"GCTATC" ,"GCTDM" }; -static char *DEVICE_STRING [TTY_MAX_COUNT ] = {"GCT-ATC" ,"GCT-DM" }; +static const char *const DEVICE_STRING [TTY_MAX_COUNT ] = {"GCT-ATC" ,"GCT-DM" };static void gdm_port_destruct (struct tty_port *port) {
@@ -160,6 +160,7 @@ static ssize_t gdm_tty_write(struct tty_struct *tty, const u8 *buf, size_t len)while (remain) {size_t sending_len =min_t (size_t,MUX_TX_MAX_SIZE , remain); + gdm->tty_dev->send_func(gdm->tty_dev->priv_dev, (void *)(buf + sent_len), sending_len,
@@ -272,7 +273,7 @@ int register_lte_tty_driver(void)for (i =0 ; i <TTY_MAX_COUNT ; i++) { tty_driver =tty_alloc_driver (GDM_TTY_MINOR , -TTY_DRIVER_REAL_RAW |TTY_DRIVER_DYNAMIC_DEV ); +TTY_DRIVER_REAL_RAW |TTY_DRIVER_DYNAMIC_DEV );if (IS_ERR (tty_driver))return PTR_ERR (tty_driver);
Signature · 1 line
2.34.1
Greg KH
maintainerQuoted 8 lines · On Thu, Oct 15, 2026 at 03:01:25PM +0530, [email protected] wrote:
From: Palak Raval <[email protected]>
The
DEVICE_STRINGarray contains pointers to string literals and is never modified.Declare it as 'const char * const' to improve const correctness and prevent accidental modification. Also fix minor formatting issues reported by checkpatch.
Please only do one logical thing per patch.
thanks,
greg k-h
PATCH v2 1/1 staging: gdm724x: make DEVICE_STRING array const
In reply to [email protected]From: Palak Raval <[email protected]>
The DEVICE_STRING array contains pointers to string literals and is never modified.
Declare it as 'const char * const' to improve const correctness and prevent accidental modification.
---
v2:
- Drop unrelated formatting changes
- Keep only the DEVICE_STRING const-correctness change
--- drivers/staging/gdm724x/gdm_tty.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/gdm724x/gdm_tty.c +1 -1
@@ -31,7 +31,7 @@ static struct gdm *gdm_table[TTY_MAX_COUNT][GDM_TTY_MINOR];static DEFINE_MUTEX (gdm_table_lock);static const char *DRIVER_STRING [TTY_MAX_COUNT ] = {"GCTATC" ,"GCTDM" }; -static char *DEVICE_STRING [TTY_MAX_COUNT ] = {"GCT-ATC" ,"GCT-DM" }; +static const char *const DEVICE_STRING [TTY_MAX_COUNT ] = {"GCT-ATC" ,"GCT-DM" };static void gdm_port_destruct (struct tty_port *port) {
Signature · 1 line
2.34.1
Greg KH
maintainerQuoted 34 lines · On Thu, Oct 15, 2026 at 05:48:06PM +0530, [email protected] wrote:
From: Palak Raval <[email protected]>
The
DEVICE_STRINGarray contains pointers to string literals and is never modified.Declare it as 'const char * const' to improve const correctness and prevent accidental modification.
Signed-off-by Palak Raval <[email protected]>---
v2:
- Drop unrelated formatting changes
- Keep only theDEVICE_STRINGconst-correctness change--- drivers/staging/gdm724x/gdm_tty.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/gdm724x/gdm_tty.c +1
-1@@ -31,7 +31,7 @@ static struct gdm *gdm_table[TTY_MAX_COUNT][GDM_TTY_MINOR];static DEFINE_MUTEX (gdm_table_lock);static const char *DRIVER_STRING [TTY_MAX_COUNT ] = {"GCTATC" ,"GCTDM" }; -static char *DEVICE_STRING [TTY_MAX_COUNT ] = {"GCT-ATC" ,"GCT-DM" }; +static const char *const DEVICE_STRING [TTY_MAX_COUNT ] = {"GCT-ATC" ,"GCT-DM" };static void gdm_port_destruct (struct tty_port *port) {Signature · 1 line
2.34.1
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.
You are receiving this message because of the following common error(s) as indicated below:
- Your patch did not apply to any known trees that Greg is in control of. Possibly this is because you made it against Linus's tree, not the linux-next tree, which is where all of the development for the next version of the kernel is at. Please refresh your patch against the linux-next tree, or even better yet, the development tree specified in the MAINTAINERS file for the subsystem you are submitting a patch for, and resend it.
If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.
thanks,
greg k-h's patch email bot