Skip to contentSkip to conversation

staging: rtl8723bs: rename rtw_setstaKey_cmdrsp_callback()

PATCH In review Linus Probert 2 participants 3 messages Oct 22 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rtl8723bs: rename rtw_setstaKey_cmdrsp_callback()

Renames rtw_setstaKey_cmdrsp_callback to rtw_setstakey_cmdrsp_callback in order to conform to kernel code style.

Found using checkpatch.pl

---
 drivers/staging/rtl8723bs/core/rtw_cmd.c    | 4 ++--
 drivers/staging/rtl8723bs/include/rtw_cmd.h | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
drivers/staging/rtl8723bs/core/rtw_cmd.c +2 -2
index 9fc62cb1ae01..81aef5ffe685 100644
@@ -34,7 +34,7 @@ static struct _cmd_callback rtw_cmd_callback[] = {
 	{SET_AUTH_CMD, NULL},
 
 	{SET_KEY_CMD, NULL},	/*20*/
-	{SET_STA_KEY_CMD, &rtw_setstaKey_cmdrsp_callback},
+	{SET_STA_KEY_CMD, &rtw_setstakey_cmdrsp_callback},
 	{SET_ASSOC_STA_CMD, &rtw_setassocsta_cmdrsp_callback},
 	{DEL_ASSOC_STA_CMD, NULL},
 	{SET_STA_PWR_STATE_CMD, NULL},
@@ -1876,7 +1876,7 @@ void rtw_createbss_cmd_callback(struct adapter *padapter, struct cmd_obj *pcmd)
 	rtw_free_cmd_obj(pcmd);
 }
 
-void rtw_setstaKey_cmdrsp_callback(struct adapter *padapter,  struct cmd_obj *pcmd)
+void rtw_setstakey_cmdrsp_callback(struct adapter *padapter,  struct cmd_obj *pcmd)
 {
 	struct sta_priv *pstapriv = &padapter->stapriv;
 	struct set_stakey_rsp *psetstakey_rsp = (struct set_stakey_rsp *)(pcmd->rsp);
drivers/staging/rtl8723bs/include/rtw_cmd.h +1 -1
index 75a774f8c4f3..9b801a61b69b 100644
@@ -593,7 +593,7 @@ void rtw_joinbss_cmd_callback(struct adapter  *padapter, struct cmd_obj *pcmd);
 void rtw_createbss_cmd_callback(struct adapter  *padapter, struct cmd_obj *pcmd);
 void rtw_getbbrfreg_cmdrsp_callback(struct adapter  *padapter, struct cmd_obj *pcmd);
 
-void rtw_setstaKey_cmdrsp_callback(struct adapter  *padapter,  struct cmd_obj *pcmd);
+void rtw_setstakey_cmdrsp_callback(struct adapter  *padapter,  struct cmd_obj *pcmd);
 void rtw_setassocsta_cmdrsp_callback(struct adapter  *padapter,  struct cmd_obj *pcmd);
 void rtw_getrttbl_cmdrsp_callback(struct adapter  *padapter,  struct cmd_obj *pcmd);
 
Signature · 1 line
2.56.0
#1 lore raw
Quoted 38 lines · Linus Probert

Renames rtw_setstaKey_cmdrsp_callback to rtw_setstakey_cmdrsp_callback in order to conform to kernel code style.

Found using checkpatch.pl

---
  drivers/staging/rtl8723bs/core/rtw_cmd.c    | 4 ++--
  drivers/staging/rtl8723bs/include/rtw_cmd.h | 2 +-
  2 files changed, 3 insertions(+), 3 deletions(-)
drivers/staging/rtl8723bs/core/rtw_cmd.c +2 -2
index 9fc62cb1ae01..81aef5ffe685 100644
@@ -34,7 +34,7 @@ static struct _cmd_callback rtw_cmd_callback[] = {
  	{SET_AUTH_CMD, NULL},
 
  	{SET_KEY_CMD, NULL},	/*20*/
-	{SET_STA_KEY_CMD, &rtw_setstaKey_cmdrsp_callback},
+	{SET_STA_KEY_CMD, &rtw_setstakey_cmdrsp_callback},
  	{SET_ASSOC_STA_CMD, &rtw_setassocsta_cmdrsp_callback},
  	{DEL_ASSOC_STA_CMD, NULL},
  	{SET_STA_PWR_STATE_CMD, NULL},
@@ -1876,7 +1876,7 @@ void rtw_createbss_cmd_callback(struct adapter *padapter, struct cmd_obj *pcmd)
  	rtw_free_cmd_obj(pcmd);
  }
 
-void rtw_setstaKey_cmdrsp_callback(struct adapter *padapter,  struct cmd_obj *pcmd)
+void rtw_setstakey_cmdrsp_callback(struct adapter *padapter,  struct cmd_obj *pcmd)
  {
  	struct sta_priv *pstapriv = &padapter->stapriv;
  	struct set_stakey_rsp *psetstakey_rsp = (struct set_stakey_rsp *)(pcmd->rsp);
drivers/staging/rtl8723bs/include/rtw_cmd.h +0 -0
index 75a774f8c4f3..9b801a61b69b 100644

drivers/staging/rtl8723bs/include/rtw_cmd.h void rtw_joinbss_cmd_callback(struct adapter *padapter, struct cmd_obj *pcmd); · line 599

Quoted 8 lines
drivers/staging/rtl8723bs/include/rtw_cmd.h +1 -1
@@ -593,7 +593,7 @@ void rtw_joinbss_cmd_callback(struct adapter  *padapter, struct cmd_obj *pcmd);
  void rtw_createbss_cmd_callback(struct adapter  *padapter, struct cmd_obj *pcmd);
  void rtw_getbbrfreg_cmdrsp_callback(struct adapter  *padapter, struct cmd_obj *pcmd);
 
-void rtw_setstaKey_cmdrsp_callback(struct adapter  *padapter,  struct cmd_obj *pcmd);
+void rtw_setstakey_cmdrsp_callback(struct adapter  *padapter,  struct cmd_obj *pcmd);
  void rtw_setassocsta_cmdrsp_callback(struct adapter  *padapter,  struct cmd_obj *pcmd);
  void rtw_getrttbl_cmdrsp_callback(struct adapter  *padapter,  struct cmd_obj *pcmd);
 

This driver is going to be deleted in the next release, have a look:

https://lore.kernel.org/linux-staging/[email protected]/

Regards,
Ahmet Sezgin Duran

#2 lore raw
Quoted 50 lines · Ahmet Sezgin Duran
Quoted 38 lines · Linus Probert

Renames rtw_setstaKey_cmdrsp_callback to rtw_setstakey_cmdrsp_callback in order to conform to kernel code style.

Found using checkpatch.pl

---
  drivers/staging/rtl8723bs/core/rtw_cmd.c    | 4 ++--
  drivers/staging/rtl8723bs/include/rtw_cmd.h | 2 +-
  2 files changed, 3 insertions(+), 3 deletions(-)
drivers/staging/rtl8723bs/core/rtw_cmd.c +2 -2
index 9fc62cb1ae01..81aef5ffe685 100644
@@ -34,7 +34,7 @@ static struct _cmd_callback rtw_cmd_callback[] = {
  	{SET_AUTH_CMD, NULL},
 
  	{SET_KEY_CMD, NULL},	/*20*/
-	{SET_STA_KEY_CMD, &rtw_setstaKey_cmdrsp_callback},
+	{SET_STA_KEY_CMD, &rtw_setstakey_cmdrsp_callback},
  	{SET_ASSOC_STA_CMD, &rtw_setassocsta_cmdrsp_callback},
  	{DEL_ASSOC_STA_CMD, NULL},
  	{SET_STA_PWR_STATE_CMD, NULL},
@@ -1876,7 +1876,7 @@ void rtw_createbss_cmd_callback(struct adapter *padapter, struct cmd_obj *pcmd)
  	rtw_free_cmd_obj(pcmd);
  }
 
-void rtw_setstaKey_cmdrsp_callback(struct adapter *padapter,  struct cmd_obj *pcmd)
+void rtw_setstakey_cmdrsp_callback(struct adapter *padapter,  struct cmd_obj *pcmd)
  {
  	struct sta_priv *pstapriv = &padapter->stapriv;
  	struct set_stakey_rsp *psetstakey_rsp = (struct set_stakey_rsp *)(pcmd->rsp);
drivers/staging/rtl8723bs/include/rtw_cmd.h +0 -0
index 75a774f8c4f3..9b801a61b69b 100644

drivers/staging/rtl8723bs/include/rtw_cmd.h void rtw_joinbss_cmd_callback(struct adapter *padapter, struct cmd_obj *pcmd); · line 599

Quoted 8 lines
drivers/staging/rtl8723bs/include/rtw_cmd.h +1 -1
@@ -593,7 +593,7 @@ void rtw_joinbss_cmd_callback(struct adapter  *padapter, struct cmd_obj *pcmd);
  void rtw_createbss_cmd_callback(struct adapter  *padapter, struct cmd_obj *pcmd);
  void rtw_getbbrfreg_cmdrsp_callback(struct adapter  *padapter, struct cmd_obj *pcmd);
 
-void rtw_setstaKey_cmdrsp_callback(struct adapter  *padapter,  struct cmd_obj *pcmd);
+void rtw_setstakey_cmdrsp_callback(struct adapter  *padapter,  struct cmd_obj *pcmd);
  void rtw_setassocsta_cmdrsp_callback(struct adapter  *padapter,  struct cmd_obj *pcmd);
  void rtw_getrttbl_cmdrsp_callback(struct adapter  *padapter,  struct cmd_obj *pcmd);
 

This driver is going to be deleted in the next release, have a look:

Quoted 4 lines

https://lore.kernel.org/linux-staging/[email protected]/

Regards,
Ahmet Sezgin Duran

Ah, no. I had missed that apologies and thanks for the info.

// Linus