Skip to contentSkip to conversation

mm/page_alloc: remove unneeded forward declaration of __free_pages_ok()

PATCH In review Zenghui Yu 5 participants 5 messages Oct 22 – Oct 23

Subsystems (2)
lore
Share & tools
lore

Zenghui Yu

author
#0 lore raw

PATCH 1/1 mm/page_alloc: remove unneeded forward declaration of __free_pages_ok()

From: "Zenghui Yu (Huawei)" <[email protected]>

All remaining callers of __free_pages_ok() appear after its definition, so the forward declaration near the top of mm/page_alloc.c is no longer needed. Remove it.

---
 mm/page_alloc.c | 2 --
 1 file changed, 2 deletions(-)
mm/page_alloc.c +0 -2
index 0396c50b96f0..6db90e0aa929 100644
@@ -216,8 +216,6 @@ gfp_t gfp_allowed_mask __read_mostly = GFP_BOOT_MASK;
 unsigned int pageblock_order __read_mostly;
 #endif
 
-static void __free_pages_ok(struct page *page, unsigned int order,
-			    fpi_t fpi_flags);
 static void reserve_highatomic_pageblock(struct page *page, int order,
 					 struct zone *zone);
 
Signature · 1 line
2.56.0
reviewer Reviewed-by on v1 1/1
#1 lore raw
Quoted 11 lines · Zenghui Yu

From: "Zenghui Yu (Huawei)" <[email protected]>

All remaining callers of __free_pages_ok() appear after its definition, so the forward declaration near the top of mm/page_alloc.c is no longer needed. Remove it.

---
 mm/page_alloc.c | 2 --
 1 file changed, 2 deletions(-)

LGTM. Thanks.

Signature · 2 lines
Best Regards,
Yan, Zi
Reviewed-by on v1 1/1
#3 lore raw
In reply to Zenghui Yu
Quoted 7 lines · Zenghui Yu

From: "Zenghui Yu (Huawei)" <[email protected]>

All remaining callers of __free_pages_ok() appear after its definition, so the forward declaration near the top of mm/page_alloc.c is no longer needed. Remove it.

Quoted 20 lines
---
 mm/page_alloc.c | 2 --
 1 file changed, 2 deletions(-)
mm/page_alloc.c +0 -2
index 0396c50b96f0..6db90e0aa929 100644
@@ -216,8 +216,6 @@ gfp_t gfp_allowed_mask __read_mostly = GFP_BOOT_MASK;
 unsigned int pageblock_order __read_mostly;
 #endif
 
-static void __free_pages_ok(struct page *page, unsigned int order,
-			    fpi_t fpi_flags);
 static void reserve_highatomic_pageblock(struct page *page, int order,
 					 struct zone *zone);
 
Signature · 1 line
2.56.0
Reviewed-by on v1 1/1
#4 lore raw
In reply to Zenghui Yu
Quoted 8 lines · Zenghui Yu

From: "Zenghui Yu (Huawei)" <[email protected]>

All remaining callers of __free_pages_ok() appear after its definition, so the forward declaration near the top of mm/page_alloc.c is no longer needed. Remove it.

---

Quoted 16 lines
 mm/page_alloc.c | 2 --
 1 file changed, 2 deletions(-)
mm/page_alloc.c +0 -2
index 0396c50b96f0..6db90e0aa929 100644
@@ -216,8 +216,6 @@ gfp_t gfp_allowed_mask __read_mostly = GFP_BOOT_MASK;
 unsigned int pageblock_order __read_mostly;
 #endif
 
-static void __free_pages_ok(struct page *page, unsigned int order,
-			    fpi_t fpi_flags);
 static void reserve_highatomic_pageblock(struct page *page, int order,
 					 struct zone *zone);