Skip to contentSkip to conversation

media: ipu-bridge: Add DMI quirk for Dell 16 Premium DA16250

PATCH In review Gabriele Gamba 1 participant 2 messages Oct 26 – Nov 10 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 media: ipu-bridge: Add DMI quirk for Dell 16 Premium DA16250

The Dell 16 Premium ships with at least two different DMI product names. "XPS 16 (Dell 16 Premium) DA16250" is already handled, but some units report "Dell 16 Premium DA16250" instead. On those the OV02C10 image is upside down, as neither SSDB nor _PLD describes the 180 degree sensor rotation.

Add the second spelling, mirroring what is already done for the 14 inch model, which is listed both as "XPS 14 (Dell 14 Premium) DA14250" and as "Dell 14 Premium DA14250".

Tested on a Dell 16 Premium DA16250 (Core Ultra 9 285H, OV02C10 behind an Intel CVS controller on USBIO).

---
 drivers/media/pci/intel/ipu-bridge.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/media/pci/intel/ipu-bridge.c +7 -0
index 3739c4a2a..c7b66cccc 100644
@@ -191,6 +191,13 @@ static const struct dmi_system_id upside_down_sensor_dmi_ids[] = {
 		},
 		.driver_data = "OVTI02C1",
 	},
+	{
+		.matches = {
+			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Dell 16 Premium DA16250"),
+		},
+		.driver_data = "OVTI02C1",
+	},
 	/*
 	 * The first four characters of DMI_BOARD_NAME identify the Lenovo
 	 * machine type/model. For example, a DMI_BOARD_NAME starting with
Signature · 1 line
2.56.0
#1 lore raw

Hi Sakari,

I've since noticed that Lukas Larson sent the same change on 31 March:
<[email protected]>

You mentioned there that you'd take it for v7.2, but it doesn't seem to have landed. The diff is identical, so either patch works; if you prefer his for being earlier, I've added my Tested-by on that thread.

Thanks,
Gabriele