Skip to contentSkip to conversation

arm64: dts: qcom: Add dmic45 support to rb3gen2 vision mezzanine overlay

PATCH Superseded Kumar Anurag 2 participants 3 messages Oct 27 – Nov 12

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: dts: qcom: Add dmic45 support to rb3gen2 vision mezzanine overlay

Add pinctrl states and VA macro routing for two additional digital microphones (DMIC4/DMIC5) that are present on the vision mezzanine add-on board, mirroring the dmic01/dmic23 pattern already used for the on-board microphones.

---
 .../qcs6490-rb3gen2-vision-mezzanine.dtso     | 39 +++++++++++++++++++
 1 file changed, 39 insertions(+)
arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-vision-mezzanine.dtso +39 -0
index aceafea45343..0a4e6080a2b2 100644
@@ -80,3 +80,42 @@ cam_mclk3_suspend: cam-mclk3-suspend-state {
 		bias-pull-down;
 	};
 };
+
+&lpass_tlmm {
+	lpass_dmic45_clk: dmic45-clk-state {
+		pins = "gpio12";
+		function = "dmic3_clk";
+	};
+
+	lpass_dmic45_data: dmic45-data-state {
+		pins = "gpio13";
+		function = "dmic3_data";
+	};
+};
+
+&lpass_va_macro {
+	pinctrl-0 = <&lpass_dmic01_clk>, <&lpass_dmic01_data>,
+		    <&lpass_dmic23_clk>, <&lpass_dmic23_data>,
+		    <&lpass_dmic45_clk>, <&lpass_dmic45_data>;
+	pinctrl-names = "default";
+};
+
+&sound {
+	audio-routing = "SpkrLeft IN", "WSA_SPK1 OUT",
+			"SpkrRight IN", "WSA_SPK2 OUT",
+			"VA DMIC0", "vdd-micb",
+			"VA DMIC1", "vdd-micb",
+			"VA DMIC2", "vdd-micb",
+			"VA DMIC3", "vdd-micb",
+			"VA DMIC4", "vdd-micb",
+			"VA DMIC5", "vdd-micb";
+};
+
+&lpass_dmic45_clk {
+	drive-strength = <8>;
+	bias-disable;
+};
+
+&lpass_dmic45_data {
+	bias-pull-down;
+};
Signature · 1 line
2.34.1
#1 lore raw
Quoted 20 lines · Kumar Anurag

Add pinctrl states and VA macro routing for two additional digital microphones (DMIC4/DMIC5) that are present on the vision mezzanine add-on board, mirroring the dmic01/dmic23 pattern already used for the on-board microphones.

---
 .../qcs6490-rb3gen2-vision-mezzanine.dtso     | 39 +++++++++++++++++++
 1 file changed, 39 insertions(+)
arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-vision-mezzanine.dtso +2 -0
index aceafea45343..0a4e6080a2b2 100644
@@ -80,3 +80,42 @@ cam_mclk3_suspend: cam-mclk3-suspend-state {
 		bias-pull-down;
 	};
 };
+
+&lpass_tlmm {

arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-vision-mezzanine.dtso cam_mclk3_suspend: cam-mclk3-suspend-state { · line 94

Quoted 10 lines
arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-vision-mezzanine.dtso +10 -0
+	lpass_dmic45_clk: dmic45-clk-state {
+		pins = "gpio12";
+		function = "dmic3_clk";
+	};
+
+	lpass_dmic45_data: dmic45-data-state {
+		pins = "gpio13";
+		function = "dmic3_data";
+	};
+};

This should go to kodiak.dtsi

Konrad

#2 lore raw

PATCH v2 1/1 arm64: dts: qcom: Add dmic45 support to rb3gen2 vision mezzanine overlay

In reply to Kumar Anurag

Add pinctrl states and VA macro routing for two additional digital microphones (DMIC4/DMIC5) that are present on the vision mezzanine add-on board, mirroring the dmic01/dmic23 pattern already used for the on-board microphones.

---
Changes in v2:
- Move the dmic45 pinctrl states into kodiak.dtsi instead of the
mezzanine overlay, since gpio12/gpio13 belong to the SoC's
lpass_tlmm block, mirroring the existing dmic01/dmic23 definitions
(Konrad).
- Link to v1: https://lore.kernel.org/r/[email protected]

 arch/arm64/boot/dts/qcom/kodiak.dtsi           | 14 ++++++++++++++
 .../qcom/qcs6490-rb3gen2-vision-mezzanine.dtso | 18 ++++++++++++++++++
 2 files changed, 32 insertions(+)
arch/arm64/boot/dts/qcom/kodiak.dtsi +14 -0
index 8c7523602d27..87a67eed84d7 100644
@@ -3060,6 +3060,20 @@ lpass_dmic23_data: dmic23-data-state {
 				bias-pull-down;
 			};
 
+			lpass_dmic45_clk: dmic45-clk-state {
+				pins = "gpio12";
+				function = "dmic3_clk";
+				drive-strength = <8>;
+				bias-disable;
+			};
+
+			lpass_dmic45_data: dmic45-data-state {
+				pins = "gpio13";
+				function = "dmic3_data";
+				drive-strength = <8>;
+				bias-pull-down;
+			};
+
 			lpass_i2s1_active: i2s1-active-state {
 				clk-pins {
 					pins = "gpio6";
arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-vision-mezzanine.dtso +18 -0
index aceafea45343..11c68f3120df 100644
@@ -80,3 +80,21 @@ cam_mclk3_suspend: cam-mclk3-suspend-state {
 		bias-pull-down;
 	};
 };
+
+&lpass_va_macro {
+	pinctrl-0 = <&lpass_dmic01_clk>, <&lpass_dmic01_data>,
+		    <&lpass_dmic23_clk>, <&lpass_dmic23_data>,
+		    <&lpass_dmic45_clk>, <&lpass_dmic45_data>;
+	pinctrl-names = "default";
+};
+
+&sound {
+	audio-routing = "SpkrLeft IN", "WSA_SPK1 OUT",
+			"SpkrRight IN", "WSA_SPK2 OUT",
+			"VA DMIC0", "vdd-micb",
+			"VA DMIC1", "vdd-micb",
+			"VA DMIC2", "vdd-micb",
+			"VA DMIC3", "vdd-micb",
+			"VA DMIC4", "vdd-micb",
+			"VA DMIC5", "vdd-micb";
+};
Signature · 1 line
2.34.1