Skip to contentSkip to conversation

asha: use robust streaming connection parameters

RFC PATCH In review Kyle Pepper 3 participants 4 messages Oct 28 – Nov 16 Bluetooth drivers

lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 asha: use robust streaming connection parameters

The tested renderer requests a six-second supervision timeout and latency of five events. Use these values instead of the one-second timeout and ten-event latency that accompanied link failures.

Assisted-by OpenCode:gpt-6.1-sol

---
Resending unchanged after automated CI PR2667 expiry; no source changes.
Previous submission: https://lore.kernel.org/linux-bluetooth/[email protected]/
Earlier remote functional, lowercase checkpatch, Codacy Security Scan and
outer-CI failures remain unresolved. Historical local passes do not
establish remote success; no new hardware or functional test is claimed.

Submission review notes (not part of the commit message):
Local validation is for base 7428ca2df9356363079db0f48412c20cbdb9471f. Compatibility with newer upstream tips has not been verified locally. October 9 N8/UB500 trials independently restore timeout 1 s and latency
10. Completed HCI values change as intended; the variants have five and four supervision timeouts respectively. Restoring latency 5 / timeout 6 s restores short streaming. These are device-tested values, not universally optimal ASHA defaults. STATUS and the other downstream fixes stayed on.

 profiles/audio/asha.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
profiles/audio/asha.c +5 -4
index 8e625fdca3..409b4f20b5 100644
@@ -50,6 +50,9 @@
 #define ASHA_MIN_MTU 163
 /* The default of 672 does not work */
 #define ASHA_CONNECTION_MTU 512
+#define ASHA_CONN_INTERVAL 0x0010 /* 20 ms in 1.25 ms units */
+#define ASHA_CONN_LATENCY 0x0005
+#define ASHA_SUPERVISION_TIMEOUT 0x0258 /* 6 s in 10 ms units */
 
 struct bt_asha_device {
 	struct bt_asha *asha;
@@ -162,10 +165,8 @@ unsigned int bt_asha_device_start(struct bt_asha_device *asha_dev,
 	int ret;
 
 	btd_device_set_conn_param(asha_dev->device,
-			0x0010 /* min interval = 1.25ms intervals => 20ms */,
-			0x0010 /* max interval = 1.25ms intervals => 20ms */,
-			0x000A /* 10 events' latency */,
-			0x0064 /* 1s timeout */);
+			ASHA_CONN_INTERVAL, ASHA_CONN_INTERVAL,
+			ASHA_CONN_LATENCY, ASHA_SUPERVISION_TIMEOUT);
 
 	ret = asha_connect_socket(asha_dev, cb, user_data);
 

base-commit: 7428ca2df9356363079db0f48412c20cbdb9471f

#1 lore raw

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/series/1195452/

---Test result---

Test Summary:

CheckPatch                    PASS      0.48 seconds
GitLint                       PASS      0.34 seconds
BuildEll                      PASS      20.47 seconds
BluezMake                     PASS      289.80 seconds
MakeCheck                     PASS      3.80 seconds
MakeDistcheck                 PASS      146.29 seconds
CheckValgrind                 PASS      152.85 seconds
CheckSmatch                   PASS      282.73 seconds
bluezmakeextell               PASS      95.94 seconds
TestFunctional                PASS      1120.00 seconds
IncrementalBuild              PASS      288.41 seconds
ScanBuild                     PASS      1031.28 seconds

https://github.com/bluez/bluez/pull/2729

---
Regards,
Linux Bluetooth

#2 lore raw
In reply to Kyle Pepper

This is an automated email and please do not reply to this email.

Dear Submitter,

This series was picked up by the CI more than 2 weeks ago and the pull request created for it is still open, which means the series was never applied to the tree.

Series: [RFC,RESEND] asha: use robust streaming connection parameters
Pull Request: https://github.com/bluez/bluez/pull/2729
Created: 2026-10-28 15:20:49+00:00

The pull request has been closed and no further action is taken on this series.

If the change should still be considered, it must be resent to the Linux Bluetooth mailing list ([email protected]) so that it is picked up again.

---
Regards,
Linux Bluetooth

#3 lore raw
In reply to Kyle Pepper
Quoted 41 lines · Kyle Pepper

The tested renderer requests a six-second supervision timeout and latency of five events. Use these values instead of the one-second timeout and ten-event latency that accompanied link failures.

Assisted-by OpenCode:gpt-6.1-sol

---
Resending unchanged after automated CI PR2667 expiry; no source changes. Previous submission:
https://lore.kernel.org/linux-bluetooth/[email protected]/
Earlier remote functional, lowercase checkpatch, Codacy Security Scan and
outer-CI failures remain unresolved. Historical local passes do not establish remote success; no new hardware or functional test is claimed.

Submission review notes (not part of the commit message):
Local validation is for base 7428ca2df9356363079db0f48412c20cbdb9471f. Compatibility with newer upstream tips has not been verified locally. October 9 N8/UB500 trials independently restore timeout 1 s and latency
10. Completed HCI values change as intended; the variants have five and four supervision timeouts respectively. Restoring latency 5 / timeout 6 s restores short streaming. These are device-tested values, not universally optimal ASHA defaults. STATUS and the other downstream fixes stayed on.

 profiles/audio/asha.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
profiles/audio/asha.c +3 -0
index 8e625fdca3..409b4f20b5 100644
@@ -50,6 +50,9 @@
 #define ASHA_MIN_MTU 163
 /* The default of 672 does not work */
 #define ASHA_CONNECTION_MTU 512
+#define ASHA_CONN_INTERVAL 0x0010 /* 20 ms in 1.25 ms units */
+#define ASHA_CONN_LATENCY 0x0005
+#define ASHA_SUPERVISION_TIMEOUT 0x0258 /* 6 s in 10 ms units */
 
 struct bt_asha_device {
 	struct bt_asha *asha;

profiles/audio/asha.c unsigned int bt_asha_device_start(struct · line 170

Quoted 10 lines
profiles/audio/asha.c +2 -4
@@ -162,10 +165,8 @@ unsigned int bt_asha_device_start(struct 
 bt_asha_device *asha_dev,
 	int ret;
 
 	btd_device_set_conn_param(asha_dev->device,
-			0x0010 /* min interval = 1.25ms intervals => 20ms */,
-			0x0010 /* max interval = 1.25ms intervals => 20ms */,
-			0x000A /* 10 events' latency */,
-			0x0064 /* 1s timeout */);
+			ASHA_CONN_INTERVAL, ASHA_CONN_INTERVAL,
+			ASHA_CONN_LATENCY, ASHA_SUPERVISION_TIMEOUT);

These values may not make sense globally as the notes above mention.

The 10 event / 1s come from here, fwiw: https://cs.android.com/android/platform/superproject/+/android-latest-release:packages/modules/Bluetooth/system/bta/hearing_aid/hearing_aid.cc;l=453

-- Arun