Skip to contentSkip to conversation

Bluetooth: MGMT: Clear disabled connection parameters when loading none

PATCH Applied Kevin Dewald 3 participants 3 messages Oct 29 – Oct 30

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Bluetooth: MGMT: Clear disabled connection parameters when loading none

Load Connection Parameters only clears the disabled connection parameters when it loads more than one entry, so that loading a single entry can update the parameters of one device without dropping the others. Loading no entries does not clear them either, though, which is what bluetoothd does when it starts without stored connection parameters.

Pair Device adds disabled connection parameters for the device it pairs with, so these now survive bluetoothd restarts, and new connections to the device keep using the parameters they were created with instead of the defaults set since, e.g. the connection interval from main.conf.

Clear the disabled connection parameters unless a single entry is loaded, as was done for any number of entries before.

Fixes 0ece498c27d8 ("Bluetooth: MGMT: Make MGMT_OP_LOAD_CONN_PARAM update existing connection")
Assisted-by Claude:claude-opus-5.5

---
Found with the BlueZ functional tests, which run one after another on the same VMs: after test_bearer_le_pair, the next LE connection between the two hosts kept the parameters the pairing had added.

Reproduced in test-runner: host0 pairs with host1, then bluetoothd is restarted on host0 with MinConnectionInterval and MaxConnectionInterval of 80 (100 ms) in main.conf and connects to host1 again. Without this patch LE Extended Create Connection asks for 30 to 50 ms (3 of 3 runs), with it for 100 ms (3 of 3). Without the earlier pairing it asks for 100 ms either way. The kernel testers pass as before. Only tested with the emulator.

 net/bluetooth/mgmt.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
net/bluetooth/mgmt.c +5 -1
index 3cb4f9ece8..cf5256f4a8 100644
@@ -8175,7 +8175,11 @@ static int load_conn_param(struct sock *sk, struct hci_dev *hdev, void *data,
 
 	hci_dev_lock(hdev);
 
-	if (param_count > 1)
+	/* A single entry may be an update for one device, so keep the other
+	 * disabled parameters then, but clear them otherwise, including when
+	 * no entries are loaded.
+	 */
+	if (param_count != 1)
 		hci_conn_params_clear_disabled(hdev);
 
 	for (i = 0; i < param_count; i++) {

base-commit: 1081a6ef8f1e0661fd52eb3f878691b0b96cdff9

Signature · 1 line
2.53.0
#1 lore raw

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/series/1196594/

---Test result---

Test Summary:

CheckPatch                    PASS      0.54 seconds
VerifyFixes                   PASS      0.88 seconds
VerifySignedoff               PASS      0.20 seconds
GitLint                       PASS      0.29 seconds
SubjectPrefix                 PASS      0.10 seconds
BuildKernel                   PASS      20.74 seconds
CheckAllWarning               PASS      22.82 seconds
CheckSparse                   PASS      25.29 seconds
BuildKernel32                 PASS      27.67 seconds
CheckKernelLLVM               PASS      21.46 seconds
TestRunnerSetup               PASS      466.36 seconds
TestRunner_mgmt-tester        PASS      82.60 seconds
TestRunner_mesh-tester        PASS      9.94 seconds
IncrementalBuild              PASS      22.36 seconds

https://github.com/bluez/bluetooth-next/pull/1025

---
Regards,
Linux Bluetooth

#2 lore raw
In reply to Kevin Dewald
This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <[email protected]>:

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <[email protected]>:

Quoted 8 lines · On Thu, 29 Oct 2026 13:28:32 -0700 you wrote:

Load Connection Parameters only clears the disabled connection parameters when it loads more than one entry, so that loading a single entry can update the parameters of one device without dropping the others. Loading no entries does not clear them either, though, which is what bluetoothd does when it starts without stored connection parameters.

[...]

Here is the summary with links:
- Bluetooth: MGMT: Clear disabled connection parameters when loading none

    https://git.kernel.org/bluetooth/bluetooth-next/c/b621473a7fff

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html