Skip to contentSkip to conversation

nvme-pci: add NVME_QUIRK_NO_SECONDARY_TEMP_THRESH for WD SN740

PATCH Robson Cassiano 1 participant 1 message Oct 30 1 message not in the archive NVMe

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

Retracting this patch.

The drive accepts and stores threshold writes on both secondary sensors, so 0 and 0xffff Kelvin are the spec-mandated power-on defaults and not a controller defect. Hiding temp2_min/max and temp3_min/max would remove working functionality.

Tested on 15b7:5017 (SN740, firmware 73100004), kernel 7.2.8, where the quirk is not applied. The hwmon interface takes millicelsius, so 350 K is written as 76850:

# Sensor 1, over temperature threshold
echo 76850 > /sys/class/hwmon/hwmon4/temp2_max
cat /sys/class/hwmon/hwmon4/temp2_max
76850

# Sensor 2, over temperature threshold
echo 76850 > /sys/class/hwmon/hwmon4/temp3_max
cat /sys/class/hwmon/hwmon4/temp3_max
76850

# Sensor 1, under temperature threshold
echo 76850 > /sys/class/hwmon/hwmon4/temp2_min
cat /sys/class/hwmon/hwmon4/temp2_min
76850

Every readback is a fresh Get Features, and all three return the written value, so NVME_FEAT_TEMP_THRESH succeeds on the secondary sensors and the values persist. The composite sensor (temp1_max) behaves the same way.

The attributes were restored to the power-on defaults afterwards (tempN_max 0xffff, tempN_min 0x0000) and the live sensor inputs were unaffected throughout.

The review was correct.

--
Robson Cassiano