ASoC: codecs: sn624x-sdca: limit DMIC capture to 2 channels
PATCH 1/1 ASoC: codecs: sn624x-sdca: limit DMIC capture to 2 channels
The SN624x DMIC path only has two microphones. The aif3 capture DAI advertised channels_max = 4, so userspace could open a 4-channel capture that the hardware does not provide.
Clamp the DMIC capture DAI to two channels to match the headset capture DAI and the sof-sdca-mic function topology.
Tested on a Wildcat Lake laptop with SN6244: hw:*,4 reports CHANNELS 2 and rejects a 4-channel arecord.
--- sound/soc/codecs/sn624x-sdca-sdw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/sn624x-sdca-sdw.c +1 -1
@@ -1669,7 +1669,7 @@ static struct snd_soc_dai_driver sn624x_sdca_dai[] = { .capture = { .stream_name = "DMic Capture", .channels_min = 1, - .channels_max = 4, + .channels_max = 2, .rates = SN624X_STEREO_RATES, .formats = SN624X_FORMATS, },
Signature · 1 line
2.53.0
Mark Brown
maintainerQuoted 1 line · Qianghua Wang
ASoC: codecs: sn624x-sdca: limit DMIC capture to 2 channels
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.4
Thanks!
[1/1] ASoC: codecs: sn624x-sdca: limit DMIC capture to 2 channels
https://git.kernel.org/broonie/sound/c/b54a20b671e3
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark