ALSA: pcm: Prevent O_APPEND open on OSS streams
PATCH 1/1 ALSA: pcm: Prevent O_APPEND open on OSS streams
ALSA PCM core accepts to re-use the existing stream when O_APPEND is passed, and it's been used for dmix, etc. However, this mode isn't supposed to be used for OSS: the OSS stream allows re-configuration via its hw_params/hw_refine procedure even while it's being mmapped, so it implies the usage of only a single stream. Because of this assumption, the sanity check is skipped for OSS streams, and if user may attach to an existing OSS stream with O_APPEND, it may result in a UAF of the mapped pages which could be used as a privilege escalation exploit.
For addressing it, this patch simply prohibits the O_APPEND behavior on the OSS stream. O_APPEND is never used for OSS layer itself, so this can't break for the right applications.
--- sound/core/pcm.c | 2 ++ sound/core/pcm_local.h | 6 ++++++ sound/core/pcm_native.c | 6 ------ 3 files changed, 8 insertions(+), 6 deletions(-)
sound/core/pcm.c +2 -0
@@ -929,6 +929,8 @@ int snd_pcm_attach_substream(struct snd_pcm *pcm, int stream,return -ENODEV ;if (!SUBSTREAM_BUSY (substream))return -EBADFD ; +if (is_oss_stream (substream)) +return -EINVAL ; substream->ref_count++; *rsubstream = substream;return 0 ;
sound/core/pcm_local.h +6 -0
@@ -80,4 +80,10 @@ static inline void snd_pcm_dma_buffer_sync(struct snd_pcm_substream *substream, snd_dma_buffer_sync(snd_pcm_get_dma_buf(substream), mode); } +#if IS_ENABLED (CONFIG_SND_PCM_OSS ) +#define is_oss_stream (substream) ((substream)->oss.oss) +#else +#define is_oss_stream (substream) false +#endif +#endif /* __SOUND_CORE_PCM_LOCAL_H */
sound/core/pcm_native.c +0 -6
@@ -749,12 +749,6 @@ int snd_pcm_runtime_buffer_set_silence(struct snd_pcm_runtime *runtime) }EXPORT_SYMBOL_GPL (snd_pcm_runtime_buffer_set_silence); -#if IS_ENABLED (CONFIG_SND_PCM_OSS ) -#define is_oss_stream (substream) ((substream)->oss.oss) -#else -#define is_oss_stream (substream) false -#endif -static void pcm_qos_req_clear (struct snd_pcm_substream *substream) {if (cpu_latency_qos_request_active (&substream->latency_pm_qos_req))
Signature · 1 line
2.55.0