Skip to contentSkip to conversation

KVM: selftests: add empty install and run_tests targets for unsupported ARCHs

PATCH In review Sasha Levin 2 participants 3 messages Nov 4

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 KVM: selftests: add empty install and run_tests targets for unsupported ARCHs

Commit 43fbd8cd389f ("KVM: selftests: Provide empty 'all' and 'clean' targets for unsupported ARCHs") gave the KVM selftests empty all and clean targets on architectures without KVM selftests, such as 32-bit arm and i386. The selftests Makefile also runs install and run_tests in each suite, and those still fail there:

make[1]: *** No rule to make target 'install'. Stop.

Add empty install and run_tests targets as well.

Fixes 43fbd8cd389f ("KVM: selftests: Provide empty 'all' and 'clean' targets for unsupported ARCHs")

---
Found with KernelCI-style TuxMake builds that record per-suite results with KSFT_BUILD_REPORT. 32-bit arm builds now succeed without installing anything.

 tools/testing/selftests/kvm/Makefile | 2 ++
 1 file changed, 2 insertions(+)
tools/testing/selftests/kvm/Makefile +2 -0
index 03d91f00092f4..3881df8d5b2b8 100644
@@ -13,4 +13,6 @@ else
 # Empty targets for unsupported architectures
 all:
 clean:
+install:
+run_tests:
 endif
Signature · 1 line
2.53.0
#1 lore raw
Quoted 6 lines · Sasha Levin

Commit 43fbd8cd389f ("KVM: selftests: Provide empty 'all' and 'clean' targets for unsupported ARCHs") gave the KVM selftests empty all and clean targets on architectures without KVM selftests, such as 32-bit arm and i386. The selftests Makefile also runs install and run_tests in each suite, and those still fail there:

Quoted 7 lines

make[1]: *** No rule to make target 'install'. Stop.

Add empty install and run_tests targets as well.

Fixes 43fbd8cd389f ("KVM: selftests: Provide empty 'all' and 'clean' targets for unsupported ARCHs")

---

Deuling AIs? The other patch seems like a superset.

https://lore.kernel.org/all/[email protected]

Quoted 22 lines

Found with KernelCI-style TuxMake builds that record per-suite results with KSFT_BUILD_REPORT. 32-bit arm builds now succeed without installing anything.

 tools/testing/selftests/kvm/Makefile | 2 ++
 1 file changed, 2 insertions(+)
tools/testing/selftests/kvm/Makefile +2 -0
index 03d91f00092f4..3881df8d5b2b8 100644
@@ -13,4 +13,6 @@ else
 # Empty targets for unsupported architectures
 all:
 clean:
+install:
+run_tests:
 endif
Signature · 1 line
2.53.0
#2 lore raw
Quoted 3 lines · Sean Christopherson

Deuling AIs? The other patch seems like a superset.

https://lore.kernel.org/all/[email protected]

Sorry, my mistake. Please take the October one and drop this.

This type of issue seems to happen everywhere in tools/, and I feel like I'm in a giant game of whack-a-mole.

--
Thanks,
Sasha