Patch "xfs: fix temporary cursor leak in btree shift corruption paths" has been added to the 7.3-stable tree
Sasha Levin
AppliedThis is a note to let you know that I've just added the patch titled
xfs: fix temporary cursor leak in btree shift corruption paths
to the 7.3-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
xfs-fix-temporary-cursor-leak-in-btree-shift-corrupt.patch
and it can be found in the queue-7.3 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
commit 51b2650de855425bab8a18b76122dc1ab017f021
Author: Jianyun Gao <[email protected]> Date: Mon Nov 2 23:01:41 2026 +0800
xfs: fix temporary cursor leak in btree shift corruption paths
[ Upstream commit 2bbca049deeb1699cafd966cb2793fee576ee409 ]
In xfs_btree_lshift and xfs_btree_rshift, when XFS_IS_CORRUPT detects an invalid firstrec/lastrec result after xfs_btree_dup_cursor has successfully allocated a temporary cursor, the error path jumps to error0 which returns without freeing tcur. This leaks the cursor memory, the xfs_group reference, and the per-level buffer references held by the duplicated cursor. Jump to error1 instead, which calls xfs_btree_del_cursor(tcur, XFS_BTREE_ERROR) to properly release all resources.
fs/xfs/libxfs/xfs_btree.c +2 -2
@@ -2567,7 +2567,7 @@ xfs_btree_lshift(if (XFS_IS_CORRUPT (tcur->bc_mp, i !=1 )) {xfs_btree_mark_sick (cur); error = -EFSCORRUPTED ; - goto error0; + goto error1; } error =xfs_btree_decrement (tcur, level, &i);
@@ -2737,7 +2737,7 @@ xfs_btree_rshift(if (XFS_IS_CORRUPT (tcur->bc_mp, i !=1 )) {xfs_btree_mark_sick (cur); error = -EFSCORRUPTED ; - goto error0; + goto error1; } error =xfs_btree_increment (tcur, level, &i);