Skip to contentSkip to conversation

clk: ast2700: Bind the SCU child nodes

PATCH In review Tan Siewert 2 participants 2 messages Nov 10 – Nov 11

Subsystems (3)
Common clk Arm/Aspeed machine support Arm/Aspeed clock support
lore
Share & tools
lore

Tan Siewert

author
#0 lore raw

PATCH 1/1 clk: ast2700: Bind the SCU child nodes

From: Pedro Maione <[email protected]>

The SCU nodes are bound by the clock driver, which matches their first compatible. Their pinctrl@400 children are never scanned, so the SoC0 and SoC1 pinctrl drivers never bind, and a pinctrl-0 reference to a state under them fails silently at probe.

Scan the children from the clock driver bind, as the generic syscon driver would.

Signed-off-by Pedro Maione <[email protected]>
Signed-off-by Tan Siewert <[email protected]>
---
 drivers/clk/aspeed/clk_ast2700.c | 5 +++++
 1 file changed, 5 insertions(+)
drivers/clk/aspeed/clk_ast2700.c +5 -0
index ca76abef48f..30487c592fa 100644
@@ -918,6 +918,11 @@ static int ast2700_clk_bind(struct udevice *dev)
 			debug("Warning: failed to bind reset controller: ret = %d\n", ret);
 	}
 
+	/* The SCU node is bound as a clock device, so bind its pinctrl child */
+	ret = dm_scan_fdt_dev(dev);
+	if (ret)
+		debug("Warning: failed to bind SCU children: ret = %d\n", ret);
+
 	return 0;
 }

---
base-commit: 8c1ea2aa66386fa3c8ea829531f581847814a569
change-id: 20261110-ast2700-clk-scu-f6006ccd7975

Best regards,

Signature · 1 line
Tan Siewert <[email protected]>
maintainer
#1 lore raw
Quoted 41 lines

Subject: [PATCH] clk: ast2700: Bind the SCU child nodes

From: Pedro Maione <[email protected]>

The SCU nodes are bound by the clock driver, which matches their first compatible. Their pinctrl@400 children are never scanned, so the SoC0 and SoC1 pinctrl drivers never bind, and a pinctrl-0 reference to a state under them fails silently at probe.

Scan the children from the clock driver bind, as the generic syscon driver would.

Signed-off-by Pedro Maione <[email protected]>
Signed-off-by Tan Siewert <[email protected]>
---
 drivers/clk/aspeed/clk_ast2700.c | 5 +++++
 1 file changed, 5 insertions(+)
drivers/clk/aspeed/clk_ast2700.c +5 -1
index ca76abef48f..30487c592fa 100644
@@ -918,6 +918,11 @@ static int ast2700_clk_bind(struct udevice *dev)
 			debug("Warning: failed to bind reset controller: ret = %d\n",
 ret);
 	}
 
+	/* The SCU node is bound as a clock device, so bind its pinctrl child */
+	ret = dm_scan_fdt_dev(dev);
+	if (ret)
+		debug("Warning: failed to bind SCU children: ret = %d\n", ret);
+
 	return 0;
 }
 
 
---

base-commit: 8c1ea2aa66386fa3c8ea829531f581847814a569
change-id: 20261110-ast2700-clk-scu-f6006ccd7975

Quoted 3 lines

Best regards,
--
Tan Siewert <[email protected]>

Hello Tan,

I do submit the patch in u-boot thread. Please check on this.
https://lists.u-boot-project.org/pipermail/u-boot/2026-November/638491.html
Thanks.

Ryan