Skip to contentSkip to conversation

WARN() after second suspend on omapdrm

BUG Andreas Kemnade 1 participant 1 message Nov 11

lore
Share & tools
lore
#0 lore raw

Hi,

This is an older bug, no idea what strange side effects it might have:

[ 1841.775390] PM: suspend entry (deep)
[ 1841.775726] Filesystems sync: 0.000 seconds
[ 1841.776824] Freezing user space processes
[ 1841.778594] Freezing user space processes completed (elapsed 0.001 seconds)
[ 1841.778625] OOM killer disabled.
[ 1841.778625] Freezing remaining freezable tasks
[ 1841.806243] Freezing remaining freezable tasks completed (elapsed 0.027 seconds)
[ 1841.806274] printk: Suspending console(s) (use no_console_suspend to debug)
[ 1841.833557] ------------[ cut here ]------------
[ 1841.833587] WARNING: drivers/gpu/drm/omapdrm/omap_overlay.c:123 at omap_plane_atomic_check+0x1ec/0x438 [omapdrm], CPU#0: rtcwake/813
[ 1841.833740] Modules linked in: omapdrm wl18xx wlcore mac80211 libarc4 usb_f_mass_storage panel_tpo_td028ttec1 usb_f_ncm u_ether libcomposite cfg80211 joydev mousedev evdev snd_soc_simple_card spi_gpio spi_bitbang snd_soc_simple_card_utils snd_soc_omap_twl4030 pwm_omap_dmtimer simple_bridge phy_generic display_connector cpufreq_dt pwm_bl gpio_keys omap_wdt bmg160_spi bmp280_spi bq27xxx_battery_hdq bq27xxx_battery omap_sham wlcore_sdio omap_rng omap_aes_driver crypto_engine rng_core omap_crypto ledtrig_default_on omap2430 phy_twl4030_usb musb_hdrc omap_hdq wire cn hwmon bmp280_i2c udc_core bmg160_i2c bmg160_core bmp280 usbcore twl4030_wdt bno055_i2c leds_tca6507 watchdog at24 tsc2007 usb_common bno055 rtc_twl led_class hci_uart btbcm snd_soc_twl4030 snd_soc_omap_mcbsp snd_soc_ti_sdma twl4030_pwrbutton bluetooth snd_soc_core twl4030_madc pwm_twl_led pwm_twl snd_pcm_dmaengine twl4030_charger snd_pcm bmc150_accel_i2c bmc150_accel_core bmc150_magn_i2c bmc150_magn industrialio_triggered_buffer kfifo_buf snd_timer
[ 1841.834350]  industrialio ecdh_generic ecc crc_ccitt snd soundcore omap_mailbox rfkill drm_client_lib drm_display_helper cec drm_panel drm_kms_helper drm omap_ssi hsi drm_panel_orientation_quirks [last unloaded: omapdrm]
[ 1841.834503] CPU: 0 UID: 0 PID: 813 Comm: rtcwake Not tainted 7.4.0-rc2-00005-g105c1f8efb05 #213 VOLUNTARY 
[ 1841.834533] Hardware name: Generic OMAP36xx (Flattened Device Tree)
[ 1841.834533] Call trace: 
[ 1841.834564]  unwind_backtrace from show_stack+0x28/0x2c
[ 1841.834594]  show_stack from dump_stack_lvl+0x34/0x70
[ 1841.834655]  dump_stack_lvl from __warn+0xf0/0x1fc
[ 1841.834686]  __warn from warn_slowpath_fmt+0x124/0x17c
[ 1841.834716]  warn_slowpath_fmt from omap_plane_atomic_check+0x1ec/0x438 [omapdrm]
[ 1841.834838]  omap_plane_atomic_check [omapdrm] from drm_atomic_helper_check_planes+0x104/0x230 [drm_kms_helper]
[ 1841.834991]  drm_atomic_helper_check_planes [drm_kms_helper] from drm_atomic_helper_check+0x58/0xa0 [drm_kms_helper]
[ 1841.835052]  drm_atomic_helper_check [drm_kms_helper] from omap_atomic_check+0x28/0x20c [omapdrm]
[ 1841.835144]  omap_atomic_check [omapdrm] from drm_atomic_check_only+0x5d0/0x9fc [drm]
[ 1841.835449]  drm_atomic_check_only [drm] from drm_atomic_commit+0x78/0xe4 [drm]
[ 1841.835693]  drm_atomic_commit [drm] from drm_atomic_helper_disable_all+0x170/0x1cc [drm_kms_helper]
[ 1841.835845]  drm_atomic_helper_disable_all [drm_kms_helper] from drm_atomic_helper_suspend+0xb8/0x1b4 [drm_kms_helper]
[ 1841.835937]  drm_atomic_helper_suspend [drm_kms_helper] from drm_mode_config_helper_suspend+0x44/0x80 [drm_kms_helper]
[ 1841.835998]  drm_mode_config_helper_suspend [drm_kms_helper] from dpm_run_callback+0x5c/0x1fc
[ 1841.836059]  dpm_run_callback from device_suspend+0x2cc/0x728
[ 1841.836090]  device_suspend from dpm_suspend+0x1d8/0x34c
[ 1841.836120]  dpm_suspend from dpm_suspend_start+0x50/0x80
[ 1841.836151]  dpm_suspend_start from suspend_devices_and_enter+0x70/0x894
[ 1841.836181]  suspend_devices_and_enter from pm_suspend+0x264/0x3f4

The system is the GTA04 with DPI panel attached.

How to reproduce: boot to console, suspend twice.

The waring is from omap_overlay_release()

        if (WARN_ON(!overlay_map[overlay->idx]))

Observations: omap_overlay_assign() only get called initially. omap_overlay_release() gets called on first suspend without errors. No omap_overlay_assign() call after that.

Then on second suspend, the WARN() comes. After resume the display comes up back again. But that all feels not healthy.

Verdict:

omap_plane_atomic_check() releases overlay and zeros the pointer when suspned going from visible -> invisible. On resume when going from invisible -> visible somehow an old state pops up with that old overlay pointer.

commit
2e54ff0e54308 ("drm/omap: dynamically assign hw overlays to planes") is probably involved.

Regards,
Andreas