Skip to contentSkip to conversation

Input: tsc2007 - drop platform data support and cleanups

PATCH In review Dmitry Torokhov 5 participants 15 messages Nov 12 – Nov 15

Subsystems (3)
lore
Share & tools
lore

Dmitry Torokhov

author maintainer
#0 lore raw

cover Input: tsc2007 - drop platform data support and cleanups

Now that all in-tree boards using tsc2007 (including SuperH ecovec24) have been converted to generic device properties, this series drops legacy platform data support and its header file, removes redundant memory barriers, fixes minor coding style issues, skips registering a non-functional input device when no interrupt is wired (when the chip is used purely as an IIO ADC), and uses IRQF_NO_AUTOEN when requesting the threaded interrupt.

Thanks.

Dmitry Torokhov (5):
Input: tsc2007 - drop platform data support
Input: tsc2007 - remove unneeded memory barriers
Input: tsc2007 - fix minor coding style issues
Input: tsc2007 - do not register input device without IRQ
Input: tsc2007 - use IRQF_NO_AUTOEN when requesting interrupt

 arch/sh/boards/mach-ecovec24/setup.c     |   1 -
 drivers/input/touchscreen/tsc2007.h      |   5 +-
 drivers/input/touchscreen/tsc2007_core.c | 183 ++++++++---------------
 include/linux/platform_data/tsc2007.h    |  23 ---
 4 files changed, 60 insertions(+), 152 deletions(-)
 delete mode 100644 include/linux/platform_data/tsc2007.h
Signature · 1 line
2.56.0.567.gdb80ae8cd5-goog
author maintainer
#1 lore raw

PATCH 1/5 Input: tsc2007 - drop platform data support

Now that all in-tree board files (including SuperH ecovec24) have been converted to generic device properties, legacy platform data support is no longer needed.

Remove the platform data structure and associated hardware callbacks from the driver, check the pen-down GPIO directly, and remove the unused platform data header file.

---
 arch/sh/boards/mach-ecovec24/setup.c     |  1 -
 drivers/input/touchscreen/tsc2007.h      |  4 --
 drivers/input/touchscreen/tsc2007_core.c | 89 +++---------------------
 include/linux/platform_data/tsc2007.h    | 23 ------
 4 files changed, 10 insertions(+), 107 deletions(-)
 delete mode 100644 include/linux/platform_data/tsc2007.h
arch/sh/boards/mach-ecovec24/setup.c +0 -1
index f662a296a54c..1e41ed9d2cce 100644
@@ -24,7 +24,6 @@
 #include <linux/gpio/machine.h>
 #include <linux/platform_data/gpio_backlight.h>
 #include <linux/platform_data/tmio.h>
-#include <linux/platform_data/tsc2007.h>
 #include <linux/platform_device.h>
 #include <linux/property.h>
 #include <linux/regulator/fixed.h>
drivers/input/touchscreen/tsc2007.h +0 -4
index e346fb4f7552..f65186b8e709 100644
@@ -65,7 +65,6 @@ struct tsc2007 {
 	struct i2c_client	*client;
 
 	struct touchscreen_properties prop;
-	u16			model;
 	u16			x_plate_ohms;
 	u16			max_rt;
 	unsigned long		poll_period; /* in jiffies */
@@ -79,9 +78,6 @@ struct tsc2007 {
 	wait_queue_head_t	wait;
 	bool			stopped;
 
-	int			(*get_pendown_state)(struct device *);
-	void			(*clear_penirq)(void);
-
 	struct mutex		mlock;
 };
 
drivers/input/touchscreen/tsc2007_core.c +10 -79

156 lines not on this page · raw message

include/linux/platform_data/tsc2007.h deleted +0 -23
deleted file mode 100644
index a0ca52c41ccb..000000000000
@@ -1,23 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0 */
-#ifndef __LINUX_I2C_TSC2007_H
-#define __LINUX_I2C_TSC2007_H
-
-/* linux/platform_data/tsc2007.h */
-
-struct tsc2007_platform_data {
-	u16	model;				/* 2007. */
-	u16	x_plate_ohms;	/* must be non-zero value */
-	u16	max_rt; /* max. resistance above which samples are ignored */
-	unsigned long poll_period; /* time (in ms) between samples */
-	int	fuzzx; /* fuzz factor for X, Y and pressure axes */
-	int	fuzzy;
-	int	fuzzz;
-
-	int	(*get_pendown_state)(struct device *);
-	/* If needed, clear 2nd level interrupt source */
-	void	(*clear_penirq)(void);
-	int	(*init_platform_hw)(void);
-	void	(*exit_platform_hw)(void);
-};
-
-#endif
Signature · 1 line
2.56.0.567.gdb80ae8cd5-goog
Reviewed-by on v1 1/5
#2 lore raw

Re: [PATCH 1/5] Input: tsc2007 - drop platform data support

Quoted 8 lines · Dmitry Torokhov

Now that all in-tree board files (including SuperH ecovec24) have been converted to generic device properties, legacy platform data support is no longer needed.

Remove the platform data structure and associated hardware callbacks from the driver, check the pen-down GPIO directly, and remove the unused platform data header file.

Very good!

--
With Best Regards,
Andy Shevchenko

author maintainer
#3 lore raw

PATCH 2/5 Input: tsc2007 - remove unneeded memory barriers

In reply to Dmitry Torokhov

The driver invokes mb() after setting the stopped flag in tsc2007_stop() and tsc2007_open(). These mandatory barriers lack pairing barriers on the reader side and are unnecessary.

The wait queue operations wake_up() and wait_event_timeout(), along with disable_irq() and enable_irq(), already provide the required synchronization and memory ordering when stopping and starting the touchscreen worker thread. Remove the redundant barriers.

---
 drivers/input/touchscreen/tsc2007_core.c | 2 --
 1 file changed, 2 deletions(-)
drivers/input/touchscreen/tsc2007_core.c +0 -2
index b3c4c0c9c42d..51e4d985afcc 100644
@@ -171,7 +171,6 @@ static irqreturn_t tsc2007_soft_irq(int irq, void *handle)
 static void tsc2007_stop(struct tsc2007 *ts)
 {
 	ts->stopped = true;
-	mb();
 	wake_up(&ts->wait);
 
 	if (ts->irq)
@@ -184,7 +183,6 @@ static int tsc2007_open(struct input_dev *input_dev)
 	int err;
 
 	ts->stopped = false;
-	mb();
 
 	if (ts->irq)
 		enable_irq(ts->irq);
Signature · 1 line
2.56.0.567.gdb80ae8cd5-goog
Reviewed-by Andy Shevhcneko on v1 2/5
#4 lore raw

Re: [PATCH 2/5] Input: tsc2007 - remove unneeded memory barriers

Quoted 4 lines · Dmitry Torokhov

The driver invokes mb() after setting the stopped flag in tsc2007_stop() and tsc2007_open(). These mandatory barriers lack pairing barriers on the reader side and are unnecessary.

...and they lack the comment why.

Quoted 4 lines

The wait queue operations wake_up() and wait_event_timeout(), along with disable_irq() and enable_irq(), already provide the required synchronization and memory ordering when stopping and starting the touchscreen worker thread. Remove the redundant barriers.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
author maintainer
#5 lore raw

PATCH 3/5 Input: tsc2007 - fix minor coding style issues

In reply to Dmitry Torokhov

Fix minor checkpatch warnings and checks across the tsc2007 driver:
document the mutex used to serialize I2C transfers between interrupt handling and IIO reads, remove an unnecessary blank line following a loop opening brace, and drop extraneous spacing after a cast.

---
 drivers/input/touchscreen/tsc2007.h      | 1 +
 drivers/input/touchscreen/tsc2007_core.c | 3 +--
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/input/touchscreen/tsc2007.h +1 -0
index f65186b8e709..e5153b420371 100644
@@ -78,6 +78,7 @@ struct tsc2007 {
 	wait_queue_head_t	wait;
 	bool			stopped;
 
+	/* Serializes I2C transfers between the ISR and IIO reads */
 	struct mutex		mlock;
 };
 
drivers/input/touchscreen/tsc2007_core.c +1 -2
index 51e4d985afcc..8197ad91ed8b 100644
@@ -82,7 +82,7 @@ u32 tsc2007_calculate_resistance(struct tsc2007 *tsc, struct ts_event *tc)
 
 	if (rt > U32_MAX)
 		return U32_MAX;
-	return (u32) rt;
+	return (u32)rt;
 }
 
 bool tsc2007_is_pen_down(struct tsc2007 *ts)
@@ -115,7 +115,6 @@ static irqreturn_t tsc2007_soft_irq(int irq, void *handle)
 	u32 rt;
 
 	while (!ts->stopped && tsc2007_is_pen_down(ts)) {
-
 		/* pen is down, continue with the measurement */
 
 		/* Serialize access between the ISR and IIO reads. */
Signature · 1 line
2.56.0.567.gdb80ae8cd5-goog
#6 lore raw

Re: [PATCH 3/5] Input: tsc2007 - fix minor coding style issues

Quoted 5 lines · Dmitry Torokhov

Fix minor checkpatch warnings and checks across the tsc2007 driver:
document the mutex used to serialize I2C transfers between interrupt handling and IIO reads, remove an unnecessary blank line following a loop opening brace, and drop extraneous spacing after a cast.

...

drivers/input/touchscreen/tsc2007_core.c u32 tsc2007_calculate_resistance(struct tsc2007 *tsc, struct ts_event *tc) · line 85

Quoted 6 lines

u32 tsc2007_calculate_resistance(struct tsc2007 *tsc, struct ts_event *tc)

        if (rt > U32_MAX)
                return U32_MAX;
drivers/input/touchscreen/tsc2007_core.c +1 -1
-       return (u32) rt;
+       return (u32)rt;

Do we need explicit casting?

Signature · 2 lines
With Best Regards,
Andy Shevchenko
author maintainer
#7 lore raw

PATCH 4/5 Input: tsc2007 - do not register input device without IRQ

In reply to Dmitry Torokhov

The driver has no polled input mode and only reports touchscreen input events from its threaded interrupt handler. When no interrupt is wired, the device is used solely as an IIO ADC, so registering an input device serves no purpose and creates a non-functional input node.

Only allocate, configure, and register the input device when an interrupt is present. This also allows removing the unnecessary ts->irq checks in the open and stop callbacks.

---
 drivers/input/touchscreen/tsc2007_core.c | 95 +++++++++++++-----------
 1 file changed, 51 insertions(+), 44 deletions(-)
drivers/input/touchscreen/tsc2007_core.c +51 -44
index 8197ad91ed8b..1fb2c26189ba 100644
@@ -172,8 +172,7 @@ static void tsc2007_stop(struct tsc2007 *ts)
 	ts->stopped = true;
 	wake_up(&ts->wait);
 
-	if (ts->irq)
-		disable_irq(ts->irq);
+	disable_irq(ts->irq);
 }
 
 static int tsc2007_open(struct input_dev *input_dev)
@@ -182,9 +181,7 @@ static int tsc2007_open(struct input_dev *input_dev)
 	int err;
 
 	ts->stopped = false;
-
-	if (ts->irq)
-		enable_irq(ts->irq);
+	enable_irq(ts->irq);
 
 	/* Prepare for touch readings - power down ADC and enable PENIRQ */
 	err = tsc2007_xfer(ts, PWRDOWN);
@@ -243,37 +240,19 @@ static int tsc2007_probe_properties(struct device *dev, struct tsc2007 *ts)
 	return 0;
 }
 
-static int tsc2007_probe(struct i2c_client *client)
+static int tsc2007_input_configure(struct tsc2007 *ts)
 {
-	struct tsc2007 *ts;
+	struct device *dev = &ts->client->dev;
 	struct input_dev *input_dev;
 	int err;
 
-	if (!i2c_check_functionality(client->adapter,
-				     I2C_FUNC_SMBUS_READ_WORD_DATA))
-		return -EIO;
-
-	ts = devm_kzalloc_obj(&client->dev, struct tsc2007);
-	if (!ts)
-		return -ENOMEM;
-
-	err = tsc2007_probe_properties(&client->dev, ts);
-	if (err)
-		return err;
-
-	input_dev = devm_input_allocate_device(&client->dev);
+	input_dev = devm_input_allocate_device(dev);
 	if (!input_dev)
 		return -ENOMEM;
 
-	ts->client = client;
-	ts->irq = client->irq;
 	ts->input = input_dev;
 
-	init_waitqueue_head(&ts->wait);
-	mutex_init(&ts->mlock);
-
-	snprintf(ts->phys, sizeof(ts->phys),
-		 "%s/input0", dev_name(&client->dev));
+	snprintf(ts->phys, sizeof(ts->phys), "%s/input0", dev_name(dev));
 
 	input_dev->name = "TSC2007 Touchscreen";
 	input_dev->phys = ts->phys;
@@ -291,20 +270,49 @@ static int tsc2007_probe(struct i2c_client *client)
 	input_set_abs_params(input_dev, ABS_PRESSURE, 0, MAX_12BIT,
 			     ts->fuzzz, 0);
 
-	if (ts->irq) {
-		err = devm_request_threaded_irq(&client->dev, ts->irq,
-						NULL, tsc2007_soft_irq,
-						IRQF_ONESHOT,
-						client->dev.driver->name, ts);
-		if (err) {
-			dev_err(&client->dev, "Failed to request irq %d: %d\n",
-				ts->irq, err);
-			return err;
-		}
+	err = devm_request_threaded_irq(dev, ts->irq,
+					NULL, tsc2007_soft_irq,
+					IRQF_ONESHOT,
+					dev->driver->name, ts);
+	if (err) {
+		dev_err(dev, "Failed to request irq %d: %d\n", ts->irq, err);
+		return err;
+	}
 
-		tsc2007_stop(ts);
+	tsc2007_stop(ts);
+
+	err = input_register_device(input_dev);
+	if (err) {
+		dev_err(dev, "Failed to register input device: %d\n", err);
+		return err;
 	}
 
+	return 0;
+}
+
+static int tsc2007_probe(struct i2c_client *client)
+{
+	struct tsc2007 *ts;
+	int err;
+
+	if (!i2c_check_functionality(client->adapter,
+				     I2C_FUNC_SMBUS_READ_WORD_DATA))
+		return -EIO;
+
+	ts = devm_kzalloc_obj(&client->dev, struct tsc2007);
+	if (!ts)
+		return -ENOMEM;
+
+	ts->client = client;
+	ts->irq = client->irq;
+
+	init_waitqueue_head(&ts->wait);
+	mutex_init(&ts->mlock);
+
+	err = tsc2007_probe_properties(&client->dev, ts);
+	if (err)
+		return err;
+
 	/* power down the chip (TSC2007_SETUP does not ACK on I2C) */
 	err = tsc2007_xfer(ts, PWRDOWN);
 	if (err < 0) {
@@ -313,14 +321,13 @@ static int tsc2007_probe(struct i2c_client *client)
 		return err;	/* chip does not respond */
 	}
 
-	err = input_register_device(input_dev);
-	if (err) {
-		dev_err(&client->dev,
-			"Failed to register input device: %d\n", err);
-		return err;
+	if (ts->irq) {
+		err = tsc2007_input_configure(ts);
+		if (err)
+			return err;
 	}
 
-	err =  tsc2007_iio_configure(ts);
+	err = tsc2007_iio_configure(ts);
 	if (err) {
 		dev_err(&client->dev,
 			"Failed to register with IIO: %d\n", err);
Signature · 1 line
2.56.0.567.gdb80ae8cd5-goog
#8 lore raw

Re: [PATCH 4/5] Input: tsc2007 - do not register input device without IRQ

Quoted 9 lines · Dmitry Torokhov

The driver has no polled input mode and only reports touchscreen input events from its threaded interrupt handler. When no interrupt is wired, the device is used solely as an IIO ADC, so registering an input device serves no purpose and creates a non-functional input node.

Only allocate, configure, and register the input device when an interrupt is present. This also allows removing the unnecessary ts->irq checks in the open and stop callbacks.

...

drivers/input/touchscreen/tsc2007_core.c static int tsc2007_open(struct input_dev *input_dev) · line 184

Quoted 5 lines
        ts->stopped = false;
drivers/input/touchscreen/tsc2007_core.c +1 -3
-
-       if (ts->irq)
-               enable_irq(ts->irq);
+       enable_irq(ts->irq);

Looking at this makes me think that if "stopped" is tightened to IRQ enablement, the IRQ framework already has an API which may be used instead of having a local flag. This can be achieved with irqd_irq_disabled(irq_get_irq_data(ts->irq)), but this is most likely for the other day.

...

drivers/input/touchscreen/tsc2007_core.c static int tsc2007_probe_properties(struct device *dev, struct tsc2007 *ts) · line 255

Quoted 3 lines
drivers/input/touchscreen/tsc2007_core.c +1 -2
-       snprintf(ts->phys, sizeof(ts->phys),
-                "%s/input0", dev_name(&client->dev));
+       snprintf(ts->phys, sizeof(ts->phys), "%s/input0", dev_name(dev));

Perhaps scnprintf() to avoid compiler warnings?

...

drivers/input/touchscreen/tsc2007_core.c static int tsc2007_probe(struct i2c_client *client)

Quoted 7 lines
drivers/input/touchscreen/tsc2007_core.c +6 -0
+       err = devm_request_threaded_irq(dev, ts->irq,
+                                       NULL, tsc2007_soft_irq,
+                                       IRQF_ONESHOT,
+                                       dev->driver->name, ts);
+       if (err) {
 
+               dev_err(dev, "Failed to request irq %d: %d\n", ts->irq, err);

This has to be dropped in a separate patch as dup. The above API prints the very similar message on error.

Quoted 2 lines
(quoted diff) +2 -0
+               return err;
+       }
Signature · 2 lines
With Best Regards,
Andy Shevchenko
author maintainer
#9 lore raw

PATCH 5/5 Input: tsc2007 - use IRQF_NO_AUTOEN when requesting interrupt

In reply to Dmitry Torokhov

Request the threaded interrupt with IRQF_NO_AUTOEN so that the interrupt line remains disabled after probe until the input device is opened by user space. Explicitly initialize the stopped flag to true before requesting the interrupt and drop the immediate tsc2007_stop() call.

---
 drivers/input/touchscreen/tsc2007_core.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/input/touchscreen/tsc2007_core.c +3 -3
index 1fb2c26189ba..7660504f58ff 100644
@@ -270,17 +270,17 @@ static int tsc2007_input_configure(struct tsc2007 *ts)
 	input_set_abs_params(input_dev, ABS_PRESSURE, 0, MAX_12BIT,
 			     ts->fuzzz, 0);
 
+	ts->stopped = true;
+
 	err = devm_request_threaded_irq(dev, ts->irq,
 					NULL, tsc2007_soft_irq,
-					IRQF_ONESHOT,
+					IRQF_ONESHOT | IRQF_NO_AUTOEN,
 					dev->driver->name, ts);
 	if (err) {
 		dev_err(dev, "Failed to request irq %d: %d\n", ts->irq, err);
 		return err;
 	}
 
-	tsc2007_stop(ts);
-
 	err = input_register_device(input_dev);
 	if (err) {
 		dev_err(dev, "Failed to register input device: %d\n", err);
Signature · 1 line
2.56.0.567.gdb80ae8cd5-goog
Reviewed-by on v1 5/5
#10 lore raw

Re: [PATCH 5/5] Input: tsc2007 - use IRQF_NO_AUTOEN when requesting interrupt

Quoted 5 lines · Dmitry Torokhov

Request the threaded interrupt with IRQF_NO_AUTOEN so that the interrupt line remains disabled after probe until the input device is opened by user space. Explicitly initialize the stopped flag to true before requesting the interrupt and drop the immediate tsc2007_stop() call.

I believe this also closes a window of possible IRQ storms or floods.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
Tested-by on the v1 series
#11 lore raw
In reply to Dmitry Torokhov

чт, 12 лист. 2026 р. о 08:50 Dmitry Torokhov <[email protected]> пише:

Quoted 25 lines

Now that all in-tree boards using tsc2007 (including SuperH ecovec24) have been converted to generic device properties, this series drops legacy platform data support and its header file, removes redundant memory barriers, fixes minor coding style issues, skips registering a non-functional input device when no interrupt is wired (when the chip is used purely as an IIO ADC), and uses IRQF_NO_AUTOEN when requesting the threaded interrupt.

Thanks.

Dmitry Torokhov (5):
Input: tsc2007 - drop platform data support
Input: tsc2007 - remove unneeded memory barriers
Input: tsc2007 - fix minor coding style issues
Input: tsc2007 - do not register input device without IRQ
Input: tsc2007 - use IRQF_NO_AUTOEN when requesting interrupt

 arch/sh/boards/mach-ecovec24/setup.c     |   1 -
 drivers/input/touchscreen/tsc2007.h      |   5 +-
 drivers/input/touchscreen/tsc2007_core.c | 183 ++++++++---------------
 include/linux/platform_data/tsc2007.h    |  23 ---
 4 files changed, 60 insertions(+), 152 deletions(-)
 delete mode 100644 include/linux/platform_data/tsc2007.h
Quoted 3 lines

--
2.56.0.567.gdb80ae8cd5-goog

Hello Dmitry!

I have tested this series on top of the latest next/master on the LG Optimus Vu P895. My device uses this chip as an ADC for battery temperature measurements.

Your patches works as expected. Input device was no longer registered, ADC part was present and worked as intended. Thank you!

All series

#12 lore raw

Hi Svyatoslav,

Quoted 36 lines · Svyatoslav Ryhel

чт, 12 лист. 2026 р. о 08:50 Dmitry Torokhov <[email protected]> пише:

Quoted 25 lines

Now that all in-tree boards using tsc2007 (including SuperH ecovec24) have been converted to generic device properties, this series drops legacy platform data support and its header file, removes redundant memory barriers, fixes minor coding style issues, skips registering a non-functional input device when no interrupt is wired (when the chip is used purely as an IIO ADC), and uses IRQF_NO_AUTOEN when requesting the threaded interrupt.

Thanks.

Dmitry Torokhov (5):
Input: tsc2007 - drop platform data support
Input: tsc2007 - remove unneeded memory barriers
Input: tsc2007 - fix minor coding style issues
Input: tsc2007 - do not register input device without IRQ
Input: tsc2007 - use IRQF_NO_AUTOEN when requesting interrupt

 arch/sh/boards/mach-ecovec24/setup.c     |   1 -
 drivers/input/touchscreen/tsc2007.h      |   5 +-
 drivers/input/touchscreen/tsc2007_core.c | 183 ++++++++---------------
 include/linux/platform_data/tsc2007.h    |  23 ---
 4 files changed, 60 insertions(+), 152 deletions(-)
 delete mode 100644 include/linux/platform_data/tsc2007.h
Quoted 3 lines

--
2.56.0.567.gdb80ae8cd5-goog

Hello Dmitry!

I have tested this series on top of the latest next/master on the LG Optimus Vu P895. My device uses this chip as an ADC for battery temperature measurements.

Quoted 6 lines

Your patches works as expected. Input device was no longer registered, ADC part was present and worked as intended. Thank you!

All series

Interesting. What kind of device is this? Is this a SuperH-based phone?

Adrian

Signature · 4 lines
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913
#13 lore raw

пт, 13 лист. 2026 р. о 11:55 John Paul Adrian Glaubitz <[email protected]> пише:

Quoted 40 lines

Hi Svyatoslav,

Quoted 36 lines · Svyatoslav Ryhel

чт, 12 лист. 2026 р. о 08:50 Dmitry Torokhov <[email protected]> пише:

Quoted 25 lines

Now that all in-tree boards using tsc2007 (including SuperH ecovec24) have been converted to generic device properties, this series drops legacy platform data support and its header file, removes redundant memory barriers, fixes minor coding style issues, skips registering a non-functional input device when no interrupt is wired (when the chip is used purely as an IIO ADC), and uses IRQF_NO_AUTOEN when requesting the threaded interrupt.

Thanks.

Dmitry Torokhov (5):
Input: tsc2007 - drop platform data support
Input: tsc2007 - remove unneeded memory barriers
Input: tsc2007 - fix minor coding style issues
Input: tsc2007 - do not register input device without IRQ
Input: tsc2007 - use IRQF_NO_AUTOEN when requesting interrupt

 arch/sh/boards/mach-ecovec24/setup.c     |   1 -
 drivers/input/touchscreen/tsc2007.h      |   5 +-
 drivers/input/touchscreen/tsc2007_core.c | 183 ++++++++---------------
 include/linux/platform_data/tsc2007.h    |  23 ---
 4 files changed, 60 insertions(+), 152 deletions(-)
 delete mode 100644 include/linux/platform_data/tsc2007.h
Quoted 3 lines

--
2.56.0.567.gdb80ae8cd5-goog

Hello Dmitry!

I have tested this series on top of the latest next/master on the LG Optimus Vu P895. My device uses this chip as an ADC for battery temperature measurements.

Quoted 9 lines
Quoted 6 lines

Your patches works as expected. Input device was no longer registered, ADC part was present and worked as intended. Thank you!

All series

Interesting. What kind of device is this? Is this a SuperH-based phone?

Quote from wiki:

The LG Optimus Vu (Also known as LG Intuition on Verizon) is an Android phablet smartphone released in August 2012 and noted for its 4:3 aspect ratio 5.0-inch screen size - between that of conventional smartphones, and larger tablets (sigh). It is powered by a 1.5 GHz quad-core Nvidia Tegra 3 CPU with Nvidia ULP GeForce GPU.

Quoted 7 lines

Adrian

--

 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913
Tested-by on the v1 series
#14 lore raw
In reply to Dmitry Torokhov
Quoted 17 lines · On Wed, 11 Nov 2026 22:50:32 -0800 Dmitry Torokhov <[email protected]>…

Now that all in-tree boards using tsc2007 (including SuperH ecovec24) have been converted to generic device properties, this series drops legacy platform data support and its header file, removes redundant memory barriers, fixes minor coding style issues, skips registering a non-functional input device when no interrupt is wired (when the chip is used purely as an IIO ADC), and uses IRQF_NO_AUTOEN when requesting the threaded interrupt.

Thanks.

Dmitry Torokhov (5):
Input: tsc2007 - drop platform data support
Input: tsc2007 - remove unneeded memory barriers
Input: tsc2007 - fix minor coding style issues
Input: tsc2007 - do not register input device without IRQ
Input: tsc2007 - use IRQF_NO_AUTOEN when requesting interrupt

Quoted 7 lines
 arch/sh/boards/mach-ecovec24/setup.c     |   1 -
 drivers/input/touchscreen/tsc2007.h      |   5 +-
 drivers/input/touchscreen/tsc2007_core.c | 183 ++++++++---------------
 include/linux/platform_data/tsc2007.h    |  23 ---
 4 files changed, 60 insertions(+), 152 deletions(-)
 delete mode 100644 include/linux/platform_data/tsc2007.h