Skip to contentSkip to conversation

KVM: nSVM: Add CET shadow stack MSRs to merge_msrs[]

PATCH New Jim Mattson 1 participant 1 message Nov 12

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 KVM: nSVM: Add CET shadow stack MSRs to merge_msrs[]

When shadow stack is enabled for a vCPU, svm_recalc_msr_intercepts() disables interception of MSR_IA32_U_CET, MSR_IA32_S_CET, and MSR_IA32_PL{0..3}_SSP in vmcb01's MSRPM. However, because these MSRs are missing from merge_msrs[] in nested_svm_init_msrpm_merge_offsets(), their MSRPM bits are never merged into vmcb02's MSRPM, and L0 continues to intercept L2 accesses to them even when L1 disables interception.

Add the CET shadow stack MSRs to merge_msrs[] and bump the size of nested_svm_msrpm_merge_offsets[] to accommodate their MSRPM chunk offset.

Fixes 38c46bdbf998 ("KVM: SVM: Pass through shadow stack MSRs as appropriate")
---
 arch/x86/kvm/svm/nested.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
arch/x86/kvm/svm/nested.c +8 -1
index 6298160458bc..1299fdadeb73 100644
@@ -209,7 +209,7 @@ void nested_vmcb02_recalc_intercepts(struct vcpu_svm *svm)
  * Hardcode the capacity of the array based on the maximum number of _offsets_.
  * MSRs are batched together, so there are fewer offsets than MSRs.
  */
-static int nested_svm_msrpm_merge_offsets[10] __ro_after_init;
+static int nested_svm_msrpm_merge_offsets[11] __ro_after_init;
 static int nested_svm_nr_msrpm_merge_offsets __ro_after_init;
 typedef unsigned long nsvm_msrpm_merge_t;
 
@@ -238,6 +238,13 @@ int __init nested_svm_init_msrpm_merge_offsets(void)
 		MSR_IA32_LASTINTFROMIP,
 		MSR_IA32_LASTINTTOIP,
 
+		MSR_IA32_U_CET,
+		MSR_IA32_S_CET,
+		MSR_IA32_PL0_SSP,
+		MSR_IA32_PL1_SSP,
+		MSR_IA32_PL2_SSP,
+		MSR_IA32_PL3_SSP,
+
 		MSR_K7_PERFCTR0,
 		MSR_K7_PERFCTR1,
 		MSR_K7_PERFCTR2,
Signature · 1 line
2.56.1.703.gf848ed807c-goog