Skip to contentSkip to conversation

macOS: build fix, resizable tunnels list, localization fixes, language menu and lint cleanups

PATCH Razvan Cremenescu 1 participant 1 message Nov 13 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

Hi Yoandy,

Thanks for testing the multiple tunnels series on macOS 27, and for carrying the sys/types.h fix. That is fine with me: it is the same patch as 01/10 of my series [1], so whichever series is applied first, the other copy can simply be dropped. Apart from that the two series only meet in Base.lproj/Localizable.strings, in different places, and your hunk applies cleanly on top of mine.

Since the GitHub repository is only a mirror, a Tested-by in reply to the series on the list would carry more weight than the comment on the pull request, if you don't mind adding one.

I went through yours. 3/7, 6/7 and 7/7 look good to me: the fallback in 3/7 helps every localization that lags behind Base, not only Spanish; unused_import only runs under swiftlint analyze, so analyzer_rules is where it belongs; and in a non-lazy property initializer self is indeed not the view controller.

One small thing in 2/7: whether to set the initial divider position is decided by reading "NSSplitView Subview Frames ManageTunnelsSplitView" from UserDefaults, which is the key AppKit uses internally for autosaveName and is not documented. A flag of your own would not depend on that format.

[1] https://lists.zx2c4.com/pipermail/wireguard/2026-August/009689.html

Thanks,
Razvan

multumesc,
razvan

---
Razvan Cremenescu
[email protected]

Quoted 71 lines · Yoandy Isse

Hi,

This series contains small, independent fixes for the macOS app that I ran into while using it daily. Each patch builds on its own on top of master (2fec12a).

Patch 1 is Razvan Cremenescu's build fix from his multiple-tunnels series [1]. Current master does not build with recent Xcode versions (tested with Xcode 27.2), so I included it here so that the rest of the series can be built and tested. It can be dropped if his series is applied first.

Patch 2 makes the tunnels list resizable, so long tunnel names can be read in full.

Patches 3 and 4 fix untranslated strings. Missing translations currently show up as raw keys (e.g. "macFieldKey (Interfaz)"), so patch 3 falls back to English for any key a localization lacks, which helps every language, and patch 4 completes the Spanish translation.

Patch 5 adds a Language menu, so the app's language can be changed without going through System Settings.

Patches 6 and 7 fix the remaining SwiftLint warnings. Patch 7 makes removeButton lazy: it passed self as its target from a non-lazy property initializer, where self is not the view controller. I checked that the button still removes the selected tunnel.

Tested on macOS 27.2.1 (Apple Silicon) with Xcode 27.2 and Go 1.27.4.

I also tested Razvan's multiple simultaneous tunnels series [1] on the same setup: two tunnels stay active at the same time, which is exactly what I needed (one tunnel for a site network
and another for a second network, as already works on Windows).

I'd be glad to help more with the Apple apps: reviewing and testing patches on new macOS releases, translations, and small fixes like these. If help with maintenance is welcome, please let me know how I can best contribute.

Thanks,
Yoandy

[1] https://github.com/WireGuard/wireguard-apple/pull/63

Razvan Cremenescu (1):
WireGuardKitC: include sys/types.h for BSD type definitions

Yoandy Isse (6):
macOS: make the tunnels list resizable
App: fall back to English for missing translations
App: es: complete and fix the Spanish translation
macOS: add a language menu
App: fix SwiftLint warnings
macOS: make removeButton lazy so its target is the view controller

.swiftlint.yml                                |   3 +-
.../Base.lproj/Localizable.strings            |  10 ++
Sources/WireGuardApp/LocalizationHelper.swift |  26 +++-
Sources/WireGuardApp/UI/macOS/MainMenu.swift  | 119 +++++++++++++++---
.../ManageTunnelsRootViewController.swift     |  44 +++++--
.../TunnelsListTableViewController.swift      |   5 +-
.../WireGuardApp/es.lproj/Localizable.strings | 112 +++++++++++------
Sources/WireGuardKitC/WireGuardKitC.h         |   2 +
8 files changed, 255 insertions(+), 66 deletions(-)
Signature · 1 line
2.54.0 (Apple Git-157)