Skip to contentSkip to conversation

ASoC: hdac_hda/soc-pcm: fix NULL ops.open() call and failed BE open cleanup

PATCH Kai Vehmanen 1 participant 1 message Nov 17 1 message not in the archive Sound

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Kai Vehmanen

author Reviewed-by
#1 lore raw

Hello,

Quoted 8 lines · Germán Poo-Caamaño

From: Germán Poo-Caamaño <[email protected]>

On a ThinkPad X1 Carbon Gen 10 (ALC287, SOF with skl_hda_dsp_generic), the codec sometimes comes up without pin configuration and the analog PCM has no playback stream. Opening the SOF analog playback PCM then calls a NULL ops.open() in hdac_hda_dai_open(). The task dies holding the card's DPCM mutex and system suspend can no longer freeze tasks.

thank you, for the series:

Covering the history with commit 06f07e236537 ("ASoC: hdac_hda: fix deadlock after PCM open error") and commit 00a0b46c99e2 ("ASoC: soc-dai:
add mark for snd_soc_dai_startup/shutdown()") in third patch is very helpful. And looks good.

Br, Kai