Skip to contentSkip to conversation

scsi: scsi_ioctl: require write access for the depopulation commands

PATCH Superseded Niklas Cassel 2 participants 3 messages Nov 16 – Nov 17

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: scsi_ioctl: require write access for the depopulation commands

scsi_cmd_allowed() lets anybody who can open a SCSI device, even read-only, send any SERVICE ACTION IN(16) command. Besides READ CAPACITY(16) and the other read-only service actions, that opcode also carries the storage element depopulation commands of SBC-4: REMOVE ELEMENT AND TRUNCATE, RESTORE ELEMENTS AND REBUILD and REMOVE ELEMENT AND MODIFY ZONES. These change the capacity of the device, and after REMOVE ELEMENT AND TRUNCATE the contents of the user data area may have no relation to what they were before.

SCSI devices that support depopulation execute these commands directly, and libata translates them to the equivalent ATA commands, so a user with read-only access to the device node can truncate the device through SG_IO, SCSI_IOCTL_SEND_COMMAND or bsg.

Treat these service actions like FORMAT UNIT and ERASE, which also destroy data, and only allow them if the device is opened for writing. The other SERVICE ACTION IN(16) service actions remain allowed for everybody who can open the device.

---
 drivers/scsi/scsi_ioctl.c | 16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)
drivers/scsi/scsi_ioctl.c +15 -1
index bf049d9cb719..91525103d074 100644
@@ -300,7 +300,6 @@ bool scsi_cmd_allowed(unsigned char *cmd, bool open_for_write)
 	case GPCMD_VERIFY_10:
 	case VERIFY_16:
 	case REPORT_LUNS:
-	case SERVICE_ACTION_IN_16:
 	case RECEIVE_DIAGNOSTIC:
 	case MAINTENANCE_IN: /* also GPCMD_SEND_KEY, which is a write command */
 	case GPCMD_READ_BUFFER_CAPACITY:
@@ -330,6 +329,21 @@ bool scsi_cmd_allowed(unsigned char *cmd, bool open_for_write)
 	/* ZBC */
 	case ZBC_IN:
 		return true;
+	/*
+	 * The storage element depopulation commands share the opcode of the
+	 * read-only SERVICE ACTION IN(16) commands, but change the capacity
+	 * of the device and may destroy its data, so treat them as writing
+	 * commands.
+	 */
+	case SERVICE_ACTION_IN_16:
+		switch (cmd[1] & 0x1f) {
+		case SAI_REMOVE_ELEMENT_AND_TRUNCATE:
+		case SAI_RESTORE_ELEMENTS_AND_REBUILD:
+		case SAI_REMOVE_ELEMENT_AND_MODIFY_ZONES:
+			return open_for_write;
+		default:
+			return true;
+		}
 	/* Basic writing commands */
 	case WRITE_6:
 	case WRITE_10:
Signature · 1 line
2.56.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Niklas Cassel

scsi_cmd_allowed() lets anybody who can open a SCSI device, even read-only, send any SERVICE ACTION IN(16) command. Besides READ CAPACITY(16) and the other read-only service actions, that opcode also carries the storage element depopulation commands of SBC-4: REMOVE ELEMENT AND TRUNCATE, RESTORE ELEMENTS AND REBUILD and REMOVE ELEMENT AND MODIFY ZONES. These change the capacity of the device, and after REMOVE ELEMENT AND TRUNCATE the contents of the user data area may have no relation to what they were before.

Since that is basically reformatting the drive, I thing we can say that the content is likely gone...

Quoted 11 lines

SCSI devices that support depopulation execute these commands directly, and libata translates them to the equivalent ATA commands, so a user with read-only access to the device node can truncate the device through SG_IO, SCSI_IOCTL_SEND_COMMAND or bsg.

Treat these service actions like FORMAT UNIT and ERASE, which also destroy data, and only allow them if the device is opened for writing. The other SERVICE ACTION IN(16) service actions remain allowed for everybody who can open the device.

Hmmm... SAI_REMOVE_ELEMENT_AND_TRUNCATE and friends was defined with 2a0adbb80a2f ("scsi: define depopulation capabilities related service actions"), which is in 7.3 only.

So maybe make that

?

Or maybe simply add:

Fixes db496721cb0d ("ata: libata-scsi: add support for the REMOVE ELEMENT AND

TRUNCATE command")

Fixes 1e307ca61a9c ("ata: libata-scsi: add support for the RESTORE ELEMENTS AND

REBUILD command")

Fixes b448bb42bd10 ("ata: libata-scsi: add support for the REMOVE ELEMENT AND

MODIFY ZONES command")

Quoted 1 line

Otherwise looks good.

Signature · 2 lines
Damien Le Moal
Western Digital Research
#2 lore raw
Quoted 29 lines · Damien Le Moal
Quoted 8 lines · Niklas Cassel

scsi_cmd_allowed() lets anybody who can open a SCSI device, even read-only, send any SERVICE ACTION IN(16) command. Besides READ CAPACITY(16) and the other read-only service actions, that opcode also carries the storage element depopulation commands of SBC-4: REMOVE ELEMENT AND TRUNCATE, RESTORE ELEMENTS AND REBUILD and REMOVE ELEMENT AND MODIFY ZONES. These change the capacity of the device, and after REMOVE ELEMENT AND TRUNCATE the contents of the user data area may have no relation to what they were before.

Since that is basically reformatting the drive, I thing we can say that the content is likely gone...

Quoted 11 lines

SCSI devices that support depopulation execute these commands directly, and libata translates them to the equivalent ATA commands, so a user with read-only access to the device node can truncate the device through SG_IO, SCSI_IOCTL_SEND_COMMAND or bsg.

Treat these service actions like FORMAT UNIT and ERASE, which also destroy data, and only allow them if the device is opened for writing. The other SERVICE ACTION IN(16) service actions remain allowed for everybody who can open the device.

Hmmm... SAI_REMOVE_ELEMENT_AND_TRUNCATE and friends was defined with 2a0adbb80a2f ("scsi: define depopulation capabilities related service actions"), which is in 7.3 only.

Quoted 5 lines

So maybe make that

?

I will add:

Cc <[email protected]> # 2a0adbb80a2f: scsi: define depopulation capabilities related service actions

to show the dependency as per Documentation/process/stable-kernel-rules.rst

because, while for SATA devices, this problem only exists since v7.3, for SAS, this problem is much older.

REMOVE ELEMENT AND TRUNCATE was introduced in SBC-4 (r10) - released on January 21, 2016.

REMOVE ELEMENT AND MODIFY ZONES command was introduced in ZBC-2 (r07), around 2020.

Kind regards,
Niklas