Skip to contentSkip to conversation

u-boot: fix CVE-2026-29009

PATCH New Prasanth R 1 participant 2 messages Nov 17

lore
Share & tools
lore

Prasanth R

author
#0 lore raw

PATCH 1/2 u-boot: fix CVE-2026-29009

A malicious NFS server can overflow nfs_path_buff with READLINK replies. Backport the upstream fix, as done for wrynose. It applies to 2024.01 unchanged.

AI-Generated: Uses Claude

---
Tested: built with CONFIG_CMD_NFS=y for qemux86-64. Also ran nfs_readlink_reply() from the unpatched and patched 2024.01 source under AddressSanitizer with two 1100-byte READLINK replies: without this patch it overflows nfs_path_buff, with it the second reply is dropped.

 .../u-boot/files/CVE-2026-29009.patch         | 53 +++++++++++++++++++
 meta/recipes-bsp/u-boot/u-boot_2024.01.bb     |  1 +
 2 files changed, 54 insertions(+)
 create mode 100644 meta/recipes-bsp/u-boot/files/CVE-2026-29009.patch
meta/recipes-bsp/u-boot/files/CVE-2026-29009.patch new file +53 -0
new file mode 100644
index 0000000000..35f168005e
@@ -0,0 +1,53 @@
+From d6694018eaddefac6aae974f9cec72fd6e58f1bc Mon Sep 17 00:00:00 2001
+From: Sebastian Josue Alba Vives <[email protected]>
+Date: Thu, 9 Apr 2026 10:44:40 -0600
+Subject: [PATCH] net: nfs: fix buffer overflow in nfs_readlink_reply()
+
+nfs_readlink_reply() validates rlen only against the incoming packet
+length (inherited from CVE-2019-14195), but not against the destination
+buffer nfs_path_buff[2048]. A malicious NFS server can send a valid
+READLINK reply where pathlen + rlen exceeds sizeof(nfs_path_buff),
+overflowing the BSS buffer into adjacent memory.
+
+The recent fix in fd6e3d34097f addressed the same overflow class in
+net/lwip/nfs.c but left the legacy path in net/nfs-common.c unpatched.
+
+Add bounds checks before both memcpy calls in nfs_readlink_reply():
+- relative path branch: reject if pathlen + rlen >=
+  sizeof(nfs_path_buff)
+- absolute path branch: reject if rlen >= sizeof(nfs_path_buff)
+
+Fixes: cf3a4f1e86 ("net: nfs: Fix CVE-2019-14195")
+
+CVE: CVE-2026-29009
+
+Upstream-Status: Backport [https://git.u-boot-project.org/u-boot/u-boot/-/commit/d6694018eaddefac6aae974f9cec72fd6e58f1bc]
+
+Cc: [email protected]
+Signed-off-by: Sebastian Alba Vives <[email protected]>
+Reviewed-by: Jerome Forissier <[email protected]>
+Signed-off-by: Roopa Kalmath <[email protected]>
+---
+ net/nfs.c | 4 ++++
+ 1 file changed, 4 insertions(+)
+
+diff --git a/net/nfs.c b/net/nfs.c
+index 537d4c62..9b628ecf 100644
+--- a/net/nfs.c
++++ b/net/nfs.c
+@@ -698,11 +698,15 @@ static int nfs_readlink_reply(uchar *pkt, unsigned len)
+ 
+ 		strcat(nfs_path, "/");
+ 		pathlen = strlen(nfs_path);
++		if (pathlen + rlen >= sizeof(nfs_path_buff))
++			return -NFS_RPC_DROP;
+ 		memcpy(nfs_path + pathlen,
+ 		       (uchar *)&(rpc_pkt.u.reply.data[2 + nfsv3_data_offset]),
+ 		       rlen);
+ 		nfs_path[pathlen + rlen] = 0;
+ 	} else {
++		if (rlen >= sizeof(nfs_path_buff))
++			return -NFS_RPC_DROP;
+ 		memcpy(nfs_path,
+ 		       (uchar *)&(rpc_pkt.u.reply.data[2 + nfsv3_data_offset]),
+ 		       rlen);
meta/recipes-bsp/u-boot/u-boot_2024.01.bb +1 -0
index 7eaeed1004..6aa98e1740 100644
@@ -13,4 +13,5 @@ SRC_URI += "file://CVE-2024-57254.patch \
             file://CVE-2024-57259.patch \
             file://CVE-2024-42040.patch \
             file://CVE-2026-46728.patch \
+            file://CVE-2026-29009.patch \
 "
Signature · 1 line
2.34.1
author
#1 lore raw

PATCH 2/2 u-boot-tools: ignore CVE-2026-29007, CVE-2026-29008 and CVE-2026-29009

u-boot-tools shares CVE_PRODUCT with u-boot, but tools-only_defconfig disables networking, so net/tcp.c and net/nfs.c are not built. Same status as on wrynose.

AI-Generated: Uses Claude

---
 meta/recipes-bsp/u-boot/u-boot-tools_2024.01.bb | 4 ++++
 1 file changed, 4 insertions(+)
meta/recipes-bsp/u-boot/u-boot-tools_2024.01.bb +4 -0
index 4b6d89ed4e..98c4954ec3 100644
@@ -2,3 +2,7 @@ require u-boot-common.inc
 require u-boot-tools.inc
 
 SRC_URI += "file://CVE-2026-46728.patch"
+
+CVE_STATUS[CVE-2026-29007] = "not-applicable-config: tools-only_defconfig disables networking; net/tcp.c is not compiled into u-boot-tools."
+CVE_STATUS[CVE-2026-29008] = "not-applicable-config: tools-only_defconfig disables networking; net/tcp.c is not compiled into u-boot-tools."
+CVE_STATUS[CVE-2026-29009] = "not-applicable-config: tools-only_defconfig disables networking; net/nfs.c is not compiled into u-boot-tools."
Signature · 1 line
2.34.1