Skip to contentSkip to conversation

selftests/bpf: Fix bpf-gcc CO-RE relocation in verifier_sockmap_mutate

PATCH Applied Jiayuan Chen 3 participants 3 messages Nov 17 – Nov 19

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 selftests/bpf: Fix bpf-gcc CO-RE relocation in verifier_sockmap_mutate

bpf-gcc fails to load test_trace_iter_unix:

Error: #766/6 verifier_sockmap_mutate/test_trace_iter_unix
libbpf: elf: skipping section(3) .data (size 0)
libbpf: elf: skipping unrecognized data section(18) .comment run_subtest:PASS:obj_open_mem 0 nsec
libbpf: prog 'test_trace_iter_unix': relo #0: insn #0 (LDX/ST/STX) accesses field incorrectly. ...
libbpf: prog 'test_trace_iter_unix': BPF program load failed: -EINVAL
libbpf: prog 'test_trace_iter_unix': failed to load: -EINVAL
libbpf: failed to load object 'verifier_sockmap_mutate' run_subtest:PASS:unexpected_load_success 0 nsec
validate_msgs:FAIL:1014 expect_msg
VERIFIER LOG:
=============
0: R1=ctx() R10=fp0
; @ verifier_sockmap_mutate.c:124
0: <invalid CO-RE relocation>
failed to resolve CO-RE relocation <byte_off> [4] struct bpf_iter__unix (0:0 @ offset 0) processed 1 insns (limit 1000000) max_states_per_insn 0 total_states 0 peak_states 0 mark_read 0
=============
EXPECTED SUBSTR: 'cannot update sockmap in this context'

GCC only applies preserve_access_index to types that carry the attribute themselves. The anonymous union holding the sock pointer doesn't, so the CO-RE access stops at the union ("0:0") instead of reaching the pointer ("0:0:0"), and libbpf rejects the relocation.

Fixes e16c83fa764f ("selftests/bpf: Add negative test for sockmap update from non-sockmap iter")

---
v1 : https://lore.kernel.org/bpf/[email protected]/

---
 .../selftests/bpf/progs/verifier_sockmap_mutate.c     | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)
tools/testing/selftests/bpf/progs/verifier_sockmap_mutate.c +2 -9
index 1516fe1524bb..0dbbc5ad1de9 100644
@@ -10,19 +10,12 @@
 
 char _license[] SEC("license") = "GPL";
 
-struct sock {
-} __attribute__((preserve_access_index));
-
 struct bpf_iter__sockmap {
-	union {
-		struct sock *sk;
-	};
+	struct sock *sk;
 } __attribute__((preserve_access_index));
 
 struct bpf_iter__unix {
-	union {
-		struct sock *unix_sk;
-	};
+	struct sock *unix_sk;
 } __attribute__((preserve_access_index));
 
 struct {
Signature · 1 line
2.43.0
reviewer Acked-by on v2 1/1
#1 lore raw
Quoted 22 lines · Jiayuan Chen

bpf-gcc fails to load test_trace_iter_unix:

Error: #766/6 verifier_sockmap_mutate/test_trace_iter_unix
libbpf: elf: skipping section(3) .data (size 0)
libbpf: elf: skipping unrecognized data section(18) .comment run_subtest:PASS:obj_open_mem 0 nsec
libbpf: prog 'test_trace_iter_unix': relo #0: insn #0 (LDX/ST/STX) accesses field incorrectly. ...
libbpf: prog 'test_trace_iter_unix': BPF program load failed: -EINVAL
libbpf: prog 'test_trace_iter_unix': failed to load: -EINVAL
libbpf: failed to load object 'verifier_sockmap_mutate' run_subtest:PASS:unexpected_load_success 0 nsec
validate_msgs:FAIL:1014 expect_msg
VERIFIER LOG:
=============
0: R1=ctx() R10=fp0
; @ verifier_sockmap_mutate.c:124
0: <invalid CO-RE relocation>
failed to resolve CO-RE relocation <byte_off> [4] struct bpf_iter__unix (0:0 @ offset 0) processed 1 insns (limit 1000000) max_states_per_insn 0 total_states 0 peak_states 0 mark_read 0
=============
EXPECTED SUBSTR: 'cannot update sockmap in this context'

Quoted 7 lines

GCC only applies preserve_access_index to types that carry the attribute themselves. The anonymous union holding the sock pointer doesn't, so the CO-RE access stops at the union ("0:0") instead of reaching the pointer ("0:0:0"), and libbpf rejects the relocation.

Fixes e16c83fa764f ("selftests/bpf: Add negative test for sockmap update from non-sockmap iter")

CI confirms the patch works:

Failing: https://github.com/kernel-patches/bpf/actions/runs/44576883691/job/135760256786
Passing with the fix: https://github.com/kernel-patches/bpf/actions/runs/44083943280/job/134048457373

Thanks for the fix!

Quoted 1 line

[...]

#2 lore raw
In reply to Jiayuan Chen
This patch was applied to bpf/bpf.git (master) by Alexei Starovoitov <[email protected]>:

Hello:

This patch was applied to bpf/bpf.git (master)
by Alexei Starovoitov <[email protected]>:

Quoted 22 lines · On Tue, 17 Nov 2026 20:24:13 +0800 you wrote:

bpf-gcc fails to load test_trace_iter_unix:

Error: #766/6 verifier_sockmap_mutate/test_trace_iter_unix
libbpf: elf: skipping section(3) .data (size 0)
libbpf: elf: skipping unrecognized data section(18) .comment run_subtest:PASS:obj_open_mem 0 nsec
libbpf: prog 'test_trace_iter_unix': relo #0: insn #0 (LDX/ST/STX) accesses field incorrectly. ...
libbpf: prog 'test_trace_iter_unix': BPF program load failed: -EINVAL
libbpf: prog 'test_trace_iter_unix': failed to load: -EINVAL
libbpf: failed to load object 'verifier_sockmap_mutate' run_subtest:PASS:unexpected_load_success 0 nsec
validate_msgs:FAIL:1014 expect_msg
VERIFIER LOG:
=============
0: R1=ctx() R10=fp0
; @ verifier_sockmap_mutate.c:124
0: <invalid CO-RE relocation>
failed to resolve CO-RE relocation <byte_off> [4] struct bpf_iter__unix (0:0 @ offset 0) processed 1 insns (limit 1000000) max_states_per_insn 0 total_states 0 peak_states 0 mark_read 0
=============
EXPECTED SUBSTR: 'cannot update sockmap in this context'

Quoted 1 line

[...]

Here is the summary with links:
- [bpf,v2] selftests/bpf: Fix bpf-gcc CO-RE relocation in verifier_sockmap_mutate

    https://git.kernel.org/bpf/bpf/c/7543d8d314b2

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html