Skip to contentSkip to conversation

acl: restore ptest

PATCH New Alexander Kanavin 1 participant 1 message Nov 17

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 acl: restore ptest

From: Alexander Kanavin <[email protected]>

There was a regression in 2.4.0 version update where no tests were run anymore and that wasn't detected, as acl test harness (./run) returns a success code when passed in a bogus testcase name, and run-ptest then prints PASS: for it.

Upstream has renamed tests from .test to .run, adjust accordingly.

Obtain a list of tests from final Makefile, as getting them from automake originals also silently returns nothing.

Add misc.run to the list of problematic tests as it now fails similarly to the other excluded tests.

---
 meta/recipes-support/attr/acl/run-ptest | 2 +-
 meta/recipes-support/attr/acl_2.4.0.bb  | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)
meta/recipes-support/attr/acl/run-ptest +1 -1
index f28d8c12122..88dae09fbd1 100644
@@ -4,7 +4,7 @@ failed=0
 all=0
 
 
-for f in *.test; do
+for f in *.run; do
     LD_PRELOAD=$(pwd)/libtestlookup.so ./run $f
     case "$?" in
         0)
meta/recipes-support/attr/acl_2.4.0.bb +3 -3
index d470989acc5..a257542185a 100644
@@ -37,16 +37,16 @@ do_install_ptest() {
         install -m644 ${S}/test/*.acl ${D}${PTEST_PATH}/
 
         # Install the tests
-        for t in $(makefile-getvar ${S}/test/Makemodule.am TESTS); do
+        for t in $(makefile-getvar ${B}/Makefile TESTS); do
                 install -m644 ${S}/$t ${D}${PTEST_PATH}/
         done
         # Remove the tests that are expected to fail (they need a NFS server configured)
-        for t in $(makefile-getvar ${S}/test/Makemodule.am XFAIL_TESTS); do
+        for t in $(makefile-getvar ${B}/Makefile XFAIL_TESTS); do
                 rm ${D}${PTEST_PATH}/$(basename $t)
         done
         # These tests need a very specific user/group setup
         # (https://savannah.nongnu.org/bugs/index.php?66927)
-        rm -f ${D}${PTEST_PATH}/getfacl.test ${D}${PTEST_PATH}/permissions.test ${D}${PTEST_PATH}/restore.test ${D}${PTEST_PATH}/setfacl.test
+        rm -f ${D}${PTEST_PATH}/getfacl.run ${D}${PTEST_PATH}/misc.run ${D}${PTEST_PATH}/permissions.run ${D}${PTEST_PATH}/restore.run ${D}${PTEST_PATH}/setfacl.run
 
         ${B}/libtool --mode=install install ${B}/libtestlookup.la ${D}${PTEST_PATH}/
         rm -f ${D}${PTEST_PATH}/*.la
Signature · 1 line
2.47.3