rust: DamFence: Remove warning about unsignaled drop
Subsystems (4)
Philipp Stanner
maintainerPATCH v2 1/1 rust: DamFence: Remove warning about unsignaled drop
DriverFence::drop() contains a pr_warn!() for when the fence drops unsignaled. This warning gets into the way of canonical teardown in
Rust: when you drop a lock, it unlocks itself, when you drop a KBox, it frees itself etc. Congruently, users should be able to tear down fences they don't care about anymore with ECANCELED, which is already the default error code.
Remove the warning.
Suggested-by Danilo Krummrich <[email protected]>
Signed-off-by Philipp Stanner <[email protected]>
---
Changes in v2:
- Also update the documentation accordingly.
--- rust/kernel/dma_buf/dma_fence.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
rust/kernel/dma_buf/dma_fence.rs +3 -3
@@ -631,8 +631,9 @@ struct DriverFenceData<'a, T: Send + Sync + FenceContextOps> {/// It is crucial that a [`DriverFence`] always correctly represents the state /// of the associated job on the hardware. Especially, it is strictly necessary /// that the owner ensures that all [`DriverFence`]s eventually get signaled. -/// As a last resort, a [`DriverFence`] will signal itself if it drops -/// unsignaled and print a warning. +/// +/// A [`DriverFence`] that drops unsignaled will signal itself with the error +/// code ECANCELED. /// /// This design intends to implement the [`bindings::dma_fence_ops`] in such a /// way that the driver-data necessary to implement the callback's functionality
@@ -942,7 +943,6 @@ fn drop(&mut self) {// SAFETY: `guard` is valid until the `call_rcu()` below. let signaled:bool =unsafe { bindings::dma_fence_test_signaled_flag (guard.as_raw ()) };if !signaled { -pr_err! ("DriverFence drops unsignaled. Danger of memory corruption!\n" );// SAFETY: `guard` is valid until the `call_rcu()` below. The fence // must not have been signaled yet, which we check directly above. unsafe { bindings::dma_fence_set_error (guard.as_raw (),ECANCELED .to_errno ()) };
Signature · 1 line
2.56.0
Daniel Almeida
reviewerHi Philipp,
Just pointing out that the same typo from v1 remains, i.e.: DamFence
— Daniel