ASoC: atmel: Mark interrupt registers as volatile
cover ASoC: atmel: Mark interrupt registers as volatile
From: bui duc phuc <[email protected]>
Hi all,
This series marks the interrupt mask and status registers as volatile in the PDMC and SPDIFTX drivers to ensure they are read from hardware.
Compile-tested only.
Best regards,
Phuc
bui duc phuc (2):
ASoC: atmel: mchp-pdmc: Mark IMR as volatile
ASoC: atmel: mchp-spdiftx: Mark interrupt registers as volatile
sound/soc/atmel/mchp-pdmc.c | 1 + sound/soc/atmel/mchp-spdiftx.c | 12 ++++++++++++ 2 files changed, 13 insertions(+)
Signature · 1 line
2.43.0
PATCH 1/2 ASoC: atmel: mchp-pdmc: Mark IMR as volatile
From: bui duc phuc <[email protected]>
The interrupt handler reads ISR and IMR to determine which interrupts are pending. While ISR is marked as volatile, IMR is not, causing regmap to return its cached value instead of reading the hardware.
Add IMR to the volatile registers.
--- sound/soc/atmel/mchp-pdmc.c | 1 + 1 file changed, 1 insertion(+)
sound/soc/atmel/mchp-pdmc.c +1 -0
@@ -842,6 +842,7 @@ static bool mchp_pdmc_volatile_reg(struct device *dev, unsigned int reg) {switch (reg) {case MCHP_PDMC_ISR : +case MCHP_PDMC_IMR :case MCHP_PDMC_RHR :return true;default :
Signature · 1 line
2.43.0
PATCH 2/2 ASoC: atmel: mchp-spdiftx: Mark interrupt registers as volatile
In reply to [email protected]From: bui duc phuc <[email protected]>
The interrupt handler reads ISR and IMR to determine which interrupts are pending. Neither register is marked as volatile, causing regmap to return cached values instead of reading the hardware.
Add a volatile_reg callback marking IMR and ISR as volatile.
--- sound/soc/atmel/mchp-spdiftx.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)
sound/soc/atmel/mchp-spdiftx.c +12 -0
@@ -165,6 +165,17 @@ static bool mchp_spdiftx_precious_reg(struct device *dev, unsigned int reg) } } +static bool mchp_spdiftx_volatile_reg (struct device *dev,unsigned int reg) +{ +switch (reg) { +case SPDIFTX_IMR : +case SPDIFTX_ISR : +return true; +default : +return false; + } +} +static const struct regmap_config mchp_spdiftx_regmap_config = { .reg_bits =32 , .reg_stride =4 ,
@@ -173,6 +184,7 @@ static const struct regmap_config mchp_spdiftx_regmap_config = { .readable_reg = mchp_spdiftx_readable_reg, .writeable_reg = mchp_spdiftx_writeable_reg, .precious_reg = mchp_spdiftx_precious_reg, + .volatile_reg = mchp_spdiftx_volatile_reg, .cache_type = REGCACHE_FLAT, };
Signature · 1 line
2.43.0
[email protected]
AI reviewRe: [PATCH 2/2] ASoC: atmel: mchp-spdiftx: Mark interrupt registers as volatile
Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Low] ASoC: atmel: mchp-spdiftx: inaccurate Fixes trailer --
Thank you for your contribution! Sashiko AI review found 1 potential issue to consider:
- [Low] ASoC: atmel: mchp-spdiftx: inaccurate Fixes trailer --
commit 8b049b6663dc075bd7b0f48f483d1e20b6fe30c6
Author: bui duc phuc <[email protected]>
Quoted 10 lines
ASoC: atmel: mchp-spdiftx: Mark interrupt registers as volatile
The interrupt handler reads ISR and IMR to determine which interrupts are pending. Neither register is marked as volatile, causing regmap to return cached values instead of reading the hardware.
Add a
volatile_regcallback marking IMR and ISR as volatile.Fixes 06ca24e98e6b ("ASoC: mchp-spdiftx: add driver for S/PDIF TX Controller")Signed-off-by bui duc phuc <[email protected]>
[Severity: Low]
In commit 06ca24e98e6b ("ASoC: mchp-spdiftx: add driver for S/PDIF TX Controller"), mchp_spdiftx_regmap_config left .cache_type unset (REGCACHE_NONE), so regmap_read() read SPDIFTX_ISR and SPDIFTX_IMR directly from hardware. Regmap caching was enabled later in commit 4bf54ca60f99 ("ASoC: mchp-spdiftx: add runtime pm support"), which added .cache_type = REGCACHE_FLAT without a .volatile_reg callback.
Should the Fixes tag reference that commit instead?
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2
[email protected]
AI reviewRe: [PATCH 1/2] ASoC: atmel: mchp-pdmc: Mark IMR as volatile
In reply to [email protected]Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Low] ASoC: atmel: mchp-pdmc: inaccurate Fixes trailer citing 50291652af52 --
Thank you for your contribution! Sashiko AI review found 1 potential issue to consider:
- [Low] ASoC: atmel: mchp-pdmc: inaccurate Fixes trailer citing 50291652af52
--
commit 2524e29a52dc348922861fcb11ff3299de1fc52e
Author: bui duc phuc <[email protected]>
Quoted 11 lines
ASoC: atmel: mchp-pdmc: Mark IMR as volatile
The interrupt handler reads ISR and IMR to determine which interrupts are pending. While ISR is marked as volatile, IMR is not, causing regmap to return its cached value instead of reading the hardware.
Add IMR to the volatile registers.
Fixes c5682e2ba132 ("ASoC: mchp-pdmc: fix poc noise at capture startup")Fixes 50291652af52 ("ASoC: atmel: mchp-pdmc: add PDMC driver")Signed-off-by bui duc phuc <[email protected]>
[Severity: Low]
In 50291652af52 ("ASoC: atmel: mchp-pdmc: add PDMC driver"), mchp_pdmc_regmap_config did not enable regmap caching, so regmap_read() on MCHP_PDMC_IMR always read from hardware. Regmap caching (.cache_type = REGCACHE_FLAT) was enabled in e8c8e9de4ee3 ("ASoC:
mchp-pdmc: use runtime pm for clock power saving") without marking MCHP_PDMC_IMR volatile.
Should the second Fixes: tag reference e8c8e9de4ee3 ("ASoC: mchp-pdmc:
use runtime pm for clock power saving") instead of 50291652af52 ("ASoC:
atmel: mchp-pdmc: add PDMC driver")?
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
Re: [PATCH 2/2] ASoC: atmel: mchp-spdiftx: Mark interrupt registers as volatile
In reply to [email protected]Quoted 11 lines
[Severity: Low]
In commit06ca24e98e6b("ASoC: mchp-spdiftx: add driver for S/PDIF TX Controller"),mchp_spdiftx_regmap_configleft .cache_type unset (REGCACHE_NONE), soregmap_read()readSPDIFTX_ISRandSPDIFTX_IMRdirectly from hardware. Regmap caching was enabled later in commit4bf54ca60f99("ASoC: mchp-spdiftx: add runtime pm support"), which added .cache_type =REGCACHE_FLATwithout a .volatile_reg callback.Should the Fixes tag reference that commit instead?
Fixes 4bf54ca60f99 ("ASoC: mchp-spdiftx: add runtime pm support")
Commit 06ca24e98e6b already fixes 4bf54ca60f99, so I included both commits in the Fixes tags.
I don't think this is a critical issue, so I'll wait for the maintainer's opinion.
Re: [PATCH 2/2] ASoC: atmel: mchp-spdiftx: Mark interrupt registers as volatile
Quoted 9 lines · Bui Duc Phuc
Quoted 9 lines
[Severity: Low]
In commit06ca24e98e6b("ASoC: mchp-spdiftx: add driver for S/PDIF TX Controller"),mchp_spdiftx_regmap_configleft .cache_type unset (REGCACHE_NONE), soregmap_read()readSPDIFTX_ISRandSPDIFTX_IMRdirectly from hardware. Regmap caching was enabled later in commit4bf54ca60f99("ASoC: mchp-spdiftx: add runtime pm support"), which added .cache_type =REGCACHE_FLATwithout a .volatile_reg callback.
Quoted 8 lines
Quoted 3 lines
Should the Fixes tag reference that commit instead?
Fixes 4bf54ca60f99 ("ASoC: mchp-spdiftx: add runtime pm support")Commit
06ca24e98e6balready fixes4bf54ca60f99, so I included both commits in the Fixes tags.
I don't think this is a critical issue, so I'll wait for the maintainer's opinion.
Sorry, I got that wrong. You're right. I'll update the Fixes tag to:
Quoted 1 line
Fixes 4bf54ca60f99 ("ASoC: mchp-spdiftx: add runtime pm support")
Re: [PATCH 1/2] ASoC: atmel: mchp-pdmc: Mark IMR as volatile
In reply to [email protected]Quoted 9 lines
[Severity: Low]
In50291652af52("ASoC: atmel: mchp-pdmc: add PDMC driver"),mchp_pdmc_regmap_configdid not enable regmap caching, soregmap_read()onMCHP_PDMC_IMRalways read from hardware. Regmap caching (.cache_type =REGCACHE_FLAT) was enabled ine8c8e9de4ee3("ASoC:
mchp-pdmc: use runtime pm for clock power saving") without markingMCHP_PDMC_IMRvolatile.
Quoted 4 lines
Should the second Fixes: tag reference
e8c8e9de4ee3("ASoC: mchp-pdmc:
use runtime pm for clock power saving") instead of50291652af52("ASoC:
atmel: mchp-pdmc: add PDMC driver")?
Agreed. I'll update the second Fixes tag to reference e8c8e9de4ee3.