ALSA: usb-audio: quirk_flags parsing fix and Logitech PRO X 2 LIGHTSPEED quirk
cover ALSA: usb-audio: quirk_flags parsing fix and Logitech PRO X 2 LIGHTSPEED quirk
Patch 1 fixes parsing of flag names written to the quirk_flags module parameter with a trailing newline, as echo produces.
Patch 2 adds quirk flags for the Logitech PRO X 2 LIGHTSPEED receiver (046d:0af7). This is a mitigation, not a fix. After a hotplug the receiver firmware resets itself on the first stream open, and also on repeated GET_STATUS requests or on SET_CONFIGURATION shortly after a port reset. It only behaves once it has gone through such a reset of its own. The flags avoid the worse failure, where the probe-time interface setup wedges the receiver for about 77 seconds.
The same receiver hotplugs without trouble on Windows and macOS. A USBPcap capture of a Windows hotplug, with G HUB installed, shows no missing request that made a difference when I tried it. Replaying G HUB's initial HID reports before the audio driver binds did not help, and neither did a host port reset. These differences were not isolated:
- Windows never sends GET_STATUS.
- It sets the playback alt setting once, about 0.9 s after configuration, and keeps it.
- It only reads the volume controls at probe.
Suggestions on how to narrow this down, or on whether the quirk should be expressed differently, are welcome. Captures and logs are available.
The device entry repeats CTL_MSG_DELAY_1M from the Logitech vendor entry, as the other Logitech device entries do, because a device entry replaces the vendor match. The receiver also worked with only SKIP_IFACE_SETUP | IFACE_DELAY. The PRO X Wireless (046d:0aba) entry does not carry the delay; Rong, I'm not sure whether that was intended.
Testing: with both patches applied, sound/usb/ builds without warnings with W=1 and checkpatch --strict is clean. Patch 2 was runtime-tested on a 7.3.5 stable kernel. Cold hotplugs on a front-panel (PROM21) port and a rear (CPU xHCI, behind a hub) port recover within half a second and then play normally.
Patch 1 was runtime-tested on the same kernel. Flag names written with a plain echo are applied, and an empty echo is ignored by the parser. The sysfs readback still shows the newline as written, because the parameter stores the raw string. That is cosmetic and left unchanged.
Christopher Snowhill (2):
ALSA: usb-audio: Ignore trailing whitespace in quirk_flags
ALSA: usb-audio: Add quirk flags for Logitech PRO X 2 LIGHTSPEED
sound/usb/quirks.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
base-commit: 58161ead29e50d70a317ea26b472e0c7508e69da
Signature · 1 line
2.56.0
PATCH 1/2 ALSA: usb-audio: Ignore trailing whitespace in quirk_flags
Writing a flag name to the quirk_flags module parameter through sysfs with echo leaves a trailing newline on the string. The parser keeps it as part of the last flag name, so a valid flag is rejected:
snd_usb_audio: unknown flag SKIP_IFACE_SETUP
while parsing param quirk_flags
Numeric flags are not affected because kstrtou64() accepts a trailing newline. Strip leading and trailing whitespace before parsing.
--- sound/usb/quirks.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/usb/quirks.c +1 -1
@@ -2765,7 +2765,7 @@ void snd_usb_init_quirk_flags_parse_string(struct snd_usb_audio *chip,if (!val)return ; -for (p = val; p && *p;) { +for (p =strim (val); p && *p;) {/* Each entry consists of VID:PID:flags */ field =strsep (&p,":" );if (!field)
Signature · 1 line
2.56.0
PATCH 2/2 ALSA: usb-audio: Add quirk flags for Logitech PRO X 2 LIGHTSPEED
In reply to [email protected]The receiver of the Logitech PRO X 2 LIGHTSPEED headset (046d:0af7) resets itself on ordinary requests such as SET_INTERFACE when it has been hotplugged and not yet gone through a reset of its own. When the probe-time interface setup runs shortly after configuration, the receiver can instead stop answering control requests altogether until its watchdog resets it about 77 seconds later, and the headset may not pair afterwards.
Skip the probe-time interface setup, so that the first alt setting change happens at stream open. The receiver still resets once there, but re-enumerates within half a second and then works normally. Also set IFACE_DELAY: the delay after SET_INTERFACE lets the receiver drop off before the sample rate request is sent; otherwise that request is in flight when the device disappears and the disconnect waits for the control message timeout, delaying recovery by five seconds.
Keep CTL_MSG_DELAY_1M from the Logitech vendor entry, which a device entry replaces.
A receiver that is present at boot is not affected.
--- sound/usb/quirks.c | 3 +++ 1 file changed, 3 insertions(+)
sound/usb/quirks.c +3 -0
@@ -2284,6 +2284,9 @@ static const struct usb_audio_quirk_flags_table quirk_flags_table[] = {DEVICE_FLG (0x046d ,0x0aba ,/* Logitech PRO X Wireless */ QUIRK_FLAG_MIXER_GET_CUR_OK |QUIRK_FLAG_MIXER_PLAYBACK_MIN_MUTE ), +DEVICE_FLG (0x046d ,0x0af7 ,/* Logitech PRO X 2 LIGHTSPEED */ +QUIRK_FLAG_CTL_MSG_DELAY_1M |QUIRK_FLAG_SKIP_IFACE_SETUP | +QUIRK_FLAG_IFACE_DELAY ),DEVICE_FLG (0x0499 ,0x1506 ,/* Yamaha THR5 */ QUIRK_FLAG_GENERIC_IMPLICIT_FB ), DEVICE_FLG(0x0499, 0x1509, /* Steinberg UR22 */
Signature · 1 line
2.56.0
Takashi Iwai
AppliedQuoted 41 lines · On Fri, 20 Nov 2026 13:03:46 +0100, [email protected] wrote:
Patch 1 fixes parsing of flag names written to the
quirk_flagsmodule parameter with a trailing newline, as echo produces.Patch 2 adds quirk flags for the Logitech PRO X 2 LIGHTSPEED receiver (046d:0af7). This is a mitigation, not a fix. After a hotplug the receiver firmware resets itself on the first stream open, and also on repeated
GET_STATUSrequests or onSET_CONFIGURATIONshortly after a port reset. It only behaves once it has gone through such a reset of its own. The flags avoid the worse failure, where the probe-time interface setup wedges the receiver for about 77 seconds.The same receiver hotplugs without trouble on Windows and macOS. A USBPcap capture of a Windows hotplug, with G HUB installed, shows no missing request that made a difference when I tried it. Replaying G HUB's initial HID reports before the audio driver binds did not help, and neither did a host port reset. These differences were not isolated:
- Windows never sendsGET_STATUS.
- It sets the playback alt setting once, about 0.9 s after configuration, and keeps it.
- It only reads the volume controls at probe.
Suggestions on how to narrow this down, or on whether the quirk should be expressed differently, are welcome. Captures and logs are available.The device entry repeats
CTL_MSG_DELAY_1Mfrom the Logitech vendor entry, as the other Logitech device entries do, because a device entry replaces the vendor match. The receiver also worked with onlySKIP_IFACE_SETUP|IFACE_DELAY. The PRO X Wireless (046d:0aba) entry does not carry the delay; Rong, I'm not sure whether that was intended.Testing: with both patches applied,
sound/usb/builds without warnings with W=1 and checkpatch --strict is clean. Patch 2 was runtime-tested on a 7.3.5 stable kernel. Cold hotplugs on a front-panel (PROM21) port and a rear (CPU xHCI, behind a hub) port recover within half a second and then play normally.
Patch 1 was runtime-tested on the same kernel. Flag names written with a plain echo are applied, and an empty echo is ignored by the parser. The sysfs readback still shows the newline as written, because the parameter stores the raw string. That is cosmetic and left unchanged.
Quoted 5 lines
Assisted-by AIChristopher Snowhill (2):
ALSA: usb-audio: Ignore trailing whitespace inquirk_flags
ALSA: usb-audio: Add quirk flags for Logitech PRO X 2 LIGHTSPEED
Applied both patches now. Thanks.
Takashi