Skip to contentSkip to conversation

O_EXCL in NFSv3

DISCUSSION J. R. Okajima 2 participants 3 messages Apr 12, 2011

lore
Share & tools
lore

J. R. Okajima

author
#0 lore raw

Hello Trond,

The commit in v2.6.37

	c0204fd 2010-09-17 NFS: Clean up nfs4_proc_create()

looks totally dropping O_EXCL flag from NFSv3.
But fs/nfs/nfs3proc.c:nfs3_proc_create() and fs/nfsd/nfs3proc.c:nfsd3_proc_create() still expect O_EXCL to be passed.

And the commit log says "Clean up nfs4_proc_create()". Is this change for NFSv3 intentional?
Actually O_EXCL in NFSv3 doesn't work in v2.6.37 and later.

J. R. Okajima

#1 lore raw
Quoted 11 lines · J. R. Okajima

Hello Trond,

The commit in v2.6.37

	c0204fd 2010-09-17 NFS: Clean up nfs4_proc_create()

looks totally dropping O_EXCL flag from NFSv3.
But fs/nfs/nfs3proc.c:nfs3_proc_create() and fs/nfsd/nfs3proc.c:nfsd3_proc_create() still expect O_EXCL to be passed.

And the commit log says "Clean up nfs4_proc_create()". Is this change for NFSv3 intentional?
Actually O_EXCL in NFSv3 doesn't work in v2.6.37 and later.

Doesn't commit 8a0eebf66e3b1deae036553ba641a9c2bdbae678 (NFS: Fix NFSv3 exclusive open semantics) fix this? It should be in the stable tree.

Signature · 6 lines
Trond Myklebust
Linux NFS client maintainer

NetApp
[email protected]
www.netapp.com
author
#2 lore raw

Trond Myklebust:

Quoted 2 lines

Doesn't commit 8a0eebf66e3b1deae036553ba641a9c2bdbae678 (NFS: Fix NFSv3 exclusive open semantics) fix this? It should be in the stable tree.

Ah, I can see the commit in v2.6.38.
So it is fixed already, sorry.
I just skipped all NFS tests for v2.6.38. due to the sillyrename problem.
Also I know it was fixed just after v2.6.38(.0).

Thank you
J. R. Okajima