bug in drivers/edac/mpc85xx_edac.c:mpc85xx_mc_check()
Dave, can you look at this
doug thompson
Quoted 84 lines · Jeff Haran
From: Jeff Haran <[email protected]>
Subject: bug in drivers/edac/mpc85xx_edac.c:mpc85xx_mc_check()
To: [email protected]
Date: Tuesday, April 28, 2009, 7:23 PM
Hi,Recent versions of this function contain the following snippets:
if (
err_detect&DDR_EDE_SBE)
edac_mc_handle_ce(mci, pfn,err_addr&PAGE_MASK,
syndrome,row_index, 0,mci->ctl_name);if (
err_detect&DDR_EDE_MBE)
edac_mc_handle_ue(mci, pfn,err_addr&PAGE_MASK,
row_index,mci->ctl_name);I am pretty sure the references to
PAGE_MASKshould be proceeded by a
tilda, as in:if (
err_detect&DDR_EDE_SBE)
edac_mc_handle_ce(mci, pfn,err_addr& ~PAGE_MASK,
syndrome,row_index, 0,mci->ctl_name);if (
err_detect&DDR_EDE_MBE)
edac_mc_handle_ue(mci, pfn,err_addr& ~PAGE_MASK,
row_index,mci->ctl_name);Much as I would like to submit a tested patch like the rest of the
world, I find myself in the situation where the only Freescale target
system I have to test on is running a 3 year old kernel (2.6.14), which
preceeds the introduction of EDAC driver support, at least for
Freescale. So the best I can do is borrow from the new EDAC driver and
backport it to the old kernel.But I have learned a few things in this process and can thus share what
I've learned as it may be of help to the EDAC driver developers:1) Before you read the Freescale 8548
CAPTURE_ADDRESSregister, you want
to readCAPTURE_ATTRIBUTESfirst and make sure the VLD bit (least
significant bit in the register) is set or else the data inCAPTURE_ADDRESSmay not be yet valid.2) When you are done scrubbing the memory with the single bit error, you
want to write 0 toCAPTURE_ATTRIBUTESso as to clear VLD and thus setup
the ECC capture logic to capture the next single bit error.Please include this email address in responses as I do not subscribe.
Thanks,
Jeff Haran
Brocade
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/