Skip to contentSkip to conversation

clk: imx: scu: Fix compile error with module build of clk-scu.o

PATCH In review Valdis Klētnieks 4 participants 8 messages Nov 2, 2020 – Nov 3, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 clk: imx: scu: Fix compile error with module build of clk-scu.o

commit 77d8f3068c63ee0983f0b5ba3207d3f7cce11be4 (HEAD)

Author: Dong Aisheng <[email protected]>
Date:   Wed Jul 29 16:00:10 2020 +0800

clk: imx: scu: add two cells binding support

This missed a #include, which results in some nasty errors when built as a module

CC [M] drivers/clk/imx/clk-scu.o
In file included from ./include/linux/device.h:32,

                 from ./include/linux/of_platform.h:9,
                 from drivers/clk/imx/clk-scu.c:11:

./include/linux/device/driver.h:290:1: warning: data definition has no type or storage class
device_initcall(__driver##_init);
^~~~~~~~~~~~~~~
./include/linux/platform_device.h:258:2: note: in expansion of macro 'builtin_driver'
builtin_driver(__platform_driver, platform_driver_register)
^~~~~~~~~~~~~~
drivers/clk/imx/clk-scu.c:545:1: note: in expansion of macro 'builtin_platform_driver'
builtin_platform_driver(imx_clk_scu_driver);
^~~~~~~~~~~~~~~~~~~~~~~
./include/linux/device/driver.h:290:1: error: type defaults to 'int' in declaration of 'device_initcall' [-Werror=implicit-int]
device_initcall(__driver##_init);
^~~~~~~~~~~~~~~
./include/linux/platform_device.h:258:2: note: in expansion of macro 'builtin_driver'
builtin_driver(__platform_driver, platform_driver_register)
^~~~~~~~~~~~~~
drivers/clk/imx/clk-scu.c:545:1: note: in expansion of macro 'builtin_platform_driver'
builtin_platform_driver(imx_clk_scu_driver);
^~~~~~~~~~~~~~~~~~~~~~~
drivers/clk/imx/clk-scu.c:545:1: warning: parameter names (without types) in function declaration
In file included from ./include/linux/device.h:32,

                 from ./include/linux/of_platform.h:9,
                 from drivers/clk/imx/clk-scu.c:11:
drivers/clk/imx/clk-scu.c:545:25: warning: 'imx_clk_scu_driver_init' defined but not used [-Wunused-function]
 builtin_platform_driver(imx_clk_scu_driver);
                         ^~~~~~~~~~~~~~~~~~
./include/linux/device/driver.h:286:19: note: in definition of macro 'builtin_driver'
 static int __init __driver##_init(void) \
                   ^~~~~~~~

drivers/clk/imx/clk-scu.c:545:1: note: in expansion of macro 'builtin_platform_driver'
builtin_platform_driver(imx_clk_scu_driver);
^~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
make[3]: *** [scripts/Makefile.build:283: drivers/clk/imx/clk-scu.o] Error 1

Fix by providing the include.

drivers/clk/imx/clk-scu.c +1 -0
index 229a290ca5b6..15d382f6f9f8 100644
@@ -8,6 +8,7 @@
 #include <linux/arm-smccc.h>
 #include <linux/clk-provider.h>
 #include <linux/err.h>
+#include <linux/module.h>
 #include <linux/of_platform.h>
 #include <linux/platform_device.h>
 #include <linux/pm_domain.h>
#1 lore raw
Quoted 41 lines · Valdis Klētnieks

commit 77d8f3068c63ee0983f0b5ba3207d3f7cce11be4 (HEAD)

Author: Dong Aisheng <[email protected]>
Date:   Wed Jul 29 16:00:10 2020 +0800

clk: imx: scu: add two cells binding support

This missed a #include, which results in some nasty errors when built as a module

CC [M] drivers/clk/imx/clk-scu.o
In file included from ./include/linux/device.h:32,

                 from ./include/linux/of_platform.h:9,
                 from drivers/clk/imx/clk-scu.c:11:

./include/linux/device/driver.h:290:1: warning: data definition has no type or storage class
device_initcall(__driver##_init);
^~~~~~~~~~~~~~~
./include/linux/platform_device.h:258:2: note: in expansion of macro 'builtin_driver'
builtin_driver(__platform_driver, platform_driver_register)
^~~~~~~~~~~~~~
drivers/clk/imx/clk-scu.c:545:1: note: in expansion of macro 'builtin_platform_driver'
builtin_platform_driver(imx_clk_scu_driver);
^~~~~~~~~~~~~~~~~~~~~~~
./include/linux/device/driver.h:290:1: error: type defaults to 'int' in declaration of 'device_initcall' [-Werror=implicit-int]
device_initcall(__driver##_init);
^~~~~~~~~~~~~~~
./include/linux/platform_device.h:258:2: note: in expansion of macro 'builtin_driver'
builtin_driver(__platform_driver, platform_driver_register)
^~~~~~~~~~~~~~
drivers/clk/imx/clk-scu.c:545:1: note: in expansion of macro 'builtin_platform_driver'
builtin_platform_driver(imx_clk_scu_driver);
^~~~~~~~~~~~~~~~~~~~~~~
drivers/clk/imx/clk-scu.c:545:1: warning: parameter names (without types) in function declaration
In file included from ./include/linux/device.h:32,

                 from ./include/linux/of_platform.h:9,
                 from drivers/clk/imx/clk-scu.c:11:
drivers/clk/imx/clk-scu.c:545:25: warning: 'imx_clk_scu_driver_init' defined but not used [-Wunused-function]
 builtin_platform_driver(imx_clk_scu_driver);
                         ^~~~~~~~~~~~~~~~~~
./include/linux/device/driver.h:286:19: note: in definition of macro 'builtin_driver'
 static int __init __driver##_init(void) \
                   ^~~~~~~~
Quoted 7 lines

drivers/clk/imx/clk-scu.c:545:1: note: in expansion of macro 'builtin_platform_driver'
builtin_platform_driver(imx_clk_scu_driver);
^~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
make[3]: *** [scripts/Makefile.build:283: drivers/clk/imx/clk-scu.o] Error 1

Fix by providing the include.

also

However, this driver does not directly use <linux/module.h>. platform_device.h #includes <linux/device.h>, which is where the problem lies:

<linux/device.h> uses macros that are provided by <linux/module.h> so <linux/device.h> should #include <linux/module.h>.

and that fixes this commit:

commit 4c002c978b7f2f2306d53de051c054504af920a9

Author: Greg Kroah-Hartman <[email protected]>
Date:   Mon Dec 9 20:33:03 2019 +0100

device.h: move 'struct driver' stuff out to device/driver.h

Quoted 17 lines
drivers/clk/imx/clk-scu.c +1 -0
index 229a290ca5b6..15d382f6f9f8 100644
@@ -8,6 +8,7 @@
 #include <linux/arm-smccc.h>
 #include <linux/clk-provider.h>
 #include <linux/err.h>
+#include <linux/module.h>
 #include <linux/of_platform.h>
 #include <linux/platform_device.h>
 #include <linux/pm_domain.h>
Signature · 1 line
~Randy
#2 lore raw
Quoted 4 lines · Randy Dunlap

also

However, this driver does not directly use <linux/module.h>.

Just my luck - I looked at 3 or 4 other things that include of_platform.h and they all *did* include module.h.

Quoted 6 lines

platform_device.h #includes <linux/device.h>, which is where the problem lies:

<linux/device.h> uses macros that are provided by <linux/module.h> so <linux/device.h> should #include <linux/module.h>.

Quoted 7 lines

and that fixes this commit:

commit 4c002c978b7f2f2306d53de051c054504af920a9

Author: Greg Kroah-Hartman <[email protected]>
Date:   Mon Dec 9 20:33:03 2019 +0100

device.h: move 'struct driver' stuff out to device/driver.h

OK.. who's going to do that? Me, or Randy, or Greg?

#3 lore raw
Quoted 18 lines · Valdis Klētnieks
Quoted 4 lines · Randy Dunlap

also

However, this driver does not directly use <linux/module.h>.

Just my luck - I looked at 3 or 4 other things that include of_platform.h and they all *did* include module.h.

Quoted 8 lines

platform_device.h #includes <linux/device.h>, which is where the problem lies:

<linux/device.h> uses macros that are provided by <linux/module.h> so <linux/device.h> should #include <linux/module.h>.

and that fixes this commit:

Quoted 7 lines
Quoted 5 lines

commit 4c002c978b7f2f2306d53de051c054504af920a9

Author: Greg Kroah-Hartman <[email protected]>
Date:   Mon Dec 9 20:33:03 2019 +0100

device.h: move 'struct driver' stuff out to device/driver.h

OK.. who's going to do that? Me, or Randy, or Greg?

You could go ahead... I began on it yesterday but didn't finish testing, although I did see the same build error that the 0day bot reported, so I don't know what it's going to take to fix that.

Signature · 1 line
~Randy
#4 lore raw
Quoted 23 lines · Randy Dunlap
Quoted 22 lines · Valdis Klētnieks
Quoted 4 lines · Randy Dunlap

also

However, this driver does not directly use <linux/module.h>.

Just my luck - I looked at 3 or 4 other things that include of_platform.h and they all *did* include module.h.

Quoted 12 lines

platform_device.h #includes <linux/device.h>, which is where the problem lies:

<linux/device.h> uses macros that are provided by <linux/module.h> so <linux/device.h> should #include <linux/module.h>.

and that fixes this commit:

commit 4c002c978b7f2f2306d53de051c054504af920a9

Author: Greg Kroah-Hartman <[email protected]>
Date:   Mon Dec 9 20:33:03 2019 +0100
Quoted 7 lines
Quoted 3 lines
Quoted 1 line

device.h: move 'struct driver' stuff out to device/driver.h

OK.. who's going to do that? Me, or Randy, or Greg?

You could go ahead... I began on it yesterday but didn't finish testing, although I did see the same build error that the 0day bot reported, so I don't know what it's going to take to fix that.

It's a driver problem which is being addressed by Dong's patch[1].

Shawn

[1] https://patchwork.kernel.org/project/linux-arm-kernel/patch/[email protected]/

#5 lore raw
Quoted 32 lines · Shawn Guo
Quoted 23 lines · Randy Dunlap
Quoted 22 lines · Valdis Klētnieks
Quoted 4 lines · Randy Dunlap

also

However, this driver does not directly use <linux/module.h>.

Just my luck - I looked at 3 or 4 other things that include of_platform.h and they all *did* include module.h.

Quoted 12 lines

platform_device.h #includes <linux/device.h>, which is where the problem lies:

<linux/device.h> uses macros that are provided by <linux/module.h> so <linux/device.h> should #include <linux/module.h>.

and that fixes this commit:

commit 4c002c978b7f2f2306d53de051c054504af920a9

Author: Greg Kroah-Hartman <[email protected]>
Date:   Mon Dec 9 20:33:03 2019 +0100
Quoted 7 lines
Quoted 3 lines
Quoted 1 line

device.h: move 'struct driver' stuff out to device/driver.h

OK.. who's going to do that? Me, or Randy, or Greg?

You could go ahead... I began on it yesterday but didn't finish testing, although I did see the same build error that the 0day bot reported, so I don't know what it's going to take to fix that.

Quoted 6 lines

It's a driver problem which is being addressed by Dong's patch[1].

Shawn

[1] https://patchwork.kernel.org/project/linux-arm-kernel/patch/[email protected]/

Thanks for the info & link.

Signature · 1 line
~Randy
#7 lore raw
In reply to Valdis Klētnieks
Thank you for the patch! Yet something to improve:

Hi "Valdis,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on shawnguo/for-next]
[also build test ERROR on next-20201102]
[cannot apply to clk/clk-next v5.10-rc2]
[If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Valdis-Kl-tnieks/clk-imx-scu-Fix-compile-error-with-module-build-of-clk-scu-o/20201102-200354
base:   https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git for-next
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0

reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/4fc6783d0d72b5c3c9e0ff96a391150584b85a0e
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Valdis-Kl-tnieks/clk-imx-scu-Fix-compile-error-with-module-build-of-clk-scu-o/20201102-200354 git checkout 4fc6783d0d72b5c3c9e0ff96a391150584b85a0e
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm

If you fix the issue, kindly add following tag as appropriate

All errors (new ones prefixed by >>):

arm-linux-gnueabi-ld: drivers/clk/imx/clk-imx8qxp.o: in function `imx8qxp_clk_driver_init':

>> clk-imx8qxp.c:(.init.text+0x0): multiple definition of `init_module'; drivers/clk/imx/clk-scu.o:clk-scu.c:(.init.text+0x0): first defined here

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org