Skip to contentSkip to conversation

Diskdump - yet another crash dump function

PATCH Andi Kleen 5 participants 6 messages May 27, 2004 – May 28, 2004 4 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Andi Kleen

author
#1 lore raw
Quoted 6 lines · Takao Indoh

Diskdump can be downloaded from here.
http://sourceforge.net/projects/lkdump
Please see readme.txt which can be downloaded from this site.

Any comments?

I like the concept - it's basically netconsole for SCSI drivers and the driver changes are surprisingly simple and clean.

But it would be better if it coexisted with LKCD so that netdump would also work. Can't you make it a low level driver for LKCD?

-Andi

#2 lore raw
Quoted 6 lines · Andi Kleen
Quoted 5 lines · Takao Indoh

Diskdump can be downloaded from here.
http://sourceforge.net/projects/lkdump
Please see readme.txt which can be downloaded from this site.

Quoted 7 lines
Quoted 1 line

Any comments?

I like the concept - it's basically netconsole for SCSI drivers and the driver changes are surprisingly simple and clean.

But it would be better if it coexisted with LKCD so that netdump would also work. Can't you make it a low level driver for LKCD?

LKCD is horribly bloated. IMHO it would be better to get a lean variant of netdump + possible this diskdump in instead of integrating it into the monster LKCD patch.

#3 lore raw
In reply to Andi Kleen

Hi,

Quoted 5 lines · Andi Kleen

I like the concept - it's basically netconsole for SCSI drivers and the driver changes are surprisingly simple and clean.

But it would be better if it coexisted with LKCD so that netdump would also work. Can't you make it a low level driver for LKCD?

One of the policy of diskdump is "simple structure".
LKCD has many funcitons (normal dump to disk, network dump, memdump,
...), so its structure is somewhat complex.

#4 lore raw
In reply to Andi Kleen
Quoted 5 lines · Andi Kleen

I like the concept - it's basically netconsole for SCSI drivers and the driver changes are surprisingly simple and clean.

But it would be better if it coexisted with LKCD so that netdump would also work. Can't you make it a low level driver for LKCD?

Diskdump can exist with netdump without LKCD. Actually in our system, diskdump and netdump both exist and can be selected by module loading. When both modules are loaded, diskdump runs first and if it detects I/O error when writing dump, it falls backs to netdump.

---
Nobuhiro Tachino
FUJITSU LIMITED

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

author
#8 lore raw
Quoted 2 lines · Ingo Molnar

yeah, this is arguably the biggest (and i think only) conceptual item that needs to be solved before this can be integrated.

I would think netdump is more important than this though (so if anything should be integrated i would start with netdump)

Quoted 2 lines

it would also be easier to enable diskdump in a driver if this was handled in add_timer()/del_timer()/mod_timer()/tasklet_schedule().

I don't think it's a good idea to add this to these fast paths. Timers are critical for lots of things, tasklet_schedule too.

How about a standard wrapper that does the check and everybody who may need that uses the wrappers ?

-Andi

#9 lore raw
Quoted 5 lines · Andi Kleen
Quoted 2 lines

yeah, this is arguably the biggest (and i think only) conceptual item that needs to be solved before this can be integrated.

I would think netdump is more important than this though (so if anything should be integrated i would start with netdump)

i think both are important. Dumping to disks is a frequent customer request, and not all setups can dump to a network, for performance, security or reliability reasons. The diskdump format is the same as the netdump format, and can be handled/analyzed by the same userspace tools, so in this sense it's an extension of netdump to another class of IO devices.

Quoted 8 lines
Quoted 2 lines

it would also be easier to enable diskdump in a driver if this was handled in add_timer()/del_timer()/mod_timer()/tasklet_schedule().

I don't think it's a good idea to add this to these fast paths. Timers are critical for lots of things, tasklet_schedule too.

How about a standard wrapper that does the check and everybody who may need that uses the wrappers ?

that's what the patch does currently. It needs to be decided one way or another. But it doesnt make alot of sense to introduce another vector of APIs for this purpose - it would need possibly wide driver changes for no good reason.

Ingo