mm: vmstat_kunit: add synthetic benchmark for mm stats
Subsystems (2)
PATCH v6 1/1 mm: vmstat_kunit: add synthetic benchmark for mm stats
From: Christoph Lameter <[email protected]>
Add a synthetic benchmark that can be used to measure performance of MM statistics. This is used to analyze any improvements or regressions in functions that are frequently used in hot code paths.
This is the first of three tests that measure the execution times of critical MM functions anticipated to be used by developers to measure the impact of any core changes that would end up causing workload performance issues. Vmstats are embedded into MM hotpaths, so any regression can cause performance and scalability impact for users. Google has carried these tests internally and kept them updated since Christoph posted them back in 2009 for this purpose.
This can also be used to detect regressions over time, from kernel version to kernel version, independent of development use cases.
The test is run by KUnit or doing modprobe vmstat_kunit directly.
Sample output:
KTAP version 1
1..1
KTAP version 1
# Subtest: vmstat
# module: vmstat_kunit
1..3
# vmstat_test_inc_dec_zone_page_state: 10000 ops: inc_zone_page_state -> 8 cycles (4 ns/op), dec_zone_page_state -> 9 cycles (4 ns/op)
ok 1 vmstat_test_inc_dec_zone_page_state
# vmstat_test_interleaved_zone_page_state: 10000 ops: inc/dec pair -> 17 cycles (8 ns/op)
ok 2 vmstat_test_interleaved_zone_page_state
# vmstat_test_count_vm_event: 10000 ops: count_vm_event -> 4 cycles (2 ns/op)
ok 3 vmstat_test_count_vm_event # vmstat: pass:3 fail:0 skip:0 total:3
# Totals: pass:3 fail:0 skip:0 total:3
ok 1 vmstat
---
v6:
- rebase on top of 7.4-rc1
- resend per akpm
DavidH said "Works for me. The tests are rather small and I see value in them." and I was this >< close to infering that as his Acked-by, but will leave it to him to do that explicitly.
Once we're happy with this change, I'll apply the same treatment to the proposed pgalloc and slab tests.
MAINTAINERS | 1 + mm/Kconfig | 12 +++ mm/Makefile | 1 + mm/tests/vmstat_kunit.c | 157 ++++++++++++++++++++++++++++++++++++++++ 4 files changed, 171 insertions(+) create mode 100644 mm/tests/vmstat_kunit.c
MAINTAINERS +1 -0
@@ -17551,6 +17551,7 @@ F: mm/mmzone.c F: mm/pagewalk.c F: mm/pgtable-generic.c F: mm/ptdump.c +F: mm/tests/vmstat_kunit.c F: mm/util.c F: mm/vmpressure.c F: mm/vmstat.c
mm/Kconfig +12 -0
@@ -1490,6 +1490,18 @@ config LAZY_MMU_MODE_KUNIT_TEST If unsure, say N. +config VMSTAT_KUNIT_TEST + tristate "KUnit test for VM statistics" if !KUNIT_ALL_TESTS + depends on VM_EVENT_COUNTERS + depends on KUNIT + default KUNIT_ALL_TESTS + help + Enable this option to test and benchmark the performance of VM + statistics updates (zone page state and VM event counters), which + are used frequently in hot memory management code paths. + + If unsure, say N. + config ARCH_HAS_CHECK_WX bool
mm/Makefile +1 -0
@@ -148,4 +148,5 @@ obj-$(CONFIG_SHRINKER_DEBUG) += shrinker_debug.o obj-$(CONFIG_EXECMEM) += execmem.o obj-$(CONFIG_TMPFS_QUOTA) += shmem_quota.o obj-$(CONFIG_LAZY_MMU_MODE_KUNIT_TEST) += tests/lazy_mmu_mode_kunit.o +obj-$(CONFIG_VMSTAT_KUNIT_TEST) += tests/vmstat_kunit.o obj-$(CONFIG_MEM_ALLOC_PROFILING) += alloc_tag.o
mm/tests/vmstat_kunit.c new file +157 -0
157 lines not on this page · raw message
Quoted 3 lines · David Rientjes
cause performance and scalability impact for users. Google has carried these tests internally and kept them updated since Christoph posted them back in 2009 for this purpose.
Thank you. I have a couple of more for atomics, slab, tlbs etc that have evolved over time and gathered specifics for the variuos platforms being benchmarked and the issues that it was used to track down. I can dump that stuff somehwere if there is an interest.