Skip to contentSkip to conversation

cciss: fix error reporting for SG_IO

DISCUSSION Stephen Cameron 1 participant 1 message Aug 26, 2007 SCSI

lore
Share & tools
lore
#0 lore raw
Quoted 9 lines
Quoted 8 lines

This fixes a problem with the way cciss was filling out the "errors" field of the request structure upon completion of requests. Previously, it just put a 1 or a 0 in there and used the negation of this as the uptodate parameter to one of the functions in the block layer, being a block device. For the SG_IO ioctl, this was not sufficient, and we noticed that, for example, sg_turs from sg3_utils did not correctly detect problems due to cciss having set rq->errors incorrectly.

Quoted 4 lines

Do we think this problem is sufficiently serious to merit merging this (largeish) patch into 2.6.23?

I'm thinking "no", but that might be wrong...

Without saying too much (I hope), if you want multipath i/o to cciss devices to work which depend on device mapper, (which I can't say what specific device(s) match that description without getting myself into trouble) then you want this patch. If my understanding is correct, then some DM multipath stuff depends on TUR response to know if a path is failed. If you don't care about that, then you can skip it.

-- steve

____________________________________________________________________________________
Moody friends. Drama queens. Your life? Nope! - their life, your story. Play Sims Stories at Yahoo! Games.
http://sims.yahoo.com/